Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 705842 - Policy Guide: =-deps with no revision
Summary: Policy Guide: =-deps with no revision
Status: RESOLVED FIXED
Alias: None
Product: Documentation
Classification: Unclassified
Component: Policy Guide (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Quality Assurance Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-01-19 13:54 UTC by Michał Górny
Modified: 2020-01-19 20:10 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
0001-dependencies-deps-with-no-revision.patch (0001-dependencies-deps-with-no-revision.patch,1.68 KB, text/x-diff)
2020-01-19 13:54 UTC, Michał Górny
Details
0001-dependencies-deps-with-no-revision.patch (0001-dependencies-deps-with-no-revision.patch,1.75 KB, patch)
2020-01-19 17:23 UTC, Michał Górny
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2020-01-19 13:54:01 UTC
Please review/vote on the attached patch.
Comment 1 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2020-01-19 13:54:16 UTC
Created attachment 603718 [details]
0001-dependencies-deps-with-no-revision.patch
Comment 2 Ulrich Müller gentoo-dev 2020-01-19 15:09:08 UTC
I'd suggest a small rewording (with one comma and two "the"s inserted):
"Whenever a non-wildcard = (equals) dependency is used on a package, the requested revision must be specified explicitly.  When the zeroth revision is requested, ``-r0`` must be used.  When no specific revision is necessary, the ~ (tilde) operator must be used instead."
Comment 3 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2020-01-19 17:23:52 UTC
Created attachment 603736 [details, diff]
0001-dependencies-deps-with-no-revision.patch

Updated as requested.
Comment 4 Ulrich Müller gentoo-dev 2020-01-19 17:40:54 UTC
(In reply to Michał Górny from comment #3)
> Created attachment 603736 [details, diff] [details, diff]
> 0001-dependencies-deps-with-no-revision.patch
> 
> Updated as requested.

LGTM
Comment 5 Larry the Git Cow gentoo-dev 2020-01-19 20:10:34 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/proj/policy-guide.git/commit/?id=7becf8322c2e53b484faa5565df3c3fcde2be85d

commit 7becf8322c2e53b484faa5565df3c3fcde2be85d
Author:     Michał Górny <mgorny@gentoo.org>
AuthorDate: 2020-01-19 13:53:05 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2020-01-19 20:10:03 +0000

    dependencies: =-deps with no revision
    
    Closes: https://bugs.gentoo.org/705842
    Closes: https://github.com/gentoo/policy-guide/pull/6
    Signed-off-by: Michał Górny <mgorny@gentoo.org>

 dependencies.rst | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)