Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 705694 - sys-block/fio : add USE=python
Summary: sys-block/fio : add USE=python
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Robin Johnson
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2020-01-17 21:12 UTC by trebegin
Modified: 2020-02-04 19:13 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description trebegin 2020-01-17 21:12:26 UTC
The current sys-block/fio package uses the `gnuplot` USE flag to control including python packages as dependencies:
https://gitweb.gentoo.org/repo/gentoo.git/tree/sys-block/fio/fio-3.16.ebuild

It accomplishes this by checking if the `gnuplot` USE flag is set, and then removing installed python files if it is not. However, there are other python files installed as a result of calling emake that are not related to gnuplot:

/usr/bin/fiologparser_hist.py
/usr/bin/fiologparser.py
/usr/bin/fio_jsonplus_clat2csv

I propose adding a new USE flag to this package, `python`, that would control if any python files are included. Then the `gnuplot` USE flag would only control if the gnuplot specific tools. The `gnuplot` USE flag would have to have a REQUIRED_USE flag of `python`.
Comment 1 trebegin 2020-01-22 21:14:17 UTC
I have opened a PR here: https://github.com/gentoo/gentoo/pull/14411
Comment 2 Larry the Git Cow gentoo-dev 2020-02-04 19:13:53 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=17cf8d112e79748a8116d05077aaf84790fe2c0f

commit 17cf8d112e79748a8116d05077aaf84790fe2c0f
Author:     Trent Begin <trebegin@gmail.com>
AuthorDate: 2020-01-30 19:22:53 +0000
Commit:     Mike Frysinger <vapier@gentoo.org>
CommitDate: 2020-02-04 19:13:44 +0000

    sys-block/fio: add python USE flag
    
    Closes: https://bugs.gentoo.org/705694
    Signed-off-by: Trent Begin <trebegin@gmail.com>
    Signed-off-by: Mike Frysinger <vapier@gentoo.org>

 profiles/arch/amd64/package.use.mask |   2 +-
 profiles/arch/base/package.use.mask  |   2 +-
 profiles/arch/x86/package.use.mask   |   2 +-
 sys-block/fio/fio-3.17-r1.ebuild     | 147 +++++++++++++++++++++++++++++++++++
 4 files changed, 150 insertions(+), 3 deletions(-)