Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 705550 - net-misc/rdesktop-1.9.0 - segmentation fault after protocol negotiation failure
Summary: net-misc/rdesktop-1.9.0 - segmentation fault after protocol negotiation failure
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Bernard Cafarelli
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2020-01-16 10:58 UTC by Gordon Bos
Modified: 2020-01-17 14:42 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
use correct modulus and exponent in rdssl_rkey_get_exp_mod (use correct modulus and exponent in rdssl_rkey_get_exp_mod.diff,489 bytes, patch)
2020-01-16 11:01 UTC, Gordon Bos
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gordon Bos 2020-01-16 10:58:54 UTC
When creating an RDP session with (at least) Windows 2003 and 2008 servers rdesktop returns the following output:

> is_wm_active(): WM name: GNOM
> Connecting to server using NLA...
> Protocol(warning): Protocol negotiation failed with reason: SSL not allowed by server
> Retrying with plain RDP.
> Segmentation fault (core dumped)

A workaround mentioned on the net is to enforce RDP 4 protocol, which in fact does solve the segmentation fault but causes various other issues like clipboard not functioning and mouse pointers becoming invisible in typeable areas of the shared screen.

The rdesktop project on GitHub has a post-release fix for this issue through commit 53ba87d, titled `use correct modulus and exponent in rdssl_rkey_get_exp_mod`, and I would like to propose that this is applied for an r1 update of this package.

The diff may be found here:
> https://github.com/rdesktop/rdesktop/commit/53ba87d.diff

Reproducible: Always
Comment 1 Gordon Bos 2020-01-16 11:01:07 UTC
Created attachment 603438 [details, diff]
use correct modulus and exponent in rdssl_rkey_get_exp_mod
Comment 2 Bernard Cafarelli gentoo-dev 2020-01-17 14:37:05 UTC
THanks for the report! With a small patch like that already committed upstream, no problem to push it in new revision ebuild
Comment 3 Larry the Git Cow gentoo-dev 2020-01-17 14:42:37 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6f47443f187582756e6817bf73647c524823c4c2

commit 6f47443f187582756e6817bf73647c524823c4c2
Author:     Bernard Cafarelli <voyageur@gentoo.org>
AuthorDate: 2020-01-17 14:42:06 +0000
Commit:     Bernard Cafarelli <voyageur@gentoo.org>
CommitDate: 2020-01-17 14:42:06 +0000

    net-misc/rdesktop: backport an upstream segfault fix
    
    This usually happens after "Retrying with plain RDP" message
    
    Closes: https://bugs.gentoo.org/705550
    Package-Manager: Portage-2.3.84, Repoman-2.3.20
    Signed-off-by: Bernard Cafarelli <voyageur@gentoo.org>

 .../rdesktop-1.9.0-rdssl_rkey_get_exp_mod.patch    | 26 ++++++++
 net-misc/rdesktop/rdesktop-1.9.0-r1.ebuild         | 78 ++++++++++++++++++++++
 2 files changed, 104 insertions(+)