The current check in _distutils_verify_use_setuptools fails to detect this (rather standard) use of "entry_points": setup([..] [..] entry_points={ [..] due to use of "\s+" in the related regex pattern at https://github.com/gentoo/gentoo/blob/a9c7ab9e889fca7f467c018f1f005876ba544d9c/eclass/distutils-r1.eclass#L450 . I propose this patch: --- if grep -E -q -s 'entry_points\s+=' setup.py; then +++ if grep -E -q -s 'entry_points\s*=' setup.py; then What do you think?
Yep, stupid thinko indeed. Please commit it.
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=aeefba0eeea1e6f03173331edcc26bf8c2f2a215 commit aeefba0eeea1e6f03173331edcc26bf8c2f2a215 Author: Sebastian Pipping <sping@gentoo.org> AuthorDate: 2020-01-13 18:56:12 +0000 Commit: Sebastian Pipping <sping@gentoo.org> CommitDate: 2020-01-13 19:00:29 +0000 distutils-r1.eclass: Fix detection of setuptools entry_points Closes: https://bugs.gentoo.org/705362 Signed-off-by: Michał Górny <mgorny@gentoo.org> Signed-off-by: Sebastian Pipping <sping@gentoo.org> eclass/distutils-r1.eclass | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
(In reply to Larry the Git Cow from comment #2) Nitpick for future reference: you probably should have used "Reviewed-by" instead of "Signed-off-by" for mgorny. You wrote the patch and committed it, so there is no point in a DCO sign-off from him. https://www.gentoo.org/glep/glep-0066.html#commit-messages
(In reply to Mike Gilbert from comment #3) > (In reply to Larry the Git Cow from comment #2) > > Nitpick for future reference: you probably should have used "Reviewed-by" > instead of "Signed-off-by" for mgorny. You wrote the patch and committed it, > so there is no point in a DCO sign-off from him. > > https://www.gentoo.org/glep/glep-0066.html#commit-messages Good point, thanks!
