Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 705224 - net-nds/rpcbind-1.2.5-r1 should optionally depend on sys-fs/quota[rpc]
Summary: net-nds/rpcbind-1.2.5-r1 should optionally depend on sys-fs/quota[rpc]
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-01-12 08:08 UTC by tdr
Modified: 2020-01-13 16:56 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description tdr 2020-01-12 08:08:32 UTC
quota support for rpcbind-1.2.5-r1 should not be required

Reproducible: Always

Steps to Reproduce:
1. attempt upgrade of rpcbind to rpcbind-1.2.5-r1
2. view new required deep
Actual Results:  
emerge: there are no ebuilds built with USE flags to satisfy "sys-fs/quota[rpc]".
!!! One of the following packages is required to complete your request:
- sys-fs/quota-4.05-r1::gentoo (Change USE: +rpc)
(dependency required by "net-nds/rpcbind-1.2.5-r1::gentoo" [ebuild])
(dependency required by "net-fs/nfs-utils-2.4.2-r1::gentoo" [installed])
(dependency required by "@selected" [set])
(dependency required by "@world" [argument])



Expected Results:  
no requirement on (locally unused) quota support if not desired

add IUSE flag quota
append use condtional line to CDEPEND
    quota? ( sys-fs/quota[rpc] ) 

under prepare phase (before configure):
    if quota flag not set
       then remove references that will cause it to fail:
              cd work directory
              sed -i "/RQUOTAPROG/d" ./src/security.c
              sed -i "/rquota.h/d" ./src/security.c

configured/compiles/works when built this way (without quota support)
will work on a patched ebuild for others to test
Comment 1 Jeroen Roovers (RETIRED) gentoo-dev 2020-01-12 08:37:31 UTC

*** This bug has been marked as a duplicate of bug 665222 ***
Comment 2 tdr 2020-01-13 02:01:02 UTC
The issues between this and the suggested duplicate bug 665222 are not the same.

Quota support is not required for rpcbind to function and quotas often aren't used with nfs setups at all.  Making the quota dep optional would avoid always pulling a package that is seldom used.
Comment 3 Mike Gilbert gentoo-dev 2020-01-13 02:31:17 UTC
I wonder if we should maybe just drop the #ifdef HAVE_RPCSVC_MOUNT_H section entirely, and just rely on the copy/pasted values below it.
Comment 4 Larry the Git Cow gentoo-dev 2020-01-13 16:56:33 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=800eb4146cfe655ca8962d7fb692bae138bdfeb1

commit 800eb4146cfe655ca8962d7fb692bae138bdfeb1
Author:     Mike Gilbert <floppym@gentoo.org>
AuthorDate: 2020-01-13 16:54:37 +0000
Commit:     Mike Gilbert <floppym@gentoo.org>
CommitDate: 2020-01-13 16:56:28 +0000

    net-nds/rpcbind: avoid using rpcsvc headers
    
    Closes: https://bugs.gentoo.org/705224
    Package-Manager: Portage-2.3.84_p2, Repoman-2.3.20_p24
    Signed-off-by: Mike Gilbert <floppym@gentoo.org>

 net-nds/rpcbind/rpcbind-1.2.5-r1.ebuild | 63 ---------------------------------
 net-nds/rpcbind/rpcbind-1.2.5.ebuild    |  7 +++-
 net-nds/rpcbind/rpcbind-9999.ebuild     | 10 +++---
 3 files changed, 10 insertions(+), 70 deletions(-)