Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 705008 - >=net-im/telegram-desktop-bin-1.9.2_beta - add optional spell checking support using app-text/enchant
Summary: >=net-im/telegram-desktop-bin-1.9.2_beta - add optional spell checking suppor...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Henning Schild
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2020-01-08 20:57 UTC by Gleb
Modified: 2020-01-13 06:10 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Gleb 2020-01-08 20:57:12 UTC
Starting with 1.9.3, Telegram optionally supports spell checking using enchant. However enchant is not in dependencies of telegram, so it would be good to have it.

Changelog:

1.9.3 (31.12.19)

- Videos in chats start playing automatically.
- Resume playback from where you left off when watching long videos and listening to long audio tracks.
- Control automatic playback for videos, GIFs and round video messages in Settings > Advanced > Automatic media download.
- Enjoy system spell checker support on all modern systems.

1.9.2 beta (29.12.19)

- Videos in chats start playing automatically.
- Resume playback from where you left off when watching long videos.
- Control videos, GIFs and round video messages automatic playback in Settings > Advanced > Automatic media download.
- Spell checker on Linux using Enchant.

Reproducible: Always
Comment 1 Henning Schild 2020-01-10 10:39:29 UTC
I read about that and kind of assumed it would be contained in the binary. If it depends on an external application that could be added as optional dep guarded by USE spell.

Did you happen to try it? Does it require any configuration or will is simply be enabled if enchant is available?
Comment 2 Henning Schild 2020-01-10 20:05:47 UTC
On my machine the spellchecker in the most recent version is available. It can be disabled in the advanced settings.

If you type something in a chat incorrect words should get underlined red.

It seems that all the code for that is part of the static binary, no external deps.

If you have a setup where spell checking does not work as expected please let me know. But i guess it is all part of the -bin package so nothing needs to be done.
Comment 3 Henning Schild 2020-01-10 20:13:32 UTC
I was wrong. It is indeed a library inside the binary that dynamically loads libenchant.

https://github.com/desktop-app/lib_spellcheck/blob/master/spellcheck/platform/linux/linux_enchant.cpp#L216
Comment 4 Henning Schild 2020-01-10 20:29:35 UTC
https://github.com/gentoo/gentoo/pull/14301
Comment 5 Larry the Git Cow gentoo-dev 2020-01-13 06:10:03 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6a2a9d960ac651801e6ce7f9b918769b6297a5c7

commit 6a2a9d960ac651801e6ce7f9b918769b6297a5c7
Author:     Henning Schild <henning@hennsch.de>
AuthorDate: 2020-01-10 20:26:42 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2020-01-13 06:09:44 +0000

    net-im/telegram-desktop-bin: Add spell checker optfeature
    
    Closes: https://bugs.gentoo.org/705008
    Signed-off-by: Henning Schild <henning@hennsch.de>
    Closes: https://github.com/gentoo/gentoo/pull/14301
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 .../telegram-desktop-bin-1.9.3-r1.ebuild           | 50 ++++++++++++++++++++++
 1 file changed, 50 insertions(+)