Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 704284 - Add additional systemd specific kernel config options for gentoo-sources
Summary: Add additional systemd specific kernel config options for gentoo-sources
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo Kernel Bug Wranglers and Kernel Maintainers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-12-30 15:30 UTC by Mike Pagano
Modified: 2019-12-31 14:12 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Pagano gentoo-dev 2019-12-30 15:30:36 UTC
systemd team,

while installed systemd I got the following:

ERROR: pretend
  CONFIG_FW_LOADER_USER_HELPER_FALLBACK:         should not be set. But it is.
    CONFIG_CGROUP_BPF:     is not set when it should be.
    WARN: pretend
    Please check to make sure these options are set correctly.
    Failure to do so may cause unexpected problems


I'd like to add 'default n' for FW_LOADER_USER_HELPER_FALLBACK and select CONFIG_CGROUP_BPF into the gentoo-sources patches for :

config GENTOO_LINUX_INIT_SYSTEMD

Just looking for a head nod here before I proceed.

Mike
Comment 1 Mike Gilbert gentoo-dev 2019-12-30 17:26:21 UTC
(In reply to Mike Pagano from comment #0)
> I'd like to add 'default n' for FW_LOADER_USER_HELPER_FALLBACK

I think this already defaults to "n" except on arm, arm64, and m68k where it is defaulted to 'y' via arch-specific default configs.

Would this have some useful effect that I'm overlooking?

> and select CONFIG_CGROUP_BPF

No objection.
Comment 2 Mike Pagano gentoo-dev 2019-12-30 18:36:23 UTC
(In reply to Mike Gilbert from comment #1)
> (In reply to Mike Pagano from comment #0)
> > I'd like to add 'default n' for FW_LOADER_USER_HELPER_FALLBACK
> 
> I think this already defaults to "n" except on arm, arm64, and m68k where it
> is defaulted to 'y' via arch-specific default configs.
> 
> Would this have some useful effect that I'm overlooking?
> 
> > and select CONFIG_CGROUP_BPF
> 
> No objection.

Thanks, Mike.

What I read is that systemd does not support FW_LOADER_USER_HELPER_FALLBACK.   
Maybe that's no longer the case?
Comment 3 Larry the Git Cow gentoo-dev 2019-12-30 22:24:43 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/linux-patches.git/commit/?id=e629f5c99b50167913b9ea2419ae949b4c9cac1d

commit e629f5c99b50167913b9ea2419ae949b4c9cac1d
Author:     Mike Pagano <mpagano@gentoo.org>
AuthorDate: 2019-12-30 22:21:15 +0000
Commit:     Mike Pagano <mpagano@gentoo.org>
CommitDate: 2019-12-30 22:21:15 +0000

    Add CONFIG selections for GENTOO_LINUX_INIT_SYSTEMD
    
    Adding CGROUP_BPF and it's dependency BPF_SYSCALL
    
    Bug: https://bugs.gentoo.org/704284
    
    Signed-off-by: Mike Pagano <mpagano@gentoo.org>

 4567_distro-Gentoo-Kconfig.patch | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)
Comment 4 Mike Gilbert gentoo-dev 2019-12-31 00:41:04 UTC
(In reply to Mike Pagano from comment #2)
> What I read is that systemd does not support FW_LOADER_USER_HELPER_FALLBACK.
> 
> Maybe that's no longer the case?

That's still the case.

My point is that putting "default n" in the gentoo-sources config has no effect: the option already defaults to "n" in the upstream sources.
Comment 5 Mike Pagano gentoo-dev 2019-12-31 14:05:01 UTC
(In reply to Mike Gilbert from comment #4)
> (In reply to Mike Pagano from comment #2)
> > What I read is that systemd does not support FW_LOADER_USER_HELPER_FALLBACK.
> > 
> > Maybe that's no longer the case?
> 
> That's still the case.
> 
> My point is that putting "default n" in the gentoo-sources config has no
> effect: the option already defaults to "n" in the upstream sources.

Ah thanks, I get your point now.

I hit this use case going from openrc to systemd using make oldconfig.
The FALLBACK was selected and hence I got the warning when I installed systemd.