Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 704096 - sci-mathematics/eclib: adopt new package from sage-on-gentoo
Summary: sci-mathematics/eclib: adopt new package from sage-on-gentoo
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Michael Orlitzky
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-12-28 16:19 UTC by Michael Orlitzky
Modified: 2019-12-30 14:35 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Orlitzky gentoo-dev 2019-12-28 16:19:03 UTC
(Same deal as with gp2c.)

Francois: the overlay ebuild is pulling the sources from the "sageupstream" mirror, but it looks like John started making releases on Github:

  https://github.com/JohnCremona/eclib/releases

Do you foresee any problems if I get the tarball from Github instead?

It also looks like autotools.eclass and RESTRICT=mirror are no longer needed.
Comment 1 François Bissey 2019-12-28 19:27:12 UTC
The source from github are just a git tag. John doesn't provide a sdist produced by autoconf there.
So, if you pull the source from github, you have to add eautoconf in src_prepare. On John's website there is only ever sdist for one version of eclib. So, the sage mirror was the safest location for looking up several sdist versions.

The autotools.eclass is probably a remnant from earlier times indeed.
Comment 2 Larry the Git Cow gentoo-dev 2019-12-30 14:35:55 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=1a3933ff7eed77e5b91f3dc47cc1164316d09984

commit 1a3933ff7eed77e5b91f3dc47cc1164316d09984
Author:     Michael Orlitzky <mjo@gentoo.org>
AuthorDate: 2019-12-30 14:09:52 +0000
Commit:     Michael Orlitzky <mjo@gentoo.org>
CommitDate: 2019-12-30 14:33:59 +0000

    sci-mathematics/eclib: new package for rational elliptic curves.
    
    This commit imports eclib-20190909 from the sage-on-gentoo overlay
    where François Bissey has been maintaining it for use with SageMath.
    I've made a few changes on top of the overlay version:
    
      * Enabled the test suite (it passes for me).
      * Put the "--disable-allprogs" configure flag behind USE=minimal.
      * Put the "--with-boost" configure flag behind USE=boost.
      * Inlined the SRC_URI which was using a custom thirdpartymirror.
      * Dropped obsolete autotools.eclass and RESTRICT=mirror.
    
    The SageMath build system can detect eclib on the system now, so having
    this package installed will save users time when rebuilding SageMath.
    
    Closes: https://bugs.gentoo.org/704096
    Package-Manager: Portage-2.3.79, Repoman-2.3.16
    Signed-off-by: Michael Orlitzky <mjo@gentoo.org>

 sci-mathematics/eclib/Manifest              |  1 +
 sci-mathematics/eclib/eclib-20190909.ebuild | 37 +++++++++++++++++++++++++++
 sci-mathematics/eclib/metadata.xml          | 39 +++++++++++++++++++++++++++++
 3 files changed, 77 insertions(+)