Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 704068 - =net-wireless/wireless-tools-30_pre9 lacks 'default' statement in src_prepare()
Summary: =net-wireless/wireless-tools-30_pre9 lacks 'default' statement in src_prepare()
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: AMD64 Linux
: Normal normal (vote)
Assignee: Rick Farina (Zero_Chaos)
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2019-12-28 09:06 UTC by Adrian Bassett
Modified: 2020-03-22 08:48 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
wireless-tools-30_pre9 EAPI=7 patch (wireless-tools-30_pre9.patch,455 bytes, patch)
2019-12-28 09:08 UTC, Adrian Bassett
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adrian Bassett 2019-12-28 09:06:55 UTC
With the move from EAPI=4 to EAPI=7 =net-wireless/wireless-tools-30_pre9 fails to emerge:

* ERROR: net-wireless/wireless-tools-30_pre9::gentoo failed (prepare phase):
*   eapply_user (or default) must be called in src_prepare()!

Adding a 'default' entry to the src_prepare function fixes things.

Reproducible: Always
Comment 1 Adrian Bassett 2019-12-28 09:08:07 UTC
Created attachment 601512 [details, diff]
wireless-tools-30_pre9 EAPI=7 patch

Trivial patch
Comment 2 Adrian Bassett 2019-12-28 09:57:35 UTC
(In reply to Adrian Bassett from comment #0)
> With the move from EAPI=4 to EAPI=7 =net-wireless/wireless-tools-30_pre9
> fails to emerge:
> 
> * ERROR: net-wireless/wireless-tools-30_pre9::gentoo failed (prepare phase):
> *   eapply_user (or default) must be called in src_prepare()!
> 
> Adding a 'default' entry to the src_prepare function fixes things.
> 
> Reproducible: Always

So, I did a bit more digging and found as a result of a 'git checkout' of the ebuild from the portage tree that EAPI is now set to 4.

I don't know where the EAPI=7 came from which caused the problem.  (I haven't edited the ebuild locally and, indeed, only looked at it when it failed as part of a general re-building of packages that hadn't been emerged with gcc-9.x).  Curious.
Comment 3 Larry the Git Cow gentoo-dev 2020-03-22 08:48:43 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=04704f9d6dc577876b5fcafd39bf7a0150b3372c

commit 04704f9d6dc577876b5fcafd39bf7a0150b3372c
Author:     Sergei Trofimovich <slyfox@gentoo.org>
AuthorDate: 2020-03-22 08:48:22 +0000
Commit:     Sergei Trofimovich <slyfox@gentoo.org>
CommitDate: 2020-03-22 08:48:37 +0000

    net-wireless/wireless-tools: update to EAPI=7
    
    Reported-by: Adrian Bassett
    Closes: https://bugs.gentoo.org/704068
    Package-Manager: Portage-2.3.94, Repoman-2.3.21
    Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>

 .../wireless-tools-30_pre9-r1.ebuild               | 63 ++++++++++++++++++++++
 1 file changed, 63 insertions(+)