Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 702950 - x11-libs/gdk-pixbuf-2.40.0 overwrites its own DEPEND assignment
Summary: x11-libs/gdk-pixbuf-2.40.0 overwrites its own DEPEND assignment
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo Linux Gnome Desktop Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-12-14 23:30 UTC by William Throwe
Modified: 2020-03-02 20:23 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description William Throwe 2019-12-14 23:30:17 UTC
The ebuild sets its dependencies as

DEPEND="stuff"
RDEPEND="${DEPEND} other stuff"
DEPEND="third stuff"

It looks like the second assignment to DEPEND should include the old value:

DEPEND="${DEPEND} third stuff"

This will make the behavior match what was done before a refactoring for version 2.38.2:

COMMON_DEPEND="stuff"
DEPEND="${COMMON_DEPEND} third stuff"
RDEPEND="${COMMON_DEPEND} other stuff"
Comment 1 Larry the Git Cow gentoo-dev 2020-03-02 20:23:49 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f0e85d8770c32a88fc8f648ca5a0a9a91ff76643

commit f0e85d8770c32a88fc8f648ca5a0a9a91ff76643
Author:     Mart Raudsepp <leio@gentoo.org>
AuthorDate: 2020-03-02 20:23:20 +0000
Commit:     Mart Raudsepp <leio@gentoo.org>
CommitDate: 2020-03-02 20:23:28 +0000

    x11-libs/gdk-pixbuf: fix DEPEND
    
    The bump was converted to EAPI-7 initially, so the second occurrence
    was a BDEPEND, but then it was realized that gnome-utils.eclass is
    broken for EAPI-7 gnome2_gdk_pixbuf_update calls and reverted back
    to EAPI-6 with a forgotten ${DEPEND} re-introduction when renaming
    BDEPEND back to DEPEND.
    No revbump, as due to the ordering, this meant that only build time
    deps were wrong, not runtime.
    
    Closes: https://bugs.gentoo.org/702950
    Package-Manager: Portage-2.3.84, Repoman-2.3.20
    Signed-off-by: Mart Raudsepp <leio@gentoo.org>

 x11-libs/gdk-pixbuf/gdk-pixbuf-2.40.0.ebuild | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)