Bug 702700 – sys-power/acpid : powerbtn.sh is unable to detect newer GNOME

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description nE0sIghT 2019-12-13 15:59:59 UTC]

Currently sys-power/acpid installs /etc/acpi/actions/powerbtn.sh script which tryes to detect runnng desktop environment and if no one found powers off PC.
However it tryes to detect GNOME Desktop by searching pid of gnome-power-manager process which is not exists in modern GNOME Desktop.
As a workaround it's possible to search gsd-power instead of gnome-power-manager.

Reproducible: Always

[Comment 1 Andriy Utkin (RETIRED) 2019-12-16 14:19:31 UTC]

Thanks, I will review this ASAP, possibly within a day.

[Comment 2 Andriy Utkin (RETIRED) 2019-12-17 14:03:26 UTC]

See my review in the PR: https://github.com/gentoo/gentoo/pull/13971#issuecomment-566552895

TLDR: please submit the fix upstream.

[Comment 3 Andriy Utkin (RETIRED) 2019-12-18 14:22:53 UTC]

Created attachment 600034 [details, diff]
patch for upstream

Sent this patch to upstream author.

Will apply upon acknowledgement from them.

[Comment 4 Larry the Git Cow 2019-12-19 23:20:41 UTC]

The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ada4786bededdff847e3b7b7391ab3d44a3e0e7e

commit ada4786bededdff847e3b7b7391ab3d44a3e0e7e
Author:     Andrey Utkin <[e-mail]>
AuthorDate: 2019-12-19 18:20:58 +0000
Commit:     Andrey Utkin <[e-mail]>
CommitDate: 2019-12-19 23:15:15 +0000

    sys-power/acpid: add a patch to recognise new GNOME power manager
    
    Has been ACKed by upstream maintainer.
    
    Bug: https://bugs.gentoo.org/702700
    Package-Manager: Portage-2.3.66, Repoman-2.3.16
    Signed-off-by: Andrey Utkin <[e-mail]>

 sys-power/acpid/Manifest               | 1 +
 sys-power/acpid/acpid-2.0.32-r1.ebuild | 3 ++-
 2 files changed, 3 insertions(+), 1 deletion(-)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=418d719af98ac717bcf3cf9e30d5af5758d0a23d

commit 418d719af98ac717bcf3cf9e30d5af5758d0a23d
Author:     Andrey Utkin <[e-mail]>
AuthorDate: 2019-12-19 17:52:20 +0000
Commit:     Andrey Utkin <[e-mail]>
CommitDate: 2019-12-19 23:15:12 +0000

    sys-power/acpid: add new revision 2.0.32-r1
    
    To be amended in next commit.
    This way the actual change is more clearly visible.
    
    Bug: https://bugs.gentoo.org/702700
    Package-Manager: Portage-2.3.66, Repoman-2.3.16
    Signed-off-by: Andrey Utkin <[e-mail]>

 sys-power/acpid/acpid-2.0.32-r1.ebuild | 70 ++++++++++++++++++++++++++++++++++
 1 file changed, 70 insertions(+)

[Comment 5 Andriy Utkin (RETIRED) 2019-12-19 23:35:23 UTC]

Thanks for your contribution!