Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 702384 - sys-apps/openrc-0.41.2 and sys-apps/openrc-0.42.1 fail [QA concerns: there are files installed outside the prefix] with USE=pam
Summary: sys-apps/openrc-0.41.2 and sys-apps/openrc-0.42.1 fail [QA concerns: there ar...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo/Alt
Classification: Unclassified
Component: Prefix Support (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo Prefix
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-12-09 20:05 UTC by Steven Trogdon
Modified: 2021-01-18 19:59 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Steven Trogdon 2019-12-09 20:05:54 UTC
With USE=-pam, there appears to be no problem. USE=pam did work at one time since I have the $EPREFIX/etc/pam.d folder with start-stop-daemon and supervise-daemon installed there.

The failures:

sys-apps/openrc-0.41.2

 * QA Notice: the following files are outside of the prefix:
 * /etc
 * /etc/pam.d
 * /etc/pam.d/start-stop-daemon
 * /etc/pam.d/supervise-daemon
 * ERROR: sys-apps/openrc-0.41.2::gentoo failed:
 *   Aborting due to QA concerns: there are files installed outside the prefix

sys-apps/openrc-0.42.1

 * QA Notice: the following files are outside of the prefix:
 * /etc
 * /etc/pam.d
 * /etc/pam.d/start-stop-daemon
 * /etc/pam.d/supervise-daemon
Comment 1 Steven Trogdon 2019-12-09 20:09:26 UTC
The more complete sys-apps/openrc-0.42.1 failure

* QA Notice: the following files are outside of the prefix:
 * /etc
 * /etc/pam.d
 * /etc/pam.d/start-stop-daemon
 * /etc/pam.d/supervise-daemon
 * ERROR: sys-apps/openrc-0.42.1::gentoo failed:
 *   Aborting due to QA concerns: there are files installed outside the prefix
Comment 2 Fabian Groffen gentoo-dev 2019-12-23 09:37:07 UTC
This is an issue with the build-system it seems, why do you want to install openrc?  Is it expected to work?
Comment 3 Steven Trogdon 2019-12-23 16:26:41 UTC
I can't see why openrc would be needed. However, at some point it was pulled into my prefix - way back in 2017. And appears in my world file. So something must have needed it. I don't think I would have just installed it.
Comment 4 William Hubbs gentoo-dev 2020-01-02 23:46:30 UTC
@grobian:
There was some experimentation by heroxbd with using openrc on prefix
installations, but I haven't heard anything from him for years, so I
don't know the status of it. I do know though that it was never picked
up by the prefix team, so if I don't hear anything more on this (or if
you tell me the prefix team isn't interested in OpenRC), I have no issue
with removing that experimental code.
Comment 5 Fabian Groffen gentoo-dev 2020-01-03 08:37:00 UTC
@williamh: there surely is the interest, but honestly no man-power, so if this is in your way somehow, feel free to drop it.  I don't want this to be a blocker or in any other way to obstruct OpenRC.

As for this bug, it seems /etc (SYSCONFDIR?) isn't produced in such a way that it includes the offset prefix.  It may be as simple as overriding it in the ebuild with the appropriate value, or changing how its value is generated in the Makefiles.  I haven't taken a look at this, but in general it seems like everything works, the pam bits just don't install in the right place.
Comment 6 William Hubbs gentoo-dev 2020-01-03 16:29:53 UTC
I'll keep it open through the next release at least and take a look
again. I'm looking at transitioning to a meson-based build, so let's see
what happens when I do that.

Also, FYI, if the *.pam file in ${FILESDIR} is getting installed outside the
prefix, it sounds like there might be a bug in the newpamd function.
Otherwise, I'm not sure where the bug is.
Comment 7 Benda Xu gentoo-dev 2020-01-26 09:14:38 UTC
Hi William and Fabian,

(In reply to William Hubbs from comment #4)
> @grobian:
> There was some experimentation by heroxbd with using openrc on prefix
> installations, but I haven't heard anything from him for years, so I
> don't know the status of it. I do know though that it was never picked
> up by the prefix team, so if I don't hear anything more on this (or if
> you tell me the prefix team isn't interested in OpenRC), I have no issue
> with removing that experimental code.

You have got a wrong impression on this.  OpenRC is supported on Prefix and it works since 2012.

The problem here is the only pam specific code in OpenRC.

Benda
Comment 8 Benda Xu gentoo-dev 2020-01-26 09:28:08 UTC
(In reply to Steven Trogdon from comment #0)
> With USE=-pam, there appears to be no problem. USE=pam did work at one time
> since I have the $EPREFIX/etc/pam.d folder with start-stop-daemon and
> supervise-daemon installed there.
> 
> The failures:
> 
> sys-apps/openrc-0.41.2
> 
>  * QA Notice: the following files are outside of the prefix:
>  * /etc
>  * /etc/pam.d
>  * /etc/pam.d/start-stop-daemon
>  * /etc/pam.d/supervise-daemon
>  * ERROR: sys-apps/openrc-0.41.2::gentoo failed:
>  *   Aborting due to QA concerns: there are files installed outside the
> prefix
> 
> sys-apps/openrc-0.42.1
> 
>  * QA Notice: the following files are outside of the prefix:
>  * /etc
>  * /etc/pam.d
>  * /etc/pam.d/start-stop-daemon
>  * /etc/pam.d/supervise-daemon

Hi, what is your output of `emerge -pv openrc`?
Comment 9 Steven Trogdon 2020-01-26 18:19:15 UTC
(In reply to Benda Xu from comment #8)
> (In reply to Steven Trogdon from comment #0)
> > With USE=-pam, there appears to be no problem. USE=pam did work at one time
> > since I have the $EPREFIX/etc/pam.d folder with start-stop-daemon and
> > supervise-daemon installed there.
> > 
> > The failures:
> > 
> > sys-apps/openrc-0.41.2
> > 
> >  * QA Notice: the following files are outside of the prefix:
> >  * /etc
> >  * /etc/pam.d
> >  * /etc/pam.d/start-stop-daemon
> >  * /etc/pam.d/supervise-daemon
> >  * ERROR: sys-apps/openrc-0.41.2::gentoo failed:
> >  *   Aborting due to QA concerns: there are files installed outside the
> > prefix
> > 
> > sys-apps/openrc-0.42.1
> > 
> >  * QA Notice: the following files are outside of the prefix:
> >  * /etc
> >  * /etc/pam.d
> >  * /etc/pam.d/start-stop-daemon
> >  * /etc/pam.d/supervise-daemon
> 
> Hi, what is your output of `emerge -pv openrc`?

My emerge -pv openrc.

[ebuild   R    ] sys-apps/openrc-0.42.1::gentoo  USE="ncurses netifrc (prefix) (split-usr) unicode -audit -bash -debug -newnet -pam (-selinux) -static-libs -sysv-utils" 0 KiB

USE=-pam to avoid the QA Notice.
Comment 10 Larry the Git Cow gentoo-dev 2021-01-18 19:59:29 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6bd8f7e30914b5b3c5d03be150299bb1b2780d42

commit 6bd8f7e30914b5b3c5d03be150299bb1b2780d42
Author:     Fabian Groffen <grobian@gentoo.org>
AuthorDate: 2021-01-18 19:58:36 +0000
Commit:     Fabian Groffen <grobian@gentoo.org>
CommitDate: 2021-01-18 19:58:36 +0000

    profiles/features/prefix/use.mask: mask USE=pam
    
    pam can't work in Prefix, mask it
    
    Closes: https://bugs.gentoo.org/702384
    Signed-off-by: Fabian Groffen <grobian@gentoo.org>

 profiles/features/prefix/use.mask | 3 +++
 1 file changed, 3 insertions(+)