Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 702330 - games-util/pyfa LICENSE discrepancy
Summary: games-util/pyfa LICENSE discrepancy
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Andreas Zuber
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: free-noncomm-license
  Show dependency tree
 
Reported: 2019-12-09 10:53 UTC by Ulrich Müller
Modified: 2019-12-09 15:30 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ulrich Müller gentoo-dev 2019-12-09 10:53:22 UTC
<=pyfa-1.35.1 has LICENSE="GPL-3+ LGPL-2.1+ CC-BY-2.5 free-noncomm", while
>=pyfa-1.37.0 has LICENSE="GPL-3+ all-rights-reserved"

I fail to see any significant difference between the two version, so these LICENSE strings cannot both be right?

README.md says:

## License
pyfa is licensed under the GNU GPL v3.0, see LICENSE

## CCP Copyright Notice
EVE Online, the EVE logo, EVE and all associated logos and designs are the intellectual property of CCP hf. All artwork, screenshots, characters, vehicles, storylines, world facts or other recognizable features of the intellectual property relating to these trademarks are likewise the intellectual property of CCP hf. EVE Online and the EVE logo are the registered trademarks of CCP hf. All rights are reserved worldwide. All other trademarks are the property of their respective owners. CCP hf. has granted permission to pyfa to use EVE Online and all associated logos and designs for promotional and information purposes on its website but does not endorse, and is not in any way affiliated with, pyfa. CCP is in no way responsible for the content on or functioning of this program, nor can it be liable for any damage arising from the use of this program.

This doesn't mention copyright, and it's not clear to me if "intellectual property" would imply copyright, or if it means only the trademarks. (But presumably we should err on the safe side and assume the former.)
Comment 1 Andreas Zuber 2019-12-09 13:32:37 UTC
This has already be discussed with upstream (https://github.com/pyfa-org/Pyfa/issues/1505) and in the corresponding PR (https://github.com/gentoo/gentoo/pull/7367#discussion_r186260729) it was recommended by you that "all-rights-reserved" should probably be sufficient.

The old versions <= 2.0 can be removed as they are no longer useful for anyone anyway. Should I create a PR for this?
Comment 2 Ulrich Müller gentoo-dev 2019-12-09 13:52:02 UTC
(In reply to Andreas Zuber from comment #1)
> This has already be discussed with upstream
> (https://github.com/pyfa-org/Pyfa/issues/1505) and in the corresponding PR
> (https://github.com/gentoo/gentoo/pull/7367#discussion_r186260729) it was
> recommended by you that "all-rights-reserved" should probably be sufficient.

Thanks for the pointer. I even participated in that discussion (but totally forgot about it). I am going to change the older versions to all-rights-reserved then, and add mirror restriction.

> The old versions <= 2.0 can be removed as they are no longer useful for
> anyone anyway. Should I create a PR for this?

AFAICS, the new version needs to be stabilised first, but I guess some of the old ebuilds could be removed immediately.
Comment 3 Larry the Git Cow gentoo-dev 2019-12-09 13:52:46 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=1076da205ff1b09c7afcb7152fc70fdf9e7f6253

commit 1076da205ff1b09c7afcb7152fc70fdf9e7f6253
Author:     Ulrich Müller <ulm@gentoo.org>
AuthorDate: 2019-12-09 13:49:33 +0000
Commit:     Ulrich Müller <ulm@gentoo.org>
CommitDate: 2019-12-09 13:52:12 +0000

    games-util/pyfa: Fix LICENSE in old versions.
    
    Should be "all-rights-reserved", not "free-noncomm". Also add mirror
    and bindist restriction, and move RESTRICT to its canonical location.
    
    Closes: https://bugs.gentoo.org/702330
    Package-Manager: Portage-2.3.81, Repoman-2.3.20
    Signed-off-by: Ulrich Müller <ulm@gentoo.org>

 games-util/pyfa/pyfa-1.34.0.ebuild | 5 +++--
 games-util/pyfa/pyfa-1.35.0.ebuild | 5 +++--
 games-util/pyfa/pyfa-1.35.1.ebuild | 5 +++--
 games-util/pyfa/pyfa-1.37.0.ebuild | 4 ++--
 games-util/pyfa/pyfa-2.14.1.ebuild | 2 +-
 games-util/pyfa/pyfa-9999.ebuild   | 2 +-
 6 files changed, 13 insertions(+), 10 deletions(-)