Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 702254 - sci-libs/lapack - add support for deprecated routines
Summary: sci-libs/lapack - add support for deprecated routines
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Science Related Packages
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2019-12-07 17:51 UTC by leoricupero
Modified: 2021-02-06 21:33 UTC (History)
6 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description leoricupero 2019-12-07 17:51:02 UTC
It would be great to have the possibility to build the deprecated routines, perhaps adding a dedicated use flag (see lapack-reference-3.7.0).
Thanks!
Comment 1 Benda Xu gentoo-dev 2019-12-09 10:49:37 UTC
Thanks for reporting.  We have dropped the deprecated USE flag from lapack 3.8.  It is time to consider it.
Comment 2 vince.ice 2020-02-17 19:53:41 UTC
Definitely time to allow deprecated routines: https://trac.openmodelica.org/OpenModelica/ticket/4886#comment:2
Comment 3 Benda Xu gentoo-dev 2020-02-18 02:42:21 UTC
(In reply to vince.ice from comment #2)
> Definitely time to allow deprecated routines:
> https://trac.openmodelica.org/OpenModelica/ticket/4886#comment:2

Thanks for voicing up.  Patches welcome.
Comment 4 vince.ice 2020-02-26 21:43:08 UTC
(In reply to Benda Xu from comment #3)
> (In reply to vince.ice from comment #2)
> > Definitely time to allow deprecated routines:
> > https://trac.openmodelica.org/OpenModelica/ticket/4886#comment:2
> 
> Thanks for voicing up.  Patches welcome.

here: https://github.com/gentoo/gentoo/pull/14783/commits/3bf31866008aaf8ea18786bfcf44b18392e4dd5c
Comment 5 Larry the Git Cow gentoo-dev 2020-03-08 04:35:26 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=09e858da1b3331b1ed8786235a3e3bdb9732956d

commit 09e858da1b3331b1ed8786235a3e3bdb9732956d
Author:     Alessandro Barbieri <lssndrbarbieri@gmail.com>
AuthorDate: 2020-02-29 10:49:33 +0000
Commit:     Benda Xu <heroxbd@gentoo.org>
CommitDate: 2020-03-08 04:34:46 +0000

    sci-libs/lapack: readd deprecated functions.
    
    Reported-By: leoricupero@gmail.com
    Closes: https://bugs.gentoo.org/702254
    Closes: https://github.com/gentoo/gentoo/pull/14803
    Package-Manager: Portage-2.3.89, Repoman-2.3.20
    Signed-off-by: Alessandro Barbieri <lssndrbarbieri@gmail.com>
    Signed-off-by: Benda Xu <heroxbd@gentoo.org>

 sci-libs/lapack/lapack-3.8.0-r1.ebuild | 92 ++++++++++++++++++++++++++++++++++
 sci-libs/lapack/metadata.xml           |  1 +
 2 files changed, 93 insertions(+)
Comment 6 Fabio Rossi 2021-01-18 08:54:10 UTC
Reopening this because still to be solved with 3.9.0.

Looking to the logs, on 8 March 2020, there was the commit for adding the deprecated useflag to 3.8.0

https://gitweb.gentoo.org/repo/gentoo.git/commit/sci-libs/lapack?id=09e858da1b3331b1ed8786235a3e3bdb9732956d

but later on 18 Sep 2020

https://gitweb.gentoo.org/repo/gentoo.git/commit/sci-libs/lapack?id=1a9d2a5e0166770db4aefdd7f688e332a32f858a

the version bump to 3.9.0 lost the new useflag :-(
Comment 7 Alessandro Barbieri 2021-01-18 10:07:26 UTC
3.9.0 doesn't have the headers for the deprecated routines. The headers are were readded upstream and now we have to wait for the next release or patch it
Comment 8 Fabio Rossi 2021-01-18 10:32:46 UTC
The patch to add should be this

https://github.com/svillemot/lapack/commit/87536aa3c8bb0af00f66088fb6ac05d87509e011

As the lapack releases are not so frequent, can the patch be backported to 3.9.0 in the meantime?
Comment 9 Fabio Rossi 2021-01-18 10:43:48 UTC
I can prepare a PR if you are available to add to portage
Comment 10 Fabio Rossi 2021-01-18 10:52:19 UTC
here it is

https://github.com/gentoo/gentoo/pull/19102
Comment 11 Larry the Git Cow gentoo-dev 2021-02-06 21:29:11 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=681412c77f8c1d58962f8159eb0cd0f648888d70

commit 681412c77f8c1d58962f8159eb0cd0f648888d70
Author:     efferre79 <rossi.f@inwind.it>
AuthorDate: 2021-01-18 10:48:46 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2021-02-06 21:29:06 +0000

    sci-libs/lapack: add deprecated functions also to 3.9.0
    
    Closes: https://bugs.gentoo.org/702254
    Signed-off-by: efferre79 <rossi.f@inwind.it>
    Signed-off-by: Sam James <sam@gentoo.org>

 .../files/lapack-3.9.0-deprecated-headers.patch    | 138 +++++++++++++++++++++
 sci-libs/lapack/lapack-3.8.0-r1.ebuild             |   4 +-
 sci-libs/lapack/lapack-3.8.0.ebuild                |   4 +-
 sci-libs/lapack/lapack-3.9.0-r1.ebuild             | 103 +++++++++++++++
 sci-libs/lapack/lapack-3.9.0.ebuild                |   2 +-
 5 files changed, 246 insertions(+), 5 deletions(-)

Additionally, it has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e299f36c470e4cdf7b2a97f8a9308da01aa80aa1

commit e299f36c470e4cdf7b2a97f8a9308da01aa80aa1
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2021-02-06 21:21:49 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2021-02-06 21:29:07 +0000

    sci-libs/lapack: cleanup old, patch metadata
    
    Bug: https://bugs.gentoo.org/702254
    Package-Manager: Portage-3.0.14, Repoman-3.0.2
    Signed-off-by: Sam James <sam@gentoo.org>

 .../files/lapack-3.9.0-deprecated-headers.patch    |  3 +
 sci-libs/lapack/lapack-3.9.0.ebuild                | 96 ----------------------
 2 files changed, 3 insertions(+), 96 deletions(-)
Comment 12 Larry the Git Cow gentoo-dev 2021-02-06 21:33:51 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=2279b9fe56f9ed156e11e6a65d6c4cfa803c78e0

commit 2279b9fe56f9ed156e11e6a65d6c4cfa803c78e0
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2021-02-06 21:31:38 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2021-02-06 21:31:42 +0000

    sci-libs/lapack: minor style change
    
    ${P} (for me at least) implies the patch is upstreamed,
    which it is.
    
    Bug: https://bugs.gentoo.org/702254
    Package-Manager: Portage-3.0.14, Repoman-3.0.2
    Signed-off-by: Sam James <sam@gentoo.org>

 sci-libs/lapack/lapack-3.9.0-r1.ebuild | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)