Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 70163 - speedfreq needs some love
Summary: speedfreq needs some love
Status: RESOLVED UPSTREAM
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Core system (show other bugs)
Hardware: All All
: High normal (vote)
Assignee: Mobile Herd (OBSOLETE)
URL:
Whiteboard:
Keywords:
: 63171 64042 (view as bug list)
Depends on: 76516
Blocks: 56593 75989
  Show dependency tree
 
Reported: 2004-11-05 06:55 UTC by Dennis Nienhüser (RETIRED)
Modified: 2005-05-07 10:44 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
speedfreq-0.7.2-r3.ebuild.diff (speedfreq-0.7.2-r3.ebuild.diff,1.99 KB, patch)
2004-11-05 06:57 UTC, Dennis Nienhüser (RETIRED)
Details | Diff
files/speedfreq.conf.diff (speedfreq.conf.diff,1.22 KB, patch)
2004-11-05 07:00 UTC, Dennis Nienhüser (RETIRED)
Details | Diff
files/speedfreq.rc (speedfreq.rc,1.22 KB, text/plain)
2004-11-05 07:00 UTC, Dennis Nienhüser (RETIRED)
Details
files/speedfreq.rc (speedfreq.rc,1.22 KB, text/plain)
2004-11-05 07:05 UTC, Dennis Nienhüser (RETIRED)
Details
files/speedfreq_battery (speedfreq_battery,52 bytes, text/plain)
2004-12-15 14:06 UTC, Dennis Nienhüser (RETIRED)
Details
speedfreq-0.7.2-r3.ebuild.diff (speedfreq-0.7.2-r3.ebuild.diff,1.56 KB, patch)
2004-12-19 14:26 UTC, Dennis Nienhüser (RETIRED)
Details | Diff
files/speedfreq.conf.diff (speedfreq.conf.diff,1.40 KB, patch)
2004-12-19 14:26 UTC, Dennis Nienhüser (RETIRED)
Details | Diff
files/speedfreq.rc (speedfreq.rc,1.48 KB, text/plain)
2004-12-19 14:27 UTC, Dennis Nienhüser (RETIRED)
Details
speedfreq-0.7.2-r3.ebuild.diff (speedfreq-0.7.2-r3.ebuild.diff,1.67 KB, patch)
2005-01-02 05:56 UTC, Dennis Nienhüser (RETIRED)
Details | Diff
files/speedfreq.rc (speedfreq.rc,1.16 KB, text/plain)
2005-01-03 08:33 UTC, Dennis Nienhüser (RETIRED)
Details
speedfreq-0.7.2-r3.ebuild.diff (speedfreq-0.7.2-r3.ebuild.diff,1.82 KB, patch)
2005-01-03 08:34 UTC, Dennis Nienhüser (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dennis Nienhüser (RETIRED) gentoo-dev 2004-11-05 06:55:46 UTC
Currently there are 5 open bugreports about speedfreq. Here is a sixth one that brings them all together. Short explanation of what I changed:

o Merged /etc/acpi/battery.sh into /etc/init.d/speedfreq to avoid code doubling and user confusion (see bug #66670). Also replaced checks for BAT0, BAT1 with checks for AC0, AC1 to avoid problems with more than one battery (resolving bug #56593, bug #52616). The init script partly fixes bug #60067 - it's now possible to define different policies depending on the ac state, but I didn't add the call of a user defined script, don't think it's a good idea to do that.
o added runtime dependency for virtual/logger fixing bug #63171)
o added frequency adaption to current system state before exiting (bug #64042)
Comment 1 Dennis Nienhüser (RETIRED) gentoo-dev 2004-11-05 06:57:31 UTC
Created attachment 43339 [details, diff]
speedfreq-0.7.2-r3.ebuild.diff

diff to speedfreq-0.7.2-r2
Comment 2 Dennis Nienhüser (RETIRED) gentoo-dev 2004-11-05 07:00:03 UTC
Created attachment 43340 [details, diff]
files/speedfreq.conf.diff

split up SPEEDFREQ_SPEED into SPEEDFREQ_SPEED_{AC,BATTERY}
Comment 3 Dennis Nienhüser (RETIRED) gentoo-dev 2004-11-05 07:00:41 UTC
Created attachment 43341 [details]
files/speedfreq.rc

too many changes for a diff
Comment 4 Dennis Nienhüser (RETIRED) gentoo-dev 2004-11-05 07:05:36 UTC
Created attachment 43343 [details]
files/speedfreq.rc

forgot to remove the debug function
Comment 5 Dennis Nienhüser (RETIRED) gentoo-dev 2004-11-29 15:38:51 UTC
bump
Comment 6 Dennis Nienhüser (RETIRED) gentoo-dev 2004-12-15 14:06:18 UTC
Created attachment 46077 [details]
files/speedfreq_battery

forgot that one...
Comment 7 Dennis Nienhüser (RETIRED) gentoo-dev 2004-12-19 14:26:11 UTC
Created attachment 46367 [details, diff]
speedfreq-0.7.2-r3.ebuild.diff

- Instead of using a hidden file in /etc/acpi/events and symlinks, make
disabling acpid calls a config option (thanks to genstef for the idea)
- re-adding keywords
Comment 8 Dennis Nienhüser (RETIRED) gentoo-dev 2004-12-19 14:26:47 UTC
Created attachment 46368 [details, diff]
files/speedfreq.conf.diff
Comment 9 Dennis Nienhüser (RETIRED) gentoo-dev 2004-12-19 14:27:16 UTC
Created attachment 46370 [details]
files/speedfreq.rc
Comment 10 Dennis Nienhüser (RETIRED) gentoo-dev 2005-01-02 05:56:38 UTC
Created attachment 47371 [details, diff]
speedfreq-0.7.2-r3.ebuild.diff

bugfix, doexe instead of newexe
Comment 11 Dennis Nienhüser (RETIRED) gentoo-dev 2005-01-02 06:44:40 UTC
*** Bug 63171 has been marked as a duplicate of this bug. ***
Comment 12 Dennis Nienhüser (RETIRED) gentoo-dev 2005-01-02 06:46:58 UTC
*** Bug 64042 has been marked as a duplicate of this bug. ***
Comment 13 Tim Cera 2005-01-02 19:42:22 UTC
I haven't implemented this yet, but just looking I noticed that 
ac_file wouldn't find my AC adapter.

bash-2.05b# cat /proc/acpi/ac_adapter/ACAD/state
state:                   on-line

thanks
Comment 14 Dennis Nienhüser (RETIRED) gentoo-dev 2005-01-03 08:33:04 UTC
Created attachment 47488 [details]
files/speedfreq.rc
Comment 15 Dennis Nienhüser (RETIRED) gentoo-dev 2005-01-03 08:34:26 UTC
Created attachment 47490 [details, diff]
speedfreq-0.7.2-r3.ebuild.diff

New dependency powermgmt-base
Comment 16 Dennis Nienhüser (RETIRED) gentoo-dev 2005-01-03 08:38:45 UTC
Thanks for the input Tim. Thinking about the ac_adapter/* issue, I found a nice debian package powermgmt-base that does not only check every ac_adapter/*/state, but also respects apm, pmu and multiple AC/batteries. See bug #76516 for details. Ebuild and init script are updated accordingly, please test.
Comment 17 Henrik Brix Andersen 2005-05-07 10:44:12 UTC
sys-power/speedfreq is deprecated in favor of sys-power/cpufreqd due to unresolved bugs and lack of upstream activity.

If you would like to see this fixed, please contact upstream.