Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 701276 - git-r3.eclass: drops into interactive input when repository is unavailable
Summary: git-r3.eclass: drops into interactive input when repository is unavailable
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Eclasses (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Michał Górny
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-11-26 20:24 UTC by Sergei Trofimovich (RETIRED)
Modified: 2019-12-07 14:36 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
0001-git-r3.eclass-Explicitly-disable-password-prompts.patch (0001-git-r3.eclass-Explicitly-disable-password-prompts.patch,947 bytes, patch)
2019-11-28 13:34 UTC, Michał Górny
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sergei Trofimovich (RETIRED) gentoo-dev 2019-11-26 20:24:14 UTC
https://bugs.gentoo.org/701272 is an example where ebuild refers to non-existing repository.

tcomment-9999.ebuild does not have PROPERTIES=interactive set instead of failing emerge just hangs on user input. I consider it a git-r3.eclass deficiency.

# USE=-test FEATURES=-test ACCEPT_KEYWORDS='**' emerge -v1 =app-vim/tcomment-9999

These are the packages that would be merged, in order:

Calculating dependencies... done!
[ebuild  N     ] app-vim/tcomment-9999::gentoo  0 KiB

Total: 1 package (1 new), Size of downloads: 0 KiB


>>> Verifying ebuild manifests

>>> Emerging (1 of 1) app-vim/tcomment-9999::gentoo
>>> Unpacking source...
 * Repository id: tomtom_nerdtree.git
 * To override fetched repository properties, use:
 *   EGIT_OVERRIDE_REPO_TOMTOM_NERDTREE
 *   EGIT_OVERRIDE_BRANCH_TOMTOM_NERDTREE
 *   EGIT_OVERRIDE_COMMIT_TOMTOM_NERDTREE
 *   EGIT_OVERRIDE_COMMIT_DATE_TOMTOM_NERDTREE
 *
 * Fetching https://github.com/tomtom/nerdtree.git ...
git fetch https://github.com/tomtom/nerdtree.git +HEAD:refs/git-r3/HEAD
Username for 'https://github.com':
Comment 1 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2019-11-28 13:34:50 UTC
Created attachment 597664 [details, diff]
0001-git-r3.eclass-Explicitly-disable-password-prompts.patch

Please test the attached patch.
Comment 2 Sergei Trofimovich (RETIRED) gentoo-dev 2019-11-28 19:55:19 UTC
Looks good:

# USE=-test FEATURES=-test ACCEPT_KEYWORDS='**' emerge -v1 =app-vim/tcomment-9999

These are the packages that would be merged, in order:

Calculating dependencies... done!
[ebuild  N     ] app-vim/tcomment-9999::gentoo  0 KiB

Total: 1 package (1 new), Size of downloads: 0 KiB


>>> Verifying ebuild manifests

>>> Emerging (1 of 1) app-vim/tcomment-9999::gentoo
>>> Unpacking source...
 * Repository id: tomtom_nerdtree.git
 * To override fetched repository properties, use:
 *   EGIT_OVERRIDE_REPO_TOMTOM_NERDTREE
 *   EGIT_OVERRIDE_BRANCH_TOMTOM_NERDTREE
 *   EGIT_OVERRIDE_COMMIT_TOMTOM_NERDTREE
 *   EGIT_OVERRIDE_COMMIT_DATE_TOMTOM_NERDTREE
 *
 * Fetching https://github.com/tomtom/nerdtree.git ...
git fetch https://github.com/tomtom/nerdtree.git +HEAD:refs/git-r3/HEAD
fatal: could not read Username for 'https://github.com': terminal prompts disabled
 * ERROR: app-vim/tcomment-9999::gentoo failed (unpack phase):
 *   Unable to fetch from any of EGIT_REPO_URI
 *
 * Call stack:
 *     ebuild.sh, line  125:  Called src_unpack
...
Comment 3 Larry the Git Cow gentoo-dev 2019-12-07 14:36:52 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f981af79945e28a40dab2b5196329f7835afe78b

commit f981af79945e28a40dab2b5196329f7835afe78b
Author:     Michał Górny <mgorny@gentoo.org>
AuthorDate: 2019-11-28 13:33:36 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2019-12-07 14:36:24 +0000

    git-r3.eclass: Explicitly disable password prompts
    
    Closes: https://bugs.gentoo.org/701276
    Signed-off-by: Michał Górny <mgorny@gentoo.org>

 eclass/git-r3.eclass | 3 +++
 1 file changed, 3 insertions(+)