Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 701154 - app-emulation/virtualbox-modules-6.0.14 with linux kernel 5.4 - ./include/linux/compiler_attributes.h:200:41: error: expected ')' before '__attribute__'
Summary: app-emulation/virtualbox-modules-6.0.14 with linux kernel 5.4 - ./include/lin...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Lars Wendler (Polynomial-C) (RETIRED)
URL:
Whiteboard: Use app-emulation/virtualbox-modules-...
Keywords: InOverlay
Depends on:
Blocks:
 
Reported: 2019-11-25 16:23 UTC by tka
Modified: 2019-11-27 15:42 UTC (History)
8 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,62.96 KB, text/plain)
2019-11-25 16:24 UTC, tka
Details
patch to compile with kernel 5.4.0 (virtualbox-modules-6.0.14-kernel54.patch,3.92 KB, patch)
2019-11-26 19:02 UTC, Helmut Jarausch
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description tka 2019-11-25 16:23:39 UTC
app-emulation/virtualbox-modules-6.0.14 does not compile with a vanilla kernel 5.4 (from kernel.org). Something changed with resprect to __attribute__((__fallthrough__)):

  x86_64-pc-linux-gnu-gcc -Wp,-MD,/var/tmp/portage/app-emulation/virtualbox-modules-6.0.14/work/vboxdrv/r0drv/.initterm-r0drv.o.d  -nostdinc -isystem /usr/lib/gcc/x86_64-pc-linux-gnu/9.2.0/include -I./arch/x86/include -I./arch/x86/include/generated  -I./include -I./arch/x86/include/uapi -I./arch/x86/include/generated/uapi -I./include/uapi -I./include/generated/uapi -include ./include/linux/kconfig.h -include ./include/linux/compiler_types.h -D__KERNEL__ -Wall -Wundef -Werror=strict-prototypes -Wno-trigraphs -fno-strict-aliasing -fno-common -fshort-wchar -fno-PIE -Werror=implicit-function-declaration -Werror=implicit-int -Wno-format-security -std=gnu89 -mno-sse -mno-mmx -mno-sse2 -mno-3dnow -mno-avx -m64 -falign-jumps=1 -falign-loops=1 -mno-80387 -mno-fp-ret-in-387 -mpreferred-stack-boundary=3 -mskip-rax-setup -march=core2 -mno-red-zone -mcmodel=kernel -DCONFIG_AS_CFI=1 -DCONFIG_AS_CFI_SIGNAL_FRAME=1 -DCONFIG_AS_CFI_SECTIONS=1 -DCONFIG_AS_SSSE3=1 -DCONFIG_AS_AVX=1 -DCONFIG_AS_AVX2=1 -DCONFIG_AS_AVX512=1 -DCONFIG_AS_SHA1_NI=1 -DCONFIG_AS_SHA256_NI=1 -Wno-sign-compare -fno-asynchronous-unwind-tables -mindirect-branch=thunk-extern -mindirect-branch-register -fno-jump-tables -fno-delete-null-pointer-checks -Wno-frame-address -Wno-format-truncation -Wno-format-overflow -Wno-address-of-packed-member -O2 --param=allow-store-data-races=0 -fplugin=./scripts/gcc-plugins/structleak_plugin.so -fplugin=./scripts/gcc-plugins/randomize_layout_plugin.so -fplugin=./scripts/gcc-plugins/stackleak_plugin.so -DSTRUCTLEAK_PLUGIN -DRANDSTRUCT_PLUGIN -DSTACKLEAK_PLUGIN -fplugin-arg-stackleak_plugin-track-min-size=100 -Wframe-larger-than=2048 -fstack-protector-strong -Wno-unused-but-set-variable -Wimplicit-fallthrough -Wno-unused-const-variable -fomit-frame-pointer -fno-var-tracking-assignments -Wdeclaration-after-statement -Wvla -Wno-pointer-sign -Wno-stringop-truncation -fno-strict-overflow -fno-merge-all-constants -fmerge-constants -fno-stack-check -fconserve-stack -Werror=date-time -Werror=incompatible-pointer-types -Werror=designated-init -fmacro-prefix-map=./= -fcf-protection=none -Wno-packed-not-aligned -include /var/tmp/portage/app-emulation/virtualbox-modules-6.0.14/work/vboxdrv/include/VBox/SUPDrvMangling.h -fno-omit-frame-pointer -fno-pie -Wno-declaration-after-statement -I./include -I/var/tmp/portage/app-emulation/virtualbox-modules-6.0.14/work/vboxdrv/ -I/var/tmp/portage/app-emulation/virtualbox-modules-6.0.14/work/vboxdrv/include -I/var/tmp/portage/app-emulation/virtualbox-modules-6.0.14/work/vboxdrv/r0drv/linux -D__KERNEL__ -DMODULE -DRT_WITHOUT_PRAGMA_ONCE -DRT_OS_LINUX -DIN_RING0 -DIN_RT_R0 -DIN_SUP_R0 -DVBOX -DRT_WITH_VBOX -DVBOX_WITH_HARDENING -DSUPDRV_WITH_RELEASE_LOGGER -DVBOX_WITH_64_BITS_GUESTS -DCONFIG_VBOXDRV_AS_MISC -DRT_ARCH_AMD64  -DMODULE  -DKBUILD_BASENAME='"initterm_r0drv"' -DKBUILD_MODNAME='"vboxdrv"' -c -o /var/tmp/portage/app-emulation/virtualbox-modules-6.0.14/work/vboxdrv/r0drv/initterm-r0drv.o /var/tmp/portage/app-emulation/virtualbox-modules-6.0.14/work/vboxdrv/r0drv/initterm-r0drv.c
In file included from ././include/linux/compiler_types.h:59,
                 from <command-line>:
/var/tmp/portage/app-emulation/virtualbox-modules-6.0.14/work/vboxdrv/SUPDrvGip.c: In function 'supdrvTscDeltaThread':
./include/linux/compiler_attributes.h:200:41: error: expected ')' before '__attribute__'
  200 | # define fallthrough                    __attribute__((__fallthrough__))
      |                                         ^~~~~~~~~~~~~
/var/tmp/portage/app-emulation/virtualbox-modules-6.0.14/work/vboxdrv/include/iprt/cdefs.h:1169:48: note: in expansion of macro 'fallthrough'
 1169 | # define RT_FALL_THROUGH()      __attribute__((fallthrough))
      |                                                ^~~~~~~~~~~
/var/tmp/portage/app-emulation/virtualbox-modules-6.0.14/work/vboxdrv/include/iprt/cdefs.h:1176:33: note: in expansion of macro 'RT_FALL_THROUGH'
 1176 | #define RT_FALL_THRU()          RT_FALL_THROUGH()
      |                                 ^~~~~~~~~~~~~~~
/var/tmp/portage/app-emulation/virtualbox-modules-6.0.14/work/vboxdrv/SUPDrvGip.c:4197:17: note: in expansion of macro 'RT_FALL_THRU'
 4197 |                 RT_FALL_THRU();
      |                 ^~~~~~~~~~~~
In file included from /var/tmp/portage/app-emulation/virtualbox-modules-6.0.14/work/vboxdrv/include/VBox/cdefs.h:32,
                 from /var/tmp/portage/app-emulation/virtualbox-modules-6.0.14/work/vboxdrv/SUPDrvInternal.h:37,
                 from /var/tmp/portage/app-emulation/virtualbox-modules-6.0.14/work/vboxdrv/SUPDrvGip.c:33:
/var/tmp/portage/app-emulation/virtualbox-modules-6.0.14/work/vboxdrv/include/iprt/cdefs.h:1169:60: error: expected identifier or '(' before ')' token
 1169 | # define RT_FALL_THROUGH()      __attribute__((fallthrough))
      |                                                            ^
/var/tmp/portage/app-emulation/virtualbox-modules-6.0.14/work/vboxdrv/include/iprt/cdefs.h:1176:33: note: in expansion of macro 'RT_FALL_THROUGH'
 1176 | #define RT_FALL_THRU()          RT_FALL_THROUGH()
      |                                 ^~~~~~~~~~~~~~~
/var/tmp/portage/app-emulation/virtualbox-modules-6.0.14/work/vboxdrv/SUPDrvGip.c:4197:17: note: in expansion of macro 'RT_FALL_THRU'
 4197 |                 RT_FALL_THRU();
      |                 ^~~~~~~~~~~~
In file included from ././include/linux/compiler_types.h:59,
                 from <command-line>:
./include/linux/compiler_attributes.h:200:41: error: expected ')' before '__attribute__'
  200 | # define fallthrough                    __attribute__((__fallthrough__))
      |                                         ^~~~~~~~~~~~~
/var/tmp/portage/app-emulation/virtualbox-modules-6.0.14/work/vboxdrv/include/iprt/cdefs.h:1169:48: note: in expansion of macro 'fallthrough'
 1169 | # define RT_FALL_THROUGH()      __attribute__((fallthrough))
      |                                                ^~~~~~~~~~~
/var/tmp/portage/app-emulation/virtualbox-modules-6.0.14/work/vboxdrv/include/iprt/cdefs.h:1176:33: note: in expansion of macro 'RT_FALL_THROUGH'
 1176 | #define RT_FALL_THRU()          RT_FALL_THROUGH()
      |                                 ^~~~~~~~~~~~~~~
/var/tmp/portage/app-emulation/virtualbox-modules-6.0.14/work/vboxdrv/SUPDrvGip.c:4226:17: note: in expansion of macro 'RT_FALL_THRU'
 4226 |                 RT_FALL_THRU();
      |                 ^~~~~~~~~~~~
In file included from /var/tmp/portage/app-emulation/virtualbox-modules-6.0.14/work/vboxdrv/include/VBox/cdefs.h:32,
                 from /var/tmp/portage/app-emulation/virtualbox-modules-6.0.14/work/vboxdrv/SUPDrvInternal.h:37,
                 from /var/tmp/portage/app-emulation/virtualbox-modules-6.0.14/work/vboxdrv/SUPDrvGip.c:33:
/var/tmp/portage/app-emulation/virtualbox-modules-6.0.14/work/vboxdrv/include/iprt/cdefs.h:1169:60: error: expected identifier or '(' before ')' token
 1169 | # define RT_FALL_THROUGH()      __attribute__((fallthrough))
      |                                                            ^
/var/tmp/portage/app-emulation/virtualbox-modules-6.0.14/work/vboxdrv/include/iprt/cdefs.h:1176:33: note: in expansion of macro 'RT_FALL_THROUGH'
 1176 | #define RT_FALL_THRU()          RT_FALL_THROUGH()
      |                                 ^~~~~~~~~~~~~~~
/var/tmp/portage/app-emulation/virtualbox-modules-6.0.14/work/vboxdrv/SUPDrvGip.c:4226:17: note: in expansion of macro 'RT_FALL_THRU'
 4226 |                 RT_FALL_THRU();
      |                 ^~~~~~~~~~~~
/var/tmp/portage/app-emulation/virtualbox-modules-6.0.14/work/vboxdrv/SUPDrvGip.c:4195:20: warning: this statement may fall through [-Wimplicit-fallthrough=]
 4195 |                 if (RT_FAILURE(rc))
      |                    ^
/var/tmp/portage/app-emulation/virtualbox-modules-6.0.14/work/vboxdrv/SUPDrvGip.c:4200:13: note: here
 4200 |             case kTscDeltaThreadState_Listening:
      |             ^~~~
In file included from <command-line>:
/var/tmp/portage/app-emulation/virtualbox-modules-6.0.14/work/vboxdrv/include/VBox/SUPDrvMangling.h:35:30: warning: this statement may fall through [-Wimplicit-fallthrough=]
   35 | #define RT_MANGLER(symbol)   VBoxHost_##symbol
/var/tmp/portage/app-emulation/virtualbox-modules-6.0.14/work/vboxdrv/include/iprt/mangling.h:2328:57: note: in expansion of macro 'RT_MANGLER'
 2328 | # define RTThreadSleep                                  RT_MANGLER(RTThreadSleep)
      |                                                         ^~~~~~~~~~
/var/tmp/portage/app-emulation/virtualbox-modules-6.0.14/work/vboxdrv/SUPDrvGip.c:4225:17: note: in expansion of macro 'RTThreadSleep'
 4225 |                 RTThreadSleep(1);
      |                 ^~~~~~~~~~~~~
/var/tmp/portage/app-emulation/virtualbox-modules-6.0.14/work/vboxdrv/SUPDrvGip.c:4229:13: note: here
 4229 |             case kTscDeltaThreadState_Measuring:
      |             ^~~~
make[3]: *** [scripts/Makefile.build:266: /var/tmp/portage/app-emulation/virtualbox-modules-6.0.14/work/vboxdrv/SUPDrvGip.o] Error 1
make[3]: *** Waiting for unfinished jobs....
[...snip...]
make[2]: *** [Makefile:1652: /var/tmp/portage/app-emulation/virtualbox-modules-6.0.14/work/vboxdrv] Error 2
make[2]: Leaving directory '/usr/src/linux-5.4'
make[1]: *** [/var/tmp/portage/app-emulation/virtualbox-modules-6.0.14/work/vboxdrv/Makefile-footer.gmk:111: vboxdrv] Error 2
make[1]: Leaving directory '/var/tmp/portage/app-emulation/virtualbox-modules-6.0.14/work/vboxdrv'
make: *** [Makefile:58: vboxdrv] Error 2
 * ERROR: app-emulation/virtualbox-modules-6.0.14::gentoo failed (compile phase):
 *   emake failed

This is with sources from kernel.org, but will likely also affect gentoo-sources-5.4 and vanilla-sources-5.4., which were added to the tree just moments ago.


Reproducible: Always

Steps to Reproduce:
1. Have sources for linux-5.4 under /usr/src/linux
2. Run emerge @module-rebuild [-> rebuild app-emulation/virtualbox-modules-6.0.14]
Comment 1 tka 2019-11-25 16:24:10 UTC
Created attachment 597510 [details]
build.log

# emerge -pqv '=app-emulation/virtualbox-modules-6.0.14::gentoo'
[ebuild   R   ] app-emulation/virtualbox-modules-6.0.14  USE="-pax_kernel" 


# emerge --info '=app-emulation/virtualbox-modules-6.0.14::gentoo'
Portage 2.3.79 (python 3.6.9-final-0, default/linux/amd64/17.1/no-multilib/hardened, gcc-9.2.0, glibc-2.30-r2, 5.3.13 x86_64)
=================================================================
                         System Settings
=================================================================
System uname: Linux-5.3.13-x86_64-Intel-R-_Core-TM-_i7-3720QM_CPU_@_2.60GHz-with-gentoo-2.6
KiB Mem:    16358724 total,   8947668 free
KiB Swap:   17825788 total,  17825788 free
Timestamp of repository gentoo: Mon, 25 Nov 2019 15:00:01 +0000
Head commit of repository gentoo: 2dc285227fe38d6e5ac8d6373894b6d6b019ab7a
sh bash 5.0_p11
ld GNU ld (Gentoo 2.33.1 p1) 2.33.1
app-shells/bash:          5.0_p11::gentoo
dev-java/java-config:     2.2.0-r4::gentoo
dev-lang/perl:            5.30.1::gentoo
dev-lang/python:          2.7.17::gentoo, 3.6.9::gentoo
dev-util/cmake:           3.15.5::gentoo
dev-util/pkgconfig:       0.29.2::gentoo
sys-apps/baselayout:      2.6-r1::gentoo
sys-apps/openrc:          0.42.1::gentoo
sys-apps/sandbox:         2.18::gentoo
sys-devel/autoconf:       2.13-r1::gentoo, 2.69-r4::gentoo
sys-devel/automake:       1.16.1-r2::gentoo
sys-devel/binutils:       2.33.1::gentoo
sys-devel/gcc:            9.2.0-r2::gentoo
sys-devel/gcc-config:     2.1::gentoo
sys-devel/libtool:        2.4.6-r5::gentoo
sys-devel/make:           4.2.1-r4::gentoo
sys-kernel/linux-headers: 5.3-r1::gentoo (virtual/os-headers)
sys-libs/glibc:           2.30-r2::gentoo
Repositories:

gentoo
    location: /usr/portage
    sync-type: rsync
    sync-uri: rsync://rsync.gentoo.org/gentoo-portage
    priority: -1000
    sync-rsync-extra-opts: 
    sync-rsync-verify-metamanifest: yes
    sync-rsync-verify-jobs: 1
    sync-rsync-verify-max-age: 24

local
    location: /var/lib/portage-local/local
    masters: gentoo
    priority: 0

testing
    location: /var/lib/portage-local/testing
    masters: gentoo
    priority: 1

ACCEPT_KEYWORDS="amd64 ~amd64"
ACCEPT_LICENSE="@FREE"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-march=native -mtune=native -O2 -pipe"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c"
CXXFLAGS="-march=native -mtune=native -O2 -pipe"
DISTDIR="/usr/portage/distfiles"
EMERGE_DEFAULT_OPTS="--with-bdeps=y"
ENV_UNSET="DBUS_SESSION_BUS_ADDRESS DISPLAY GOBIN PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR"
FCFLAGS="-O2 -pipe"
FEATURES="assume-digests binpkg-docompress binpkg-dostrip binpkg-logs cgroup collision-protect config-protect-if-modified distlocks ebuild-locks fixlafiles ipc-sandbox merge-sync multilib-strict network-sandbox news parallel-fetch pid-sandbox preserve-libs protect-owned sandbox sfperms strict test unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
FFLAGS="-O2 -pipe"
GENTOO_MIRRORS="http://distfiles.gentoo.org"
LDFLAGS="-Wl,-O1 -Wl,--as-needed -Wl,--hash-style=gnu"
LINGUAS=""
MAKEOPTS="-j8"
PKGDIR="/var/cache/binpkgs"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git"
PORTAGE_TMPDIR="/var/tmp"
USE="X a52 acl acpi alsa amd64 avx bzip2 cairo caps cdda cddb cdparanoia crypt cups cxx dbus dri dts dvd fam ffmpeg fftw flac fontconfig gif gimp gmp gnutls gtk hardened iconv icu idn ipv6 jpeg lame lcms libnotify libtirpc lzma mad matroska mmap mmx mmxext mp3 mpeg ncurses networkmanager nptl ogg opengl openmp pam pcre pie png policykit ppds readline sasl sdl seccomp split-usr sse sse2 sse3 sse4 sse4_1 sse4_2 ssl ssp ssse3 startup-notification svg test theora threads tiff truetype udev udisks unicode upower vaapi vorbis wayland x264 xattr xcb xinerama xml xtpax xv xvid zlib" ABI_X86="64" ADA_TARGET="gnat_2018" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="karbon sheets words" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="aes avx f16c mmx mmxext pclmul popcnt sse sse2 sse3 sse4_1 sse4_2 ssse3" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock greis isync itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 timing tsip tripmate tnt ublox ubx" GRUB_PLATFORMS="pc" INPUT_DEVICES="evdev synaptics" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" NETBEANS_MODULES="apisupport cnd groovy gsf harness ide identity j2ee java mobility nb php profiler soa visualweb webcommon websvccommon xml" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php7-2" POSTGRES_TARGETS="postgres10 postgres11" PYTHON_SINGLE_TARGET="python3_6" PYTHON_TARGETS="python2_7 python3_6" RUBY_TARGETS="ruby24 ruby25" USERLAND="GNU" VIDEO_CARDS="i965 intel nouveau" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CC, CPPFLAGS, CTARGET, CXX, INSTALL_MASK, LANG, LC_ALL, PORTAGE_BINHOST, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS

=================================================================
                        Package Settings
=================================================================

app-emulation/virtualbox-modules-6.0.14::gentoo was built with the following:
USE="-pax_kernel"
Comment 2 Ian Pickworth 2019-11-26 10:23:26 UTC
+1 on this failure on X64 kernel.

There is a virtualbox change set that appears to cover this:

https://www.virtualbox.org/changeset/81649/vbox

(related ticket:  https://www.virtualbox.org/ticket/18945 )

Just looking at the source in /var/tmp/portage/app-emulation/virtualbox-modules-6.0.14/work  after the failure and the "fallthrough" change is missing:

------------------------
ian2 /var/tmp/portage/app-emulation/virtualbox-modules-6.0.14/work # grep -R RT_FALL_THROUGH *
vboxdrv/include/iprt/cdefs.h:/** @def RT_FALL_THROUGH
vboxdrv/include/iprt/cdefs.h:# define RT_FALL_THROUGH()      __attribute__((fallthrough))
vboxdrv/include/iprt/cdefs.h:# define RT_FALL_THROUGH()      (void)0
vboxdrv/include/iprt/cdefs.h: * @sa RT_FALL_THROUGH */
vboxdrv/include/iprt/cdefs.h:#define RT_FALL_THRU()          RT_FALL_THROUGH()
vboxnetadp/include/iprt/cdefs.h:/** @def RT_FALL_THROUGH
vboxnetadp/include/iprt/cdefs.h:# define RT_FALL_THROUGH()      __attribute__((fallthrough))
vboxnetadp/include/iprt/cdefs.h:# define RT_FALL_THROUGH()      (void)0
vboxnetadp/include/iprt/cdefs.h: * @sa RT_FALL_THROUGH */
vboxnetadp/include/iprt/cdefs.h:#define RT_FALL_THRU()          RT_FALL_THROUGH()
vboxnetflt/include/iprt/cdefs.h:/** @def RT_FALL_THROUGH
vboxnetflt/include/iprt/cdefs.h:# define RT_FALL_THROUGH()      __attribute__((fallthrough))
vboxnetflt/include/iprt/cdefs.h:# define RT_FALL_THROUGH()      (void)0
vboxnetflt/include/iprt/cdefs.h: * @sa RT_FALL_THROUGH */
vboxnetflt/include/iprt/cdefs.h:#define RT_FALL_THRU()          RT_FALL_THROUGH()
vboxpci/include/iprt/cdefs.h:/** @def RT_FALL_THROUGH
vboxpci/include/iprt/cdefs.h:# define RT_FALL_THROUGH()      __attribute__((fallthrough))
vboxpci/include/iprt/cdefs.h:# define RT_FALL_THROUGH()      (void)0
vboxpci/include/iprt/cdefs.h: * @sa RT_FALL_THROUGH */
vboxpci/include/iprt/cdefs.h:#define RT_FALL_THRU()          RT_FALL_THROUGH()
ian2 /var/tmp/portage/app-emulation/virtualbox-modules-6.0.14/work # 
----------------------------

According to the change set this should have been change thus:

trunk/include/iprt/cdefs.h
r81549	r81649	 
1159	1159	 * @sa RT_FALL_THRU  */ 
1160	1160	#if RT_GNUC_PREREQ(7, 0) 
1161	 	# define RT_FALL_THROUGH()      __attribute__((fallthrough)) 
 	1161	# define RT_FALL_THROUGH()      __attribute__((__fallthrough__)) 
1162	1162	#else 
1163	1163	# define RT_FALL_THROUGH()      (void)0 


So that appears to be some evidence that a fix exists upstream for this.
Comment 3 Helmut Jarausch 2019-11-26 19:02:44 UTC
Created attachment 597564 [details, diff]
patch to compile with kernel 5.4.0

This patch works for me. A better solution would be to prepare a ebuild for the new 6.1 version of VirtualBox
Comment 4 Conrad Kostecki gentoo-dev 2019-11-26 21:05:26 UTC
Thanks, works for me :-)
Comment 5 Ian Pickworth 2019-11-27 10:00:09 UTC
I can confirm that app-emulation/virtualbox-modules-6.0.14 from poly-c overlay compiles OK for me against 5.4
Comment 6 Louis Sautier (sbraz) gentoo-dev 2019-11-27 10:20:38 UTC
Here's Arch's patch FWIW, they picked code from two more changesets:
https://git.archlinux.org/svntogit/community.git/plain/trunk/016-linux-5-4.patch?h=packages/virtualbox&id=9640ba42a7c30757e00d15409b6d718f15a85d92
Comment 7 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2019-11-27 12:13:39 UTC
(In reply to Louis Sautier (sbraz) from comment #6)
> Here's Arch's patch FWIW, they picked code from two more changesets:
> https://git.archlinux.org/svntogit/community.git/plain/trunk/016-linux-5-4.
> patch?h=packages/virtualbox&id=9640ba42a7c30757e00d15409b6d718f15a85d92

I got the pacht from my overlay approved by upstram yesterday. They said that one is sufficient for the VBox host but not for VBox guests.
Comment 8 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2019-11-27 12:13:49 UTC
*upstream
Comment 9 Larry the Git Cow gentoo-dev 2019-11-27 12:17:57 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=9e99aae326f9512cf08560abd4f784b15baee850

commit 9e99aae326f9512cf08560abd4f784b15baee850
Author:     Lars Wendler <polynomial-c@gentoo.org>
AuthorDate: 2019-11-27 12:17:12 +0000
Commit:     Lars Wendler <polynomial-c@gentoo.org>
CommitDate: 2019-11-27 12:17:12 +0000

    app-emulation/virtualbox-modules: Fixed build with kernel-5.4
    
    Closes: https://bugs.gentoo.org/701154
    Package-Manager: Portage-2.3.80, Repoman-2.3.18
    Signed-off-by: Lars Wendler <polynomial-c@gentoo.org>

 .../virtualbox-modules-6.0.14-kernel-5.4_rc6.patch | 308 +++++++++++++++++++++
 .../virtualbox-modules-6.0.14.ebuild               |   4 +
 2 files changed, 312 insertions(+)