Under jsoncpp-1.9.2-r1, lgogdownloader fails due change of specification, as mentioned in bug 700220 Attaching stack with the problem: -- <<< Gentoo configuration >>> Build type Gentoo Install path /usr Compiler flags: C -march=broadwell -O2 -pipe C++ -march=broadwell -O2 -pipe -std=c++11 -Wall -Wextra -Wno-long-long -fexceptions Linker flags: Executable -Wl,-O1 -Wl,--as-needed Module -Wl,-O1 -Wl,--as-needed Shared -Wl,-O1 -Wl,--as-needed CMake Error: The following variables are used in this project, but they are set to NOTFOUND. Please set them or make sure they are set and tested correctly in the CMake files: /var/tmp/portage/games-util/lgogdownloader-3.5/work/lgogdownloader-3.5/JSONCPP_INCLUDE_DIR used as include directory in directory /var/tmp/portage/games-util/lgogdownloader-3.5/work/lgogdownloader-3.5 -- Configuring incomplete, errors occurred! See also "/var/tmp/portage/games-util/lgogdownloader-3.5/work/lgogdownloader-3.5_build/CMakeFiles/CMakeOutput.log". See also "/var/tmp/portage/games-util/lgogdownloader-3.5/work/lgogdownloader-3.5_build/CMakeFiles/CMakeError.log". * ERROR: games-util/lgogdownloader-3.5::gentoo failed (configure phase): * cmake failed * * Call stack: * ebuild.sh, line 125: Called src_configure * environment, line 2042: Called cmake-utils_src_configure * environment, line 889: Called die * The specific snippet of code: * "${CMAKE_BINARY}" "${cmakeargs[@]}" "${CMAKE_USE_DIR}" || die "cmake failed"; Reproducible: Always Steps to Reproduce: 1.Compile jsoncpp-1.9.2-r1 2.Compile lgogdownloader 3.Observe it fails Actual Results: Compilation fails Expected Results: Compilation works Attaching patch to fix.
Created attachment 596610 [details, diff] jsoncpp patch Patch to fix compilation fails due jsoncpp old pattern
(In reply to Pablo Cholaky from comment #1) > Created attachment 596610 [details, diff] [details, diff] > jsoncpp patch > > Patch to fix compilation fails due jsoncpp old pattern Patch works for me! Nice! Thanks!
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c5ca07652ca09f4a7bce13c4b476d93b0f0b50ab commit c5ca07652ca09f4a7bce13c4b476d93b0f0b50ab Author: James Le Cuirot <chewi@gentoo.org> AuthorDate: 2019-11-20 22:33:22 +0000 Commit: James Le Cuirot <chewi@gentoo.org> CommitDate: 2019-11-20 22:33:22 +0000 games-util/lgogdownloader: Patch 3.5 to fix build with newer jsoncpp Patch has been sent upstream. Closes: https://bugs.gentoo.org/700452 Package-Manager: Portage-2.3.79, Repoman-2.3.17 Signed-off-by: James Le Cuirot <chewi@gentoo.org> games-util/lgogdownloader/files/jsoncpp.patch | 27 ++++++++++++++++++++++ .../lgogdownloader/lgogdownloader-3.5.ebuild | 4 ++++ 2 files changed, 31 insertions(+)
I didn't use the attached patch because it would break with the older version. Upstream merged my patch 3 minutes after I submitted it. :)
