Version 1.3.0 of media-video/handbrake is out. Reproducible: Always
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a9402dcb1e2bbc0f90b3f996780a205820cca7f3 commit a9402dcb1e2bbc0f90b3f996780a205820cca7f3 Author: Ian Whyman <thev00d00@gentoo.org> AuthorDate: 2019-11-15 20:50:01 +0000 Commit: Ian Whyman <thev00d00@gentoo.org> CommitDate: 2019-11-15 20:50:22 +0000 media-video/handbrake: 1.3.0 Bump Closes: https://bugs.gentoo.org/698970 Closes: https://bugs.gentoo.org/700098 Package-Manager: Portage-2.3.79, Repoman-2.3.18 Signed-off-by: Ian Whyman <thev00d00@gentoo.org> media-video/handbrake/Manifest | 1 + media-video/handbrake/handbrake-1.3.0.ebuild | 171 +++++++++++++++++++++++++++ media-video/handbrake/handbrake-9999.ebuild | 2 + 3 files changed, 174 insertions(+)
--disable-numa is missing in ebuild, causing build failure when numa package is not installed.
Hi. The 1.3.0 ebuild contains multiple issues and a proper testing procedure should have prevented addition of 1.3.0 to the main Gentoo repository. - package versions in the ebuild contradict recommendations listed in https://handbrake.fr/news.php?article=43 - missing use flag "vce" for enabling AMD VCE encoding
I'm also getting: /usr/lib/gcc/x86_64-pc-linux-gnu/9.2.0/../../../../x86_64-pc-linux-gnu/bin/ld: ./libhb/libhandbrake.a(encx265.o): undefined reference to symbol 'x265_api_query' /usr/lib/gcc/x86_64-pc-linux-gnu/9.2.0/../../../../x86_64-pc-linux-gnu/bin/ld: /usr/lib64/libx265.so.179: error adding symbols: DSO missing from command line collect2: error: ld returned 1 exit status make: *** [../test/module.rules:47: HandBrakeCLI] Error 1
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d09b96ef52113113a42c3b7b51ed8dd858bec4c7 commit d09b96ef52113113a42c3b7b51ed8dd858bec4c7 Author: Ian Whyman <thev00d00@gentoo.org> AuthorDate: 2019-11-16 21:50:22 +0000 Commit: Ian Whyman <thev00d00@gentoo.org> CommitDate: 2019-11-16 21:50:37 +0000 media-video/handbrake: 1.3.0: Fix x265, Add numa Closes: https://bugs.gentoo.org/700098 Package-Manager: Portage-2.3.79, Repoman-2.3.18 Signed-off-by: Ian Whyman <thev00d00@gentoo.org> .../handbrake-1.3.0-missing-linker-flags.patch | 27 ++++++++++++++++++++++ ...handbrake-9999-fix-missing-x265-link-flag.patch | 13 ----------- ...rake-1.3.0.ebuild => handbrake-1.3.0-r1.ebuild} | 9 ++++---- media-video/handbrake/metadata.xml | 1 + 4 files changed, 33 insertions(+), 17 deletions(-)
Apologies for the x265 breakage, somehow testing with USE=x265 slipped through the net. As for AMD VCE, we would first need to get amf-amdgpu-pro available in Gentoo.
This has broken the same way in 1.3.2 now with missing symbols from x265. I just created a local ebuild of 1.3.2 and used the same handbrake-1.3.0-missing-linker-flags.patch, modified for 1.3.2 offsets, and the build succeeds now.