Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 700024 - net-print/cups-filters: cups-browsed SEGVs
Summary: net-print/cups-filters: cups-browsed SEGVs
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Linux bug wranglers
URL: https://github.com/OpenPrinting/cups-...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-11-13 16:56 UTC by Joakim Tjernlund
Modified: 2019-11-14 08:15 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Fixes SEGV (fix-segv.patch,776 bytes, patch)
2019-11-13 16:57 UTC, Joakim Tjernlund
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joakim Tjernlund 2019-11-13 16:56:30 UTC
in utils/cups-browsed.c there is:

2852	    if (temp->media_source == NULL) {
2853	      if (cluster_supports_given_attribute(cluster_name, IPP_TAG_KEYWORD,
2854						   "media-source-supported")) {
2855	        strcpy(temp->media_source,AUTO_OPTION);

strcpy to a NULL dst will SEGV
Comment 1 Joakim Tjernlund 2019-11-13 16:57:53 UTC
Created attachment 596010 [details, diff]
Fixes SEGV
Comment 2 Joakim Tjernlund 2019-11-13 17:33:54 UTC
The patch is very naive, check what upstream has to say in issue 175
Comment 3 Larry the Git Cow gentoo-dev 2019-11-14 08:15:23 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e64d6fba8ed13603a8280f7c633211d4542cb5d0

commit e64d6fba8ed13603a8280f7c633211d4542cb5d0
Author:     Lars Wendler <polynomial-c@gentoo.org>
AuthorDate: 2019-11-14 08:14:49 +0000
Commit:     Lars Wendler <polynomial-c@gentoo.org>
CommitDate: 2019-11-14 08:15:17 +0000

    net-print/cups-filters: Revbump to fix segfault in cups-browsed
    
    Reported-by: Joakim Tjernlund <joakim.tjernlund@infinera.com>
    Thanks-to: Joakim Tjernlund <joakim.tjernlund@infinera.com>
    Closes: https://bugs.gentoo.org/700024
    Package-Manager: Portage-2.3.79, Repoman-2.3.18
    Signed-off-by: Lars Wendler <polynomial-c@gentoo.org>

 ...25.12.ebuild => cups-filters-1.25.12-r1.ebuild} |  4 ++
 .../cups-filters-1.25.12-browsed_segfault.patch    | 69 ++++++++++++++++++++++
 2 files changed, 73 insertions(+)