Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 699606 - games-emulation/vbam: v2.1.4 bump request; ebuild attached
Summary: games-emulation/vbam: v2.1.4 bump request; ebuild attached
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo Games
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-11-08 12:50 UTC by Witcher 7
Modified: 2019-12-06 11:04 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
vbam-2.1.4.ebuild (vbam-2.1.4.ebuild,2.25 KB, text/plain)
2019-11-08 12:51 UTC, Witcher 7
Details
patch 1 for the above ebuild (vbam-2.1.4-no-openal.patch,286 bytes, patch)
2019-11-08 12:52 UTC, Witcher 7
Details | Diff
Patch 2. (vbam-2.1.4-no-openmp.patch,353 bytes, patch)
2019-11-08 12:53 UTC, Witcher 7
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Witcher 7 2019-11-08 12:50:13 UTC
Now 2.1.4 is there. I attached an ebuild, which has three changes from the one in the official portage tree:

i) When USE="wxwidgets -openal", the build fails. I submitted a fix to the upstream: https://github.com/visualboyadvance-m/visualboyadvance-m/issues/563
In the attached ebuild, it is handled by a patch.

ii) If gcc is built without openmp, the build fails. (See the attached elog.) I know gcc now has IUSE=+openmp and this is an exceptional case. My ebuild patches when
"has_version gcc[openmp]"
is false, but you may want to replace it with BDEPEND=gcc[openmp]. I leave it to you.

This was not the case in v2.1.0, because of a typo:
 set(MYU_C_FLAGS ${MY_C_FLAGS} -fopenmp)
(Notice "MYU", not "MY". See this upstream commit: https://github.com/visualboyadvance-m/visualboyadvance-m/commit/c6fa7246de47bd47f9eeb4a8e5a13cc01c6d1fff)

This indicates that the cflag "-fopenmp" can be dropped. In fact my vbam with wxwidegts seems to run correctly without -fopenmp.

iii) The patch in the official portage tree is not necessary any more.

Thanks beforehand.


Reproducible: Always
Comment 1 Witcher 7 2019-11-08 12:51:14 UTC
Created attachment 595422 [details]
vbam-2.1.4.ebuild
Comment 2 Witcher 7 2019-11-08 12:52:19 UTC
Created attachment 595424 [details, diff]
patch 1 for the above ebuild
Comment 3 Witcher 7 2019-11-08 12:53:35 UTC
Created attachment 595426 [details, diff]
Patch 2.
Comment 4 Witcher 7 2019-11-13 22:43:58 UTC
Upstream fixed the above mentioned bug (Building failure with wxWidgets but without OpenAL) closed in this commit in the master git branch: https://github.com/visualboyadvance-m/visualboyadvance-m/commit/ae7349b06f86ff60b0d14dfa01b3fe2163dcfbab
They didin't use my "patch 1". I don't know if cherry-picking that upstream fix is safe, so perhaps better to wait for the next release.

Anyway Gentoo users can use mine.

Notice v2.1.0 (the latest in the portage tree) has a bug that keyboard shortcuts don't work. https://github.com/visualboyadvance-m/visualboyadvance-m/issues/88
In the latest upstream release, v2.1.4, it's fixed.

Thanks.
Comment 5 Larry the Git Cow gentoo-dev 2019-12-06 11:04:34 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e4658a559cc8782d012c43cfefdaaac1d335974d

commit e4658a559cc8782d012c43cfefdaaac1d335974d
Author:     Lars Wendler <polynomial-c@gentoo.org>
AuthorDate: 2019-12-06 11:04:21 +0000
Commit:     Lars Wendler <polynomial-c@gentoo.org>
CommitDate: 2019-12-06 11:04:21 +0000

    games-emulation/vbam: Bump to version 2.1.4
    
    Thanks-to: Witcher 7 <witcher-echoes@a2.topaz.ne.jp>
    Closes: https://bugs.gentoo.org/699606
    Package-Manager: Portage-2.3.81, Repoman-2.3.19
    Signed-off-by: Lars Wendler <polynomial-c@gentoo.org>

 games-emulation/vbam/Manifest                      |   1 +
 .../vbam/files/vbam-2.1.4-cmake_fix.patch          | 163 +++++++++++++++++++++
 games-emulation/vbam/vbam-2.1.4.ebuild             |  94 ++++++++++++
 3 files changed, 258 insertions(+)