Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 699594 - dev-util/cppcheck-1.88 should pass CFGDIR to cppcheck-gui during build
Summary: dev-util/cppcheck-1.88 should pass CFGDIR to cppcheck-gui during build
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: AMD64 Linux
: Normal normal (vote)
Assignee: Matthias Maier
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2019-11-08 06:38 UTC by Gabriel Marcano
Modified: 2021-05-31 04:01 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
cppcheck-1.88-fix-cfgdir-gui.patch (cppcheck-1.88-fix-cfgdir-gui.patch,348 bytes, patch)
2019-11-08 06:40 UTC, Gabriel Marcano
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gabriel Marcano 2019-11-08 06:38:46 UTC
Running cppcheck-gui, loading a cppcheck project, and then running a check using, for example, the C++ standard libraries (std.cfg configuration) leads to an error complaining about being unable to find std.cfg, that the program wasn't compiled properly. I took a look at the ebuild-- while we're passing CFGDIR to the compilation of the cppcheck binary, we are not doing the same for the compilation of the cppcheck-gui binary. I have a (rather ugly) patch to the ebuild that fixes this.

Reproducible: Always

Steps to Reproduce:
1. Create a cppcheck project with C++ and try to run a check against a repository
Actual Results:  
Complains about not being able to find std.cfg

Expected Results:  
No complaints

I'm using ~amd64. Here's my emerge --info:

# emerge --info
Portage 2.3.78 (python 3.6.9-final-0, default/linux/amd64/17.1/desktop/plasma, gcc-9.2.0, glibc-2.29-r6, 5.3.9-gentoo x86_64)
=================================================================
System uname: Linux-5.3.9-gentoo-x86_64-Intel-R-_Core-TM-_i7-8850H_CPU_@_2.60GHz-with-gentoo-2.6
KiB Mem:    16142440 total,   3526412 free
KiB Swap:   16783680 total,  16655680 free
Timestamp of repository gentoo: Thu, 07 Nov 2019 18:00:01 +0000
Head commit of repository gentoo: 35649ba689623e24501e7091b13eb8ba8d60fc84
sh bash 5.0_p11
ld GNU ld (Gentoo 2.32 p2) 2.32.0
app-shells/bash:          5.0_p11::gentoo
dev-java/java-config:     2.2.0-r4::gentoo
dev-lang/perl:            5.30.0::gentoo
dev-lang/python:          2.7.16::gentoo, 3.6.9::gentoo, 3.7.5-r1::gentoo
dev-util/cmake:           3.15.5::gentoo
sys-apps/baselayout:      2.6-r1::gentoo
sys-apps/openrc:          0.42.1::gentoo
sys-apps/sandbox:         2.18::gentoo
sys-devel/autoconf:       2.13-r1::gentoo, 2.69-r4::gentoo
sys-devel/automake:       1.16.1-r1::gentoo
sys-devel/binutils:       2.32-r1::gentoo
sys-devel/gcc:            8.3.0-r3::gentoo, 9.2.0-r2::gentoo
sys-devel/gcc-config:     2.1::gentoo
sys-devel/libtool:        2.4.6-r5::gentoo
sys-devel/make:           4.2.1-r4::gentoo
sys-kernel/linux-headers: 5.3::gentoo (virtual/os-headers)
sys-libs/glibc:           2.29-r6::gentoo
Repositories:

gentoo
    location: /var/db/repos/gentoo
    sync-type: rsync
    sync-uri: rsync://rsync.gentoo.org/gentoo-portage
    priority: -1000
    sync-rsync-extra-opts: 
    sync-rsync-verify-jobs: 1
    sync-rsync-verify-max-age: 24
    sync-rsync-verify-metamanifest: yes

dev
    location: /home/gmarcano/Projects/gentoo/portage
    masters: gentoo

localrepo
    location: /var/db/repos/localrepo
    masters: gentoo

waebbl
    location: /var/lib/layman/waebbl
    masters: gentoo
    priority: 50

ACCEPT_KEYWORDS="amd64 ~amd64"
ACCEPT_LICENSE="@FREE"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-O2 -pipe -fomit-frame-pointer -march=native"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/lib64/libreoffice/program/sofficerc /usr/share/config /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c"
CXXFLAGS="-O2 -pipe -fomit-frame-pointer -march=native"
DISTDIR="/var/cache/distfiles"
ENV_UNSET="DBUS_SESSION_BUS_ADDRESS DISPLAY GOBIN PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR"
FCFLAGS="-O2 -pipe -fomit-frame-pointer -march=native"
FEATURES="assume-digests binpkg-docompress binpkg-dostrip binpkg-logs config-protect-if-modified distlocks ebuild-locks fixlafiles ipc-sandbox merge-sync multilib-strict network-sandbox news parallel-fetch pid-sandbox preserve-libs protect-owned sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
FFLAGS="-O2 -pipe -fomit-frame-pointer -march=native"
GENTOO_MIRRORS="http://distfiles.gentoo.org"
LANG="en_US.utf8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
LINGUAS="en es"
MAKEOPTS="-j13"
PKGDIR="/var/cache/binpkgs"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git"
PORTAGE_TMPDIR="/var/tmp"
USE="X a52 aac acl acpi activities alsa amd64 berkdb bluetooth branding bzip2 cairo cdda cdr cli consolekit crypt cups cxx dbus declarative dri dts dvd dvdr emboss encode exif fam flac fortran gdbm gif gpm gtk iconv icu ipv6 jpeg kde kerberos kipi kwallet lcms ldap libnotify libtirpc mad mng mp3 mp4 mpeg multilib ncurses nls nptl ogg opengl openmp pam pango pcre pdf phonon plasma png policykit ppds pulseaudio qml qt5 readline sdl seccomp semantic-desktop spell split-usr ssl startup-notification svg tcpd tiff truetype udev udisks unicode upower usb vorbis widgets wxwidgets x264 xattr xcb xcomposite xml xv xvid zlib" ABI_X86="64" ADA_TARGET="gnat_2018" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="karbon sheets words" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="mmx mmxext sse sse2 aes avx avx2 f16c fma3 pclmul popcnt sse3 sse4_1 sse4_2 ssse3" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock greis isync itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 timing tsip tripmate tnt ublox ubx" GRUB_PLATFORMS="efi-64" INPUT_DEVICES="libinput keyboard mouse" KERNEL="linux" L10N="en es" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" NETBEANS_MODULES="apisupport cnd groovy gsf harness ide identity j2ee java mobility nb php profiler soa visualweb webcommon websvccommon xml" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php7-2" POSTGRES_TARGETS="postgres10 postgres11" PYTHON_SINGLE_TARGET="python3_6" PYTHON_TARGETS="python2_7 python3_6 python3_7" RUBY_TARGETS="ruby24 ruby25" USERLAND="GNU" VIDEO_CARDS="i965 nvidia intel" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CC, CPPFLAGS, CTARGET, CXX, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LC_ALL, PORTAGE_BINHOST, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS
Comment 1 Gabriel Marcano 2019-11-08 06:40:26 UTC
Created attachment 595418 [details, diff]
cppcheck-1.88-fix-cfgdir-gui.patch

When applied to the ebuild this fixes the issue. cppcheck-gui is able to find std.cfg properly. I'm not all that happy about all of the escaping that was necessary to get the " to make it through properly.
Comment 2 Gabriel Marcano 2020-02-27 06:25:02 UTC
At this point cppcheck-1.90 is available upstream, and they've completely changed the way they're handling this particular variable. Should we bother patching 1.88 at this point?

As an aside, they've renamed CFGDIR to FILESDIR, which collides with the Gentoo FILESDIR variable. In a testing ebuild I have locally, I had to sed s/FILESDIR/FILESDIR_/ to stop the collision from happening for 1.90...
Comment 3 Larry the Git Cow gentoo-dev 2020-12-04 05:37:46 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f631b786b5dc48a16224e856417ceb44231428a7

commit f631b786b5dc48a16224e856417ceb44231428a7
Author:     Matthias Maier <tamiko@gentoo.org>
AuthorDate: 2020-12-04 04:56:31 +0000
Commit:     Matthias Maier <tamiko@gentoo.org>
CommitDate: 2020-12-04 05:37:16 +0000

    dev-util/cppcheck: version bump to 2.2
    
    Thanks to Bernd Buschinski for the initial ebuild
    
    Closes: https://bugs.gentoo.org/693352
    Bug: https://bugs.gentoo.org/699594
    Package-Manager: Portage-3.0.11, Repoman-3.0.2
    Signed-off-by: Matthias Maier <tamiko@gentoo.org>

 dev-util/cppcheck/Manifest            |  1 +
 dev-util/cppcheck/cppcheck-2.2.ebuild | 80 +++++++++++++++++++++++++++++++++++
 dev-util/cppcheck/metadata.xml        |  3 ++
 profiles/arch/hppa/package.use.mask   |  4 ++
 profiles/arch/sparc/package.use.mask  |  4 ++
 5 files changed, 92 insertions(+)