Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 699506 - www-apps/zeppelin-bin: dosym with path starting with ${ED}
Summary: www-apps/zeppelin-bin: dosym with path starting with ${ED}
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: Normal normal (vote)
Assignee: Patrice Clement
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-11-07 01:57 UTC by Arfrever Frehtes Taifersar Arahesis
Modified: 2019-11-28 22:10 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Arfrever Frehtes Taifersar Arahesis 2019-11-07 01:57:17 UTC
www-apps/zeppelin-bin/zeppelin-bin-0.8.1.ebuild:  dosym "${ED}/${INSTALL_DIR}" /opt/zeppelin


Problems with above dosym command:

1. Initial ${D} or ${ED} is unnecessary in first argument (target of symbolic link), and PMS-compliant package managers will issue QA notice.
   PMS (https://projects.gentoo.org/pms/7/pms.html#x1-14800013.4.1):
   """
   13.4.1 Rewriting

   Any absolute symlink whose link starts with D must be rewritten with
   the leading D removed. The package manager should issue a notice when doing this. 
   """

2. Target of symbolic link could be made relative, instead of absolute.


Solution:
(Since INSTALL_DIR="/opt/${P}")

dosym ${P} /opt/zeppelin
Comment 1 Larry the Git Cow gentoo-dev 2019-11-28 22:10:41 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=37d6a4145d33401335eaf26a81439f08d3c418fa

commit 37d6a4145d33401335eaf26a81439f08d3c418fa
Author:     Patrice Clement <monsieurp@gentoo.org>
AuthorDate: 2019-11-28 22:05:43 +0000
Commit:     Patrice Clement <monsieurp@gentoo.org>
CommitDate: 2019-11-28 22:05:43 +0000

    www-apps/zeppelin-bin: don't call dosym using ED but rather P.
    
    Courtesy of Arfrever.
    
    Closes: https://bugs.gentoo.org/699506
    Package-Manager: Portage-2.3.79, Repoman-2.3.16
    Signed-off-by: Patrice Clement <monsieurp@gentoo.org>

 www-apps/zeppelin-bin/zeppelin-bin-0.8.1.ebuild | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)