Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 699504 - sys-cluster/spark-bin: dosym with path starting with ${ED}
Summary: sys-cluster/spark-bin: dosym with path starting with ${ED}
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: Normal normal (vote)
Assignee: Java team
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2019-11-07 01:52 UTC by Arfrever Frehtes Taifersar Arahesis
Modified: 2019-11-13 15:05 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Arfrever Frehtes Taifersar Arahesis 2019-11-07 01:52:34 UTC
sys-cluster/spark-bin/spark-bin-2.3.1.ebuild:   dosym "${ED%/}"/usr/lib/spark/bin/beeline /usr/bin/beeline
sys-cluster/spark-bin/spark-bin-2.3.1.ebuild:   dosym "${ED%/}"/usr/lib/spark/bin/pyspark /usr/bin/pyspark
sys-cluster/spark-bin/spark-bin-2.3.1.ebuild:   dosym "${ED%/}"/usr/lib/spark/bin/pyspark /usr/bin/find-spark-home
sys-cluster/spark-bin/spark-bin-2.3.1.ebuild:   dosym "${ED%/}"/usr/lib/spark/bin/spark-class /usr/bin/spark-class
sys-cluster/spark-bin/spark-bin-2.3.1.ebuild:   dosym "${ED%/}"/usr/lib/spark/bin/spark-shell /usr/bin/spark-shell
sys-cluster/spark-bin/spark-bin-2.3.1.ebuild:   dosym "${ED%/}"/usr/lib/spark/bin/spark-sql /usr/bin/spark-sql
sys-cluster/spark-bin/spark-bin-2.3.1.ebuild:   dosym "${ED%/}"/usr/lib/spark/bin/spark-submit /usr/bin/spark-submit
sys-cluster/spark-bin/spark-bin-2.4.4.ebuild:   dosym "${ED%/}"/usr/lib/spark/bin/beeline /usr/bin/beeline
sys-cluster/spark-bin/spark-bin-2.4.4.ebuild:   dosym "${ED%/}"/usr/lib/spark/bin/pyspark /usr/bin/pyspark
sys-cluster/spark-bin/spark-bin-2.4.4.ebuild:   dosym "${ED%/}"/usr/lib/spark/bin/pyspark /usr/bin/find-spark-home
sys-cluster/spark-bin/spark-bin-2.4.4.ebuild:   dosym "${ED%/}"/usr/lib/spark/bin/spark-class /usr/bin/spark-class
sys-cluster/spark-bin/spark-bin-2.4.4.ebuild:   dosym "${ED%/}"/usr/lib/spark/bin/spark-shell /usr/bin/spark-shell
sys-cluster/spark-bin/spark-bin-2.4.4.ebuild:   dosym "${ED%/}"/usr/lib/spark/bin/spark-sql /usr/bin/spark-sql
sys-cluster/spark-bin/spark-bin-2.4.4.ebuild:   dosym "${ED%/}"/usr/lib/spark/bin/spark-submit /usr/bin/spark-submit


Problems with above dosym commands:

1. Initial ${D} or ${ED} is unnecessary in first argument (target of symbolic link), and PMS-compliant package managers will issue QA notice.
   PMS (https://projects.gentoo.org/pms/7/pms.html#x1-14800013.4.1):
   """
   13.4.1 Rewriting

   Any absolute symlink whose link starts with D must be rewritten with
   the leading D removed. The package manager should issue a notice when doing this. 
   """

2. Target of symbolic link could be made relative, instead of absolute.


Solution:

dosym ../lib/spark/bin/beeline /usr/bin/beeline
dosym ../lib/spark/bin/pyspark /usr/bin/pyspark
dosym ../lib/spark/bin/pyspark /usr/bin/find-spark-home
dosym ../lib/spark/bin/spark-class /usr/bin/spark-class
dosym ../lib/spark/bin/spark-shell /usr/bin/spark-shell
dosym ../lib/spark/bin/spark-sql /usr/bin/spark-sql
dosym ../lib/spark/bin/spark-submit /usr/bin/spark-submit
Comment 1 Larry the Git Cow gentoo-dev 2019-11-13 15:05:10 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=600a367b138080090e5fb955ca8e297f5bbaa1aa

commit 600a367b138080090e5fb955ca8e297f5bbaa1aa
Author:     Alec Ten Harmsel <alec@alectenharmsel.com>
AuthorDate: 2019-11-11 21:02:16 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2019-11-13 15:04:55 +0000

    sys-cluster/spark-bin: Remove ${ED} from dosym
    
    Relative links are preferred over using ${ED} in symlink paths
    
    Signed-off-by: Alec Ten Harmsel <alec@alectenharmsel.com>
    Closes: https://bugs.gentoo.org/699504
    Package-Manager: Portage-2.3.76, Repoman-2.3.16
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 sys-cluster/spark-bin/spark-bin-2.3.1-r1.ebuild | 61 +++++++++++++++++++++++++
 sys-cluster/spark-bin/spark-bin-2.4.4-r1.ebuild | 61 +++++++++++++++++++++++++
 2 files changed, 122 insertions(+)