media-gfx/iscan/iscan-2.30.3.1.ebuild: dosym "${ED}"/usr/bin/iscan "${plugindir}"/iscan media-gfx/iscan/iscan-2.30.4.2.ebuild: dosym "${ED%/}"/usr/bin/iscan "${gimpplugindir}"/iscan Problems with above dosym command: 1. Initial ${D} or ${ED} is unnecessary in first argument (target of symbolic link), and PMS-compliant package managers will issue QA notice. PMS (https://projects.gentoo.org/pms/7/pms.html#x1-14800013.4.1): """ 13.4.1 Rewriting Any absolute symlink whose link starts with D must be rewritten with the leading D removed. The package manager should issue a notice when doing this. """ 2. Target of symbolic link could be made relative, instead of absolute. Solution: dosym $(realpath -s --relative-to="${gimpplugindir}" "${EPREFIX}/usr/bin/iscan") "${gimpplugindir}"/iscan
Why doesn't repoman emit a QA notice for this?
Install >=app-portage/repoman-2.3.18 and it will print warning.
Ok thanks. That's a really new version.
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=676396715b909dc72320cb5adddac3ea654fb76b commit 676396715b909dc72320cb5adddac3ea654fb76b Author: Matthew Schultz <mattsch@gmail.com> AuthorDate: 2019-11-11 05:17:56 +0000 Commit: Joonas Niilola <juippis@gentoo.org> CommitDate: 2019-11-20 06:03:24 +0000 media-gfx/iscan: Removed ${ED} for PMS-compliant package managers. Closes: https://bugs.gentoo.org/699498 Package-Manager: Portage-2.3.76, Repoman-2.3.16 Signed-off-by: Matthew Schultz <mattsch@gmail.com> Closes: https://github.com/gentoo/gentoo/pull/13607 Signed-off-by: Joonas Niilola <juippis@gentoo.org> media-gfx/iscan/iscan-2.30.4.2.ebuild | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
