Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 699488 - dev-ada/gps: dosym with path starting with ${D}
Summary: dev-ada/gps: dosym with path starting with ${D}
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: Normal normal (vote)
Assignee: Gentoo Linux ADA team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-11-07 00:00 UTC by Arfrever Frehtes Taifersar Arahesis
Modified: 2019-11-07 18:14 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Arfrever Frehtes Taifersar Arahesis 2019-11-07 00:00:36 UTC
dev-ada/gps/gps-2018-r1.ebuild: dosym "${D}"/usr/$(get_libdir)/libgtk-3.so.0.* /usr/$(get_libdir)/gps/libgtk-3.so.0
dev-ada/gps/gps-2018-r2.ebuild: dosym "${D}"/usr/$(get_libdir)/libgtk-3.so.0.* /usr/$(get_libdir)/gps/libgtk-3.so.0


Problems with above dosym command:

1. Initial ${D} or ${ED} is unnecessary in first argument (target of symbolic link), and PMS-compliant package managers will issue QA notice.
   PMS (https://projects.gentoo.org/pms/7/pms.html#x1-14800013.4.1):
   """
   13.4.1 Rewriting

   Any absolute symlink whose link starts with D must be rewritten with
   the leading D removed. The package manager should issue a notice when doing this. 
   """

2. Target of symbolic link could be made relative, instead of absolute.


Solution:

dosym ../$(cd "${ED}/usr/$(get_libdir)" && echo libgtk-3.so.0.*) /usr/$(get_libdir)/gps/libgtk-3.so.0
Comment 1 Larry the Git Cow gentoo-dev 2019-11-07 18:14:16 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6cda2bea7bc69f75035393996c35f9cfb3cc50af

commit 6cda2bea7bc69f75035393996c35f9cfb3cc50af
Author:     Tupone Alfredo <tupone@gentoo.org>
AuthorDate: 2019-11-07 18:03:04 +0000
Commit:     Tupone Alfredo <tupone@gentoo.org>
CommitDate: 2019-11-07 18:13:57 +0000

    dev-ada/gps: fix dosym
    
    Closes: https://bugs.gentoo.org/699488
    Package-Manager: Portage-2.3.76, Repoman-2.3.16
    Signed-off-by: Alfredo Tupone <tupone@gentoo.org>

 dev-ada/gps/gps-2018-r2.ebuild | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)