Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 699472 - net-im/mattermost-desktop-bin: dosym with path starting with ${EROOT}
Summary: net-im/mattermost-desktop-bin: dosym with path starting with ${EROOT}
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: Normal normal
Assignee: Matthew Thode ( prometheanfire )
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-11-06 20:07 UTC by Arfrever Frehtes Taifersar Arahesis
Modified: 2019-11-06 20:27 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Arfrever Frehtes Taifersar Arahesis 2019-11-06 20:07:07 UTC
https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=48076b8ca205364318b89f183f331af0d757bfac

commit 48076b8ca205364318b89f183f331af0d757bfac
Author:     Matthew Thode <prometheanfire@gentoo.org>
AuthorDate: 2019-11-03 22:08:36 +0000
Commit:     Matthew Thode <prometheanfire@gentoo.org>
CommitDate: 2019-11-03 22:08:51 +0000

    net-im/mattermost-desktop-bin: fix dosym


"Fix" was incorrect:
-	dosym "/opt/${MY_PN}/${MY_PN}" "/usr/bin/${MY_PN}"
+	dosym "../../opt/${MY_PN}/${MY_PN}" "${EROOT}/usr/bin/${MY_PN}"


Using ${ROOT} or ${EROOT} (in any way in src_* phases) results in broken binary packages when different values of ${ROOT} are used.
dosym internally prepends ${ED%/} to second path (symbolic link itself) when calling ln.


The following command would create a correct, relative symbolic link:

dosym "../../opt/${MY_PN}/${MY_PN}" "/usr/bin/${MY_PN}"
(Although quotes are not required here...)
Comment 1 Larry the Git Cow gentoo-dev 2019-11-06 20:27:49 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=46d4ad096771180bee110d1c8d90c435e38a98bd

commit 46d4ad096771180bee110d1c8d90c435e38a98bd
Author:     Matthew Thode <prometheanfire@gentoo.org>
AuthorDate: 2019-11-06 20:27:32 +0000
Commit:     Matthew Thode <prometheanfire@gentoo.org>
CommitDate: 2019-11-06 20:27:44 +0000

    net-im/mattermost-desktop-bin: fix unneeded eroor
    
    Fixes: https://bugs.gentoo.org/699472
    Package-Manager: Portage-2.3.76, Repoman-2.3.17
    Signed-off-by: Matthew Thode <prometheanfire@gentoo.org>

 net-im/mattermost-desktop-bin/mattermost-desktop-bin-4.3.1.ebuild | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)