Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 699346 - dev-libs/spdlog-9999 - src_prepare(): ERROR: patch -p1 failed with files/spdlog-9999-unbundle-fmt.patch
Summary: dev-libs/spdlog-9999 - src_prepare(): ERROR: patch -p1 failed with files/spdl...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: David Roman
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2019-11-05 02:54 UTC by cyrillic
Modified: 2020-01-21 02:12 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description cyrillic 2019-11-05 02:54:08 UTC 
dev-libs/spdlog-9999  spdlog-9999-unbundle-fmt.patch no longer applies cleanly.

Unbundling fmt is no longer needed with this cmake option:
  -DSPDLOG_FMT_EXTERNAL=yes

This was already suggested in bug 675366

Reproducible: Always
Comment 1 David Roman 2019-11-05 18:41:24 UTC 
(In reply to cyrillic from comment #0)
> dev-libs/spdlog-9999  spdlog-9999-unbundle-fmt.patch no longer applies
> cleanly.
> 
> Unbundling fmt is no longer needed with this cmake option:
>   -DSPDLOG_FMT_EXTERNAL=yes
> 
> This was already suggested in bug 675366
> 
> Reproducible: Always

Thanks. PR #13256 should fix it.
Comment 2 Larry the Git Cow gentoo-dev 2020-01-21 02:12:45 UTC 
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=cb4209494b05520fa84511c0ec3df825085af73e

commit cb4209494b05520fa84511c0ec3df825085af73e
Author:     David Roman <davidroman96@gmail.com>
AuthorDate: 2020-01-20 21:08:54 +0000
Commit:     Craig Andrews <candrews@gentoo.org>
CommitDate: 2020-01-21 02:12:34 +0000

    dev-libs/spdlog: bump to 1.5.0
    
    Closes: https://bugs.gentoo.org/696710
    Closes: https://bugs.gentoo.org/699346
    Package-Manager: Portage-2.3.84, Repoman-2.3.20
    Signed-off-by: David Roman <davidroman96@gmail.com>
    Closes: https://github.com/gentoo/gentoo/pull/14113
    Signed-off-by: Craig Andrews <candrews@gentoo.org>

 dev-libs/spdlog/Manifest                           |  1 +
 .../spdlog/files/spdlog-9999-unbundle-fmt.patch    | 45 ---------------------
 dev-libs/spdlog/spdlog-1.5.0.ebuild                | 47 ++++++++++++++++++++++
 dev-libs/spdlog/spdlog-9999.ebuild                 | 20 +++++----
 4 files changed, 61 insertions(+), 52 deletions(-)