699218 – sys-devel/automake: py-compile doesn't compile opt-2 correctly

Bug 699218 - sys-devel/automake: py-compile doesn't compile opt-2 correctly

Summary: sys-devel/automake: py-compile doesn't compile opt-2 correctly

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Current packages (show other bugs)
Hardware:	All Linux

Importance:	Normal normal
Assignee:	Gentoo's Team for Core System packages

URL:
Whiteboard:
Keywords:	PullRequest

Depends on:
Blocks:

Reported:	2019-11-03 10:16 UTC by Michał Górny
Modified:	2022-07-27 09:12 UTC (History)
CC List:	1 user (show)

See Also:	https://debbugs.gnu.org/38043 https://github.com/gentoo/gentoo/pull/13535
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Michał Górny archtester

2019-11-03 10:16:24 UTC

The py-compile script supplied by automake doesn't reinvent the wheel correctly, and does not generate opt-2 level scripts with Python 3.  Furthermore, it wrongly skips opt-1 for PyPy3.

Comment 1 Michał Górny archtester

2019-11-03 21:50:00 UTC

For the record, I'd really prefer if we merged some fix for this ASAP rather than waited for upstream.  This is one of the things where upstreams care much less than Gentoo Python project does.

Comment 2 Michał Górny archtester

2019-11-08 06:58:30 UTC

Ping.

Comment 3 Larry the Git Cow gentoo-dev

2019-11-08 09:47:54 UTC

The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c8a9593ce34635069bcff01b564f4233aebd79b0

commit c8a9593ce34635069bcff01b564f4233aebd79b0
Author:     Michał Górny <mgorny@gentoo.org>
AuthorDate: 2019-11-03 11:02:30 +0000
Commit:     Lars Wendler <polynomial-c@gentoo.org>
CommitDate: 2019-11-08 09:47:43 +0000

    sys-devel/automake: Fix byte-compiling Python modules on py3.5+
    
    Bug: https://bugs.gentoo.org/699218
    Signed-off-by: Michał Górny <mgorny@gentoo.org>
    Signed-off-by: Lars Wendler <polynomial-c@gentoo.org>

 sys-devel/automake/automake-1.16.1-r2.ebuild       | 113 +++++++++++++++++++++
 .../files/automake-1.16.1-py3-compile.patch        |  61 +++++++++++
 2 files changed, 174 insertions(+)

Comment 4 Andreas K. Hüttel archtester

2020-01-17 11:17:50 UTC

Also added to 9999 since upstream is kinda hibernating...

Comment 5 Sam James archtester

2022-07-27 08:30:10 UTC

We've had this in Gentoo for ages and it's in upstream git too.