Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 698990 - dev-qt/qtwebkit should support Python 3
Summary: dev-qt/qtwebkit should support Python 3
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: Normal normal (vote)
Assignee: Qt Bug Alias
URL: https://github.com/qtwebkit/qtwebkit/...
Whiteboard:
Keywords: InOverlay
Depends on:
Blocks: py3-tracker, python-3-incompatible
  Show dependency tree
 
Reported: 2019-10-31 04:15 UTC by Arfrever Frehtes Taifersar Arahesis
Modified: 2020-03-11 17:31 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Arfrever Frehtes Taifersar Arahesis 2019-10-31 04:15:45 UTC
dev-qt/qtwebkit should be ported to Python 3.

net-libs/webkit-gtk already supports Python 3, so maybe some changes can be backported.
Comment 1 Andreas Sturmlechner gentoo-dev 2019-10-31 07:23:38 UTC
Maybe the sources already support it at this point? Did you check?
Comment 2 charles17 2019-11-04 10:52:23 UTC
Compilation with python_targets_python2_7 masked works.

emerge -pvq qtwebkit
[ebuild   R   ] dev-qt/qtwebkit-5.212.0_pre20190629  USE="X gstreamer hyphen jit opengl printsupport -geolocation (-gles2) -multimedia -nsplugin -orientation -qml -webp"

But then ...

emerge -pvc python:2.7

Calculating dependencies... done!
  dev-lang/python-2.7.16 pulled in by:
    dev-libs/zziplib-0.13.69 requires >=dev-lang/python-2.7.5-r2:2.7
    dev-qt/qtwebkit-5.212.0_pre20190629 requires >=dev-lang/python-2.7.5-r2:2.7
    mail-client/thunderbird-68.2.1 requires dev-lang/python:2.7[ncurses,sqlite,ssl,threads(+)]
    www-client/firefox-68.2.0 requires dev-lang/python:2.7[ncurses,sqlite,ssl,threads(+)]

>>> No packages selected for removal by depclean
Comment 3 Andreas Sturmlechner gentoo-dev 2019-11-20 13:24:34 UTC
Can't confirm:

> -- Found PythonInterp: /usr/src/portage/dev-qt/qtwebkit-5.212.0_pre20190629/temp/python3.6/bin/python (found suitable version "3.6.9", minimum required is "2.7.0") 
> CMake Error at Source/cmake/WebKitCommon.cmake:29 (message):
>   Python 2 is required, but Python 3 was found.
> Call Stack (most recent call first):
>   CMakeLists.txt:137 (include)
>
>
> -- Configuring incomplete, errors occurred!
Comment 4 Larry the Git Cow gentoo-dev 2020-01-04 12:45:29 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/qt.git/commit/?id=02a94ae03dfe1575709b4de66c26c0502b0e6b4b

commit 02a94ae03dfe1575709b4de66c26c0502b0e6b4b
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2020-01-04 10:37:31 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2020-01-04 12:04:51 +0000

    dev-qt/qtwebkit: Add python3* and ruby27 support
    
    Bug: https://bugs.gentoo.org/698990
    Package-Manager: Portage-2.3.84, Repoman-2.3.20
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 dev-qt/qtwebkit/qtwebkit-5.9999.ebuild | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)
Comment 5 shinydoofy 2020-03-07 23:49:04 UTC
The linked github issue has been closed and branch qtwebkit-5.212 should now support python 3. The patch in qtwebkit-5.212.0_pre20190629-icu-65.patch has also been cheery-picked [1] and should not be necessary anymore.

Unfortunately, there's no new release or tarball yet.

[1] https://github.com/qtwebkit/qtwebkit/pull/915
Comment 6 Andreas Sturmlechner gentoo-dev 2020-03-08 10:40:10 UTC
(In reply to shinydoofy from comment #5)
> qtwebkit-5.212.0_pre20190629-icu-65.patch has also been cheery-picked [1]

commit dc02ec4 is where it was picked from in the first place...

Feel free to test in Qt overlay where py3 is in targets since 2020-01-04.
Comment 7 Larry the Git Cow gentoo-dev 2020-03-11 17:13:26 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/qt.git/commit/?id=69df5ab4c93c892fa5dea9758dc3db7fc39c2a7c

commit 69df5ab4c93c892fa5dea9758dc3db7fc39c2a7c
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2020-03-11 17:04:34 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2020-03-11 17:04:34 +0000

    dev-qt/qtwebkit: alpha4 switched to python3 for build
    
    Bug: https://bugs.gentoo.org/698990
    Package-Manager: Portage-2.3.93, Repoman-2.3.20
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 dev-qt/qtwebkit/qtwebkit-5.212.9999.ebuild | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Comment 8 Larry the Git Cow gentoo-dev 2020-03-11 17:31:39 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=46db89e77cf8676501abe2be42615d81b561e4ba

commit 46db89e77cf8676501abe2be42615d81b561e4ba
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2020-03-11 17:06:18 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2020-03-11 17:31:22 +0000

    dev-qt/qtwebkit: 5.212.0_pre20200309 (alpha4) version bump
    
    - Build with python3.
    - Unconditionally depend on media-libs/woff2
    
    Closes: https://bugs.gentoo.org/698990
    Closes: https://bugs.gentoo.org/704748
    Package-Manager: Portage-2.3.93, Repoman-2.3.20
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 dev-qt/qtwebkit/Manifest                           |   1 +
 .../qtwebkit/qtwebkit-5.212.0_pre20200309.ebuild   | 146 +++++++++++++++++++++
 2 files changed, 147 insertions(+)