Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 698846 - sci-geosciences/liblas - add missing return value in liblas.hpp patch
Summary: sci-geosciences/liblas - add missing return value in liblas.hpp patch
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Sci-geo Project
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2019-10-29 13:03 UTC by MarisN
Modified: 2020-03-08 20:32 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Upstream patch to add missing return (ifs.patch,348 bytes, patch)
2019-10-29 13:03 UTC, MarisN
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description MarisN 2019-10-29 13:03:35 UTC
Created attachment 594348 [details, diff]
Upstream patch to add missing return

Missing return statement in include/liblas/liblas.hpp causes calls to Open to always fail if liblas is compiled without Boost. As liblas src/c_api.cpp does not handle Open failures (returning NULL instead of throwing an exception), it causes a segfault in any application calling LASReader_Create or LASReader_CreateWithHeader.

The issue has been resolved upstream[1], but any new releases incorporating this patch seem to be unlikely[2].

1. https://github.com/libLAS/libLAS/pull/168
2. https://github.com/libLAS/libLAS/issues/146
Comment 1 Larry the Git Cow gentoo-dev 2020-02-26 16:56:41 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e46f6618ca90e250deecbe59263fa144f6aa5a30

commit e46f6618ca90e250deecbe59263fa144f6aa5a30
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2020-02-26 16:52:26 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2020-02-26 16:56:20 +0000

    sci-geosciences/liblas: fix >=GDAL-2.5.0, USE debug, missing return val
    
    Closes: https://bugs.gentoo.org/698846
    Closes: https://bugs.gentoo.org/668778
    Closes: https://bugs.gentoo.org/707706
    Package-Manager: Portage-2.3.89, Repoman-2.3.20
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 .../files/liblas-1.8.1-CVE-2018-20540-fixup.patch  | 24 ++++++++++
 .../liblas/files/liblas-1.8.1-fix-debug.patch      | 18 +++++++
 .../liblas/files/liblas-1.8.1-gdal-2.5.0.patch     | 34 +++++++++++++
 sci-geosciences/liblas/liblas-1.8.1-r3.ebuild      | 55 ++++++++++++++++++++++
 4 files changed, 131 insertions(+)
Comment 2 Larry the Git Cow gentoo-dev 2020-03-08 20:32:50 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=803867c67fd65907ce18865eb1a3c9292e65f5f1

commit 803867c67fd65907ce18865eb1a3c9292e65f5f1
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2020-03-08 19:57:09 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2020-03-08 19:57:09 +0000

    sci-geosciences/liblas: Drop 1.8.1-r2
    
    Closes: https://bugs.gentoo.org/698846
    Package-Manager: Portage-2.3.93, Repoman-2.3.20
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 sci-geosciences/liblas/liblas-1.8.1-r2.ebuild | 50 ---------------------------
 1 file changed, 50 deletions(-)