Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 698754 - media-libs/gegl & media-libs/babl - sync +introspection defaults
Summary: media-libs/gegl & media-libs/babl - sync +introspection defaults
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Sebastian Pipping
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-10-28 15:27 UTC by Ben Kohler
Modified: 2019-11-03 14:25 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ben Kohler gentoo-dev 2019-10-28 15:27:15 UTC
Since gegl-0.4.18 now has [introspection?] on its babl dep, and gegl's own IUSE has +introspection, can you add +introspection to IUSE on babl as well so that the USE requirement is fulfilled by default?

Thanks
Comment 1 Sebastian Pipping gentoo-dev 2019-10-28 16:06:05 UTC
Hi Ben,

I get the idea.  I couldn't find a reason why gegl has +introspection right now.  Would dropping the plus on gegl side be an equal, better or worse solution to you?
Comment 2 Ben Kohler gentoo-dev 2019-10-28 16:48:18 UTC
I would be fine either way.  I tried to dig into git/cvs history to see why the IUSE default was originally added, without success.

Going back to CVS days [1], 0.2.0-r1 had it IUSE="introspection" then 0.2.0-r2 had a commented "# +introspection" saying it was broken.  I cannot see why it was +'d.

Gnome profiles already enable the flag globally, and disabling it on gegl here locally on my kde plasma setup doesn't seem to cause any problems.

So I believe it should be safe to drop the +


[1] https://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/media-libs/gegl/?hideattic=0
Comment 3 Sebastian Pipping gentoo-dev 2019-10-28 17:30:36 UTC
I'll drop it from gegl then.  Thanks for the research!
Comment 4 Larry the Git Cow gentoo-dev 2019-10-28 17:33:25 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f52e58bc50e3e6e9b2567d2aa02f2eb7767351a6

commit f52e58bc50e3e6e9b2567d2aa02f2eb7767351a6
Author:     Sebastian Pipping <sping@gentoo.org>
AuthorDate: 2019-10-28 17:32:34 +0000
Commit:     Sebastian Pipping <sping@gentoo.org>
CommitDate: 2019-10-28 17:32:34 +0000

    media-libs/gegl: Stop enforcing USE=introspection
    
    Closes: https://bugs.gentoo.org/698754
    Signed-off-by: Sebastian Pipping <sping@gentoo.org>
    Package-Manager: Portage-2.3.78, Repoman-2.3.16

 media-libs/gegl/gegl-0.4.16.ebuild | 2 +-
 media-libs/gegl/gegl-0.4.18.ebuild | 2 +-
 media-libs/gegl/gegl-9999.ebuild   | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)
Comment 5 Mart Raudsepp gentoo-dev 2019-11-03 14:25:54 UTC
It's standard amongst GNOME packages to default enable this in all cases. In this case it looks like just libmypaint[introspection] uses it, and that doesn't default enable it either yet, and actually has no consumers itself. So meanwhile it seems fine to not default enable this. I suggest default enabling the lot once there's any hard or default requirements for it, though.