Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 698722 - sys-fs/lxcfs should create /var/lib/lxcfs on install
Summary: sys-fs/lxcfs should create /var/lib/lxcfs on install
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Erik Mackdanz
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2019-10-28 08:01 UTC by Hoess
Modified: 2020-05-16 14:45 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Hoess 2019-10-28 08:01:50 UTC
sys-fs/lxcfs should create empty /var/lib/lxcfs on install, otherwise the service won't start.
Comment 1 Larry the Git Cow gentoo-dev 2020-05-15 05:20:53 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=90b61eec7b3a7507c25d743cc6e769f9d116b05b

commit 90b61eec7b3a7507c25d743cc6e769f9d116b05b
Author:     Joonas Niilola <juippis@gentoo.org>
AuthorDate: 2020-05-14 15:51:05 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2020-05-15 05:20:29 +0000

    sys-fs/lxcfs: bump to 4.0.3
    
    Closes: https://bugs.gentoo.org/698722
    Closes: https://bugs.gentoo.org/712802
    
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 sys-fs/lxcfs/Manifest                |  1 +
 sys-fs/lxcfs/files/lxcfs-4.0.0.confd |  7 +++++
 sys-fs/lxcfs/files/lxcfs-4.0.0.initd | 26 ++++++++++++++++++
 sys-fs/lxcfs/lxcfs-4.0.3.ebuild      | 53 ++++++++++++++++++++++++++++++++++++
 4 files changed, 87 insertions(+)
Comment 2 Larry the Git Cow gentoo-dev 2020-05-15 13:55:53 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=659dc346ebd68da08b7d774d3c1b17c1e12526f9

commit 659dc346ebd68da08b7d774d3c1b17c1e12526f9
Author:     Joonas Niilola <juippis@gentoo.org>
AuthorDate: 2020-05-15 13:55:27 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2020-05-15 13:55:43 +0000

    sys-fs/lxcfs: temporarily disable keepdir due to weird file collisions
    
    Bug: https://bugs.gentoo.org/698722
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 sys-fs/lxcfs/lxcfs-4.0.3.ebuild | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)
Comment 3 Joonas Niilola gentoo-dev 2020-05-15 13:57:41 UTC
I really don't know what's happening. My main desktop works happily with keepdir, but my test system is absolutely shitting the bed with all kinds of file collissions possibly due to it. 

Needs more investigating for now.
Comment 4 Hoess 2020-05-15 18:17:10 UTC
Since I was curious, I just did also some tests with the previous version of 4.0.3 which was using the "keepdir" method on my homemachine:

- emerge -C lxcfs && rm -rf /var/lib/lxcfs
- emerged version 3.0.3 -> good: /var/lib/lxcfs exists after emerge
- start lxcfs-service
- emerged version 4.0.3/keepdir -> aborted error cant write to /var/lib/lxcfs
- stopped lxcfs-service
- emerged version 4.0.3/keepdir -> emerged but file collision warnings
- emerged -C lxcfs && rm -rf /var/lib/lxcfs
- emerged version 4.0.3/keepdir -> success no errors

(The current 4.0.3 with creating /var/lib/lxcfs in /etc/init.d/lxcfs works
just fine here)
Comment 5 Joonas Niilola gentoo-dev 2020-05-16 05:39:58 UTC
(In reply to Hoess from comment #4)
> 
> (The current 4.0.3 with creating /var/lib/lxcfs in /etc/init.d/lxcfs works
> just fine here)

You mean the current ebuild that has 
  # Getting weird file collisions, 
  # keepdir /var/lib/lxcfs
  # fowners -R root:lxd /var/lib/lxcfs

these lines commented? It seems to be working for me too. I'm tempted to leave them as-is.

If that's ok, we can close the bug perhaps?
Comment 6 Hoess 2020-05-16 11:44:54 UTC

>You mean the current ebuild that has 
>  # Getting weird file collisions, 
>  # keepdir /var/lib/lxcfs
>  # fowners -R root:lxd /var/lib/lxcfs
>
>these lines commented? It seems to be working for me too. I'm tempted to >leave them as-is.
>
>If that's ok, we can close the bug perhaps?

Yes, this version works OK with new installs and update installs. So I also think this bug can be closed.