When using mirrorselect -i, the program does not update /etc/portage/make.conf if there is no GENTOO_MIRRORS set there and hangs. Reproducible: Always Steps to Reproduce: 1. have /etc/portage/make.conf without any occurence of GENTOO_MIRRORS 2. run mirrorselect -i 3. select a mirror 4. the following will be printed and the program hangs * Modifying /etc/portage/make.conf with new mirrors... Reading make.conf Moving to /etc/portage/make.conf.backup Actual Results: /etc/portage/make.conf is moved to /etc/portage/make.conf.backup and that is all. Expected Results: mirrorselect should add the line with GENTOO_MIRRORS="..." if there is none yet in /etc/portage/make.conf If I add GENTOO_MIRRORS="" to /etc/portage/make.conf before running mirrorselect, everything works fine.
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/proj/mirrorselect.git/commit/?id=e69ec2d046626fa2079d460aab469d04256182cd commit e69ec2d046626fa2079d460aab469d04256182cd Author: Zac Medico <zmedico@gentoo.org> AuthorDate: 2019-10-24 19:52:10 +0000 Commit: Zac Medico <zmedico@gentoo.org> CommitDate: 2019-10-24 19:53:57 +0000 write_make_conf: fix infinite loop (bug 698470) Fixes: 42238f4ff13a ("write_make_conf: support multi-line GENTOO_MIRRORS (bug 543814)") Bug: https://bugs.gentoo.org/698470 Signed-off-by: Zac Medico <zmedico@gentoo.org> mirrorselect/configs.py | 2 ++ tests/test_write_make_conf.py | 1 + 2 files changed, 3 insertions(+)
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=2c75495f03df28b28600c4c27e6c34067bb4fbd6 commit 2c75495f03df28b28600c4c27e6c34067bb4fbd6 Author: Zac Medico <zmedico@gentoo.org> AuthorDate: 2019-10-24 20:05:06 +0000 Commit: Zac Medico <zmedico@gentoo.org> CommitDate: 2019-10-24 20:06:28 +0000 app-portage/mirrorselect: 2.2.6-r1 revbump for bug 698470 Closes: https://bugs.gentoo.org/698470 Package-Manager: Portage-2.3.78, Repoman-2.3.17 Signed-off-by: Zac Medico <zmedico@gentoo.org> .../{mirrorselect-2.2.6.ebuild => mirrorselect-2.2.6-r1.ebuild} | 4 ++++ 1 file changed, 4 insertions(+)
Thanks!
Created attachment 593860 [details] mirrorselect-overwritten Thank you for your quick fix. Now it works. Unfortunately, with your change, the info text modifying make.conf is written over the dialog after the mirror is selected, see the attached screenshot; it was written nicely under the dialog before.
Created attachment 593862 [details] mirrorselect-correct This was the correct behaviour before the change.
Strange - now I cannot reproduce the incorrect behaviour - guess something was wrong with my terminal. Sorry!
No, the overwriting of the dialog is really a bug. Filed it as a new bug 698528.
