Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 698456 - sys-apps/dstat-0.7.4 does not install binary
Summary: sys-apps/dstat-0.7.4 does not install binary
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Paul Healy
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2019-10-24 14:16 UTC by Tetja Rediske
Modified: 2019-10-24 20:39 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Tetja Rediske 2019-10-24 14:16:41 UTC
No binary gets installed.

I suspect it is a missing install in src_install emake command.

Reproducible: Always

Steps to Reproduce:
1. emerge dstat
2.
3.
Actual Results:  
No dstat binary

Expected Results:  
dstat binary installed
Comment 1 Jeroen Roovers (RETIRED) gentoo-dev 2019-10-24 16:38:46 UTC
commit 33d249d4b12616985c6b3b67d484e989827de983
Author: Guilherme Amadio <amadio@gentoo.org>
Date:   Tue Oct 22 10:18:33 2019 +0200

    sys-apps/dstat: fix src_install() for prefix

    Using 'default' as done in the version bump made files get
    installed outside the prefix, directly into /usr.

    Package-Manager: Portage-2.3.78, Repoman-2.3.17
    Signed-off-by: Guilherme Amadio <amadio@gentoo.org>

diff --git a/sys-apps/dstat/dstat-0.7.4.ebuild b/sys-apps/dstat/dstat-0.7.4.ebuild
index 66bbf59ec4a..491efbdb32a 100644
--- a/sys-apps/dstat/dstat-0.7.4.ebuild
+++ b/sys-apps/dstat/dstat-0.7.4.ebuild
@@ -40,7 +40,8 @@ src_prepare() {
 }

 src_install() {
-       default
+       emake DESTDIR="${ED}"
+       einstalldocs

        if use examples; then
                dodoc examples/{mstat,read}.py
Comment 2 Larry the Git Cow gentoo-dev 2019-10-24 19:53:09 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c4a088199cd63467f2d0e607735fbecbec761229

commit c4a088199cd63467f2d0e607735fbecbec761229
Author:     Piotr Karbowski <slashbeast@gentoo.org>
AuthorDate: 2019-10-24 19:51:52 +0000
Commit:     Piotr Karbowski <slashbeast@gentoo.org>
CommitDate: 2019-10-24 19:52:59 +0000

    sys-apps/dstat: 0.7.4: add missing install target.
    
    Fixes broken src_install() introduced in commit
    33d249d4b12616985c6b3b67d484e989827de983.
    
    Closes: https://bugs.gentoo.org/698456
    Package-Manager: Portage-2.3.78, Repoman-2.3.17
    Signed-off-by: Piotr Karbowski <slashbeast@gentoo.org>

 sys-apps/dstat/dstat-0.7.4.ebuild | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 3 Guilherme Amadio gentoo-dev 2019-10-24 20:39:58 UTC
Oops, sorry about that.