Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 698408 - app-emulation/spice-vdagent-0.19.0-r1 should not run eautoreconf
Summary: app-emulation/spice-vdagent-0.19.0-r1 should not run eautoreconf
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Virtualization Team
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2019-10-23 18:58 UTC by Chris Mayo
Modified: 2020-03-14 20:57 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Mayo 2019-10-23 18:58:35 UTC
I think on upgrade to version 0.19.0 patchset from SRC_URI and PATCHES variable were removed but left behind were:

inherit autotools

src_prepare() {
	default
	eautoreconf
}
Comment 1 Chris Mayo 2019-10-23 19:06:07 UTC
Looking at it there is probably more, PATCHSET and MY_P aren't needed either. In total:

@@ -3,20 +3,16 @@
 
 EAPI=7
 
-inherit autotools linux-info
-
-MY_P="${P/_*/}"
-PATCHSET="${P/*_p/}"
+inherit linux-info
 
 DESCRIPTION="SPICE VD Linux Guest Agent"
 HOMEPAGE="https://www.spice-space.org/"
-SRC_URI="https://www.spice-space.org/download/releases/${MY_P}.tar.bz2"
+SRC_URI="https://www.spice-space.org/download/releases/${P}.tar.bz2"
 
 LICENSE="LGPL-2.1"
 SLOT="0"
 KEYWORDS="~amd64 ~x86"
 IUSE="consolekit gtk selinux systemd"
-S="${WORKDIR}/${MY_P}"
 
 CDEPEND="
 	>=app-emulation/spice-protocol-0.14.0
@@ -38,11 +34,6 @@
 CONFIG_CHECK="~INPUT_UINPUT ~VIRTIO_CONSOLE"
 ERROR_INPUT_UINPUT="User level input support (INPUT_UINPUT) is required"
 ERROR_VIRTIO_CONSOLE="VirtIO console/serial device support (VIRTIO_CONSOLE) is required"
-
-src_prepare() {
-	default
-	eautoreconf
-}
 
 src_configure() {
 	local opt=()
Comment 2 Larry the Git Cow gentoo-dev 2020-03-14 20:57:01 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=de5a948afc2db645757f0380f46fa2e155544eac

commit de5a948afc2db645757f0380f46fa2e155544eac
Author:     Matthias Maier <tamiko@gentoo.org>
AuthorDate: 2020-03-14 20:56:22 +0000
Commit:     Matthias Maier <tamiko@gentoo.org>
CommitDate: 2020-03-14 20:56:22 +0000

    app-emulation/spice-vdagent: ebuild maintenance
    
    Closes: https://bugs.gentoo.org/698408
    Package-Manager: Portage-2.3.93, Repoman-2.3.20
    Signed-off-by: Matthias Maier <tamiko@gentoo.org>

 app-emulation/spice-vdagent/spice-vdagent-0.19.0-r1.ebuild | 13 ++-----------
 1 file changed, 2 insertions(+), 11 deletions(-)