Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 698130 - sys-devel/gcc-7.4.0-r2 - * Failed Patch: 23_all-pgo.patch !
Summary: sys-devel/gcc-7.4.0-r2 - * Failed Patch: 23_all-pgo.patch !
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Toolchain Maintainers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-10-20 16:49 UTC by Samuel Bernardo
Modified: 2019-10-20 20:42 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build log and 23_all-pgo.patch.out (gcc-7.4.0.zip,2.42 KB, application/zip)
2019-10-20 16:49 UTC, Samuel Bernardo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Samuel Bernardo 2019-10-20 16:49:59 UTC
Created attachment 593426 [details]
build log and 23_all-pgo.patch.out

Failed to compile gcc 7.4.0 with profile 17.1
Comment 1 Sergei Trofimovich (RETIRED) gentoo-dev 2019-10-20 20:34:12 UTC
Oh, wow! That is a fallot of https://gitweb.gentoo.org/repo/gentoo.git/commit/eclass/toolchain.eclass?id=bd758f25a82460f6e7011314f9fb7923864e9e1e

Due to wrong file name '23_all-pgo.patch' it used not to be applied at all. The correct name should have been '23_all_pgo.patch'. I'll drop the patch from the patchset.
Comment 2 Larry the Git Cow gentoo-dev 2019-10-20 20:41:24 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e751f9bd6ff7c6571884ad35902db632c7aaeced

commit e751f9bd6ff7c6571884ad35902db632c7aaeced
Author:     Sergei Trofimovich <slyfox@gentoo.org>
AuthorDate: 2019-10-20 20:41:07 +0000
Commit:     Sergei Trofimovich <slyfox@gentoo.org>
CommitDate: 2019-10-20 20:41:18 +0000

    sys-devel/gcc: 7.4.0: drop unappliable 23_all-pgo.patch
    
    23_all-pgo.patch used not to apply due to mis-named patch.
    
    commit bd758f25a8246 ("toolchain.eclass: isolate 'epatch'
    into 'tc_apply_patches'") started applying all patches
    unconditionall and exposed the problem.
    
    The change reverts back to previous patches (misses exactly
    that patch).
    
    Reported-by: Samuel Bernardo
    Closes: https://bugs.gentoo.org/698130
    Package-Manager: Portage-2.3.76, Repoman-2.3.17
    Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>

 sys-devel/gcc/Manifest            | 1 -
 sys-devel/gcc/gcc-7.4.0-r2.ebuild | 2 +-
 2 files changed, 1 insertion(+), 2 deletions(-)
Comment 3 Larry the Git Cow gentoo-dev 2019-10-20 20:42:45 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/gcc-patches.git/commit/?id=7ad3c1ca7c0726c3f3ceebf562bb9d1379c52223

commit 7ad3c1ca7c0726c3f3ceebf562bb9d1379c52223
Author:     Sergei Trofimovich <slyfox@gentoo.org>
AuthorDate: 2019-10-20 20:41:56 +0000
Commit:     Sergei Trofimovich <slyfox@gentoo.org>
CommitDate: 2019-10-20 20:41:56 +0000

    7.4..0: drop unappliable 23_all-pgo.patch
    
    Repored-by: Samuel Bernardo
    Bug: https://bugs.gentoo.org/698130
    Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>

 7.4.0/gentoo/23_all-pgo.patch | 59 -------------------------------------------
 7.4.0/gentoo/README.history   |  3 +++
 2 files changed, 3 insertions(+), 59 deletions(-)