Please bump dev-db/percona-server to 8.0.18. Generic dev-db/mysql already bumped to 8.0.18, so it will not be hard to port all patches to percona, i think... Reproducible: Always
There is no percona-server-8.0.18 yet and previous percona-server-8.0.16 doesn't build, https://jira.percona.com/browse/PS-5873
Created attachment 594344 [details, diff] Fix i_s_innodb_changed_pages structure and make ebuild compilable Field types and ordering in i_s_innodb_changed_pages struct don't meet declaration order in st_mysql_plugin.
With this fix/patch, I can compile percona-server-8.0.16.7 without any issues with sys-devel/gcc-9.2.0-r1
Created attachment 594346 [details, diff] Based on Michal Brngal's patch fields ordering fix with code style Code style uses nullptr not NULL and patch shouldn't change lines of code what not needed to fix the issue
(In reply to Nikolay from comment #4) > Created attachment 594346 [details, diff] [details, diff] > Based on Michal Brngal's patch fields ordering fix with code style > > Code style uses nullptr not NULL and patch shouldn't change lines of code > what not needed to fix the issue All other structs, e.g. i_s_innodb_ft_deleted are using NULL and not nullptr. That's why I used NULL instead of nullptr.
But it's not patch purpose :) To fix style :)
Thanks, looks good for me. I shared your patch with upstream and will now run test suite.
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/proj/mysql-extras.git/commit/?id=e347577568d429b6896a39ba59e7eff200241fb0 commit e347577568d429b6896a39ba59e7eff200241fb0 Author: Thomas Deutschmann <whissi@gentoo.org> AuthorDate: 2019-10-30 01:00:34 +0000 Commit: Thomas Deutschmann <whissi@gentoo.org> CommitDate: 2019-10-30 01:00:34 +0000 Add 20038_all_percona-server-8.0.16-PS-5873.patch Bug: https://bugs.gentoo.org/697980 Signed-off-by: Thomas Deutschmann <whissi@gentoo.org> 20038_all_percona-server-8.0.16-PS-5873.patch | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+)
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=1675444a6cc3f7b25911b91bf4f9076a08b5ec63 commit 1675444a6cc3f7b25911b91bf4f9076a08b5ec63 Author: Thomas Deutschmann <whissi@gentoo.org> AuthorDate: 2019-10-31 01:38:08 +0000 Commit: Thomas Deutschmann <whissi@gentoo.org> CommitDate: 2019-10-31 01:41:22 +0000 dev-db/percona-server: bump to v8.0.17-8 Closes: https://bugs.gentoo.org/697980 Closes: https://bugs.gentoo.org/679266 Package-Manager: Portage-2.3.78, Repoman-2.3.17 Signed-off-by: Thomas Deutschmann <whissi@gentoo.org> dev-db/percona-server/Manifest | 3 + dev-db/percona-server/metadata.xml | 1 + .../percona-server/percona-server-8.0.17.8.ebuild | 1128 ++++++++++++++++++++ 3 files changed, 1132 insertions(+)
You’re Breathtaking!
