Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 697900 - app-emulation/dosemu-1.4.1_pre20130107-r5: Problems with dependencies
Summary: app-emulation/dosemu-1.4.1_pre20130107-r5: Problems with dependencies
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: Normal normal (vote)
Assignee: Sergei Trofimovich (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-10-17 00:26 UTC by Arfrever Frehtes Taifersar Arahesis
Modified: 2019-10-30 22:21 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch (dosemu.patch,2.70 KB, patch)
2019-10-17 00:48 UTC, Arfrever Frehtes Taifersar Arahesis
Details | Diff
Patch (dosemu.patch,2.74 KB, patch)
2019-10-17 00:57 UTC, Arfrever Frehtes Taifersar Arahesis
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Arfrever Frehtes Taifersar Arahesis 2019-10-17 00:26:11 UTC
bdftopcf executable (from x11-apps/bdftopcf) is used only at build time.
With EAPI="7", x11-apps/bdftopcf should be only in BDEPEND.


mkfontdir executable (from >=x11-apps/mkfontscale-1.2.0) is used only at build time.
With EAPI="7", >=x11-apps/mkfontscale-1.2.0 should be only in BDEPEND.


x11-apps/xlsfonts is not used at all.


x11-apps/xset seems to be used only at run time, so it is not needed in BDEPEND or DEPEND.
There are some calls to xset in src/plugin/X/X_font.c:
https://sourceforge.net/p/dosemu/code/ci/master/tree/src/plugin/X/X_font.c#l214


libsndfile support does not exist yet.
With USE="sndfile", /usr/lib64/dosemu/libplugin_sndfile.so would be installed.
Build system passes -lsndfile when creating libplugin_sndfile.so, but with -Wl,--as-needed libplugin_sndfile.so is not linked against any library.
https://sourceforge.net/p/dosemu/code/ci/master/tree/src/plugin/sndfile/snd_o_wav.c shows:
#if 0 /* NOT USED YET */
Comment 1 Arfrever Frehtes Taifersar Arahesis 2019-10-17 00:34:11 UTC
x11-libs/libXau is not used at all.


x11-libs/libXdmcp is not used at all.
Comment 2 Arfrever Frehtes Taifersar Arahesis 2019-10-17 00:48:48 UTC
Created attachment 592964 [details, diff]
Patch
Comment 3 Arfrever Frehtes Taifersar Arahesis 2019-10-17 00:57:37 UTC
Created attachment 592966 [details, diff]
Patch
Comment 4 Sergei Trofimovich (RETIRED) gentoo-dev 2019-10-17 06:33:51 UTC
(In reply to Arfrever Frehtes Taifersar Arahesis from comment #3)
> Created attachment 592966 [details, diff] [details, diff]
> Patch

Please provide a summary of changes in the patch commit messages itself.
Bonus points for pulling unrelated changes into separate commits.
Comment 5 Larry the Git Cow gentoo-dev 2019-10-30 22:21:05 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=47928b5c235ec1d105d64dde8d233df612beaa7c

commit 47928b5c235ec1d105d64dde8d233df612beaa7c
Author:     Arfrever Frehtes Taifersar Arahesis <Arfrever@Apache.Org>
AuthorDate: 2019-10-17 00:46:08 +0000
Commit:     Sergei Trofimovich <slyfox@gentoo.org>
CommitDate: 2019-10-30 22:19:48 +0000

    app-emulation/dosemu: Fix dependencies. Drop "sndfile" USE flag. Use EAPI="7".
    
    Fixes: https://bugs.gentoo.org/697900
    Signed-off-by: Arfrever Frehtes Taifersar Arahesis <Arfrever@Apache.Org>
    Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>

 .../dosemu/dosemu-1.4.1_pre20130107-r5.ebuild      | 51 ++++++++++++----------
 1 file changed, 27 insertions(+), 24 deletions(-)