Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 697854 - x11-themes/kvantum-0.12.1 version bump
Summary: x11-themes/kvantum-0.12.1 version bump
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Ian Whyman (thev00d00) (RETIRED)
URL: https://github.com/tsujan/Kvantum/rel...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-10-16 14:00 UTC by Andreas Sturmlechner
Modified: 2019-12-08 19:23 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Sturmlechner gentoo-dev 2019-10-16 14:00:15 UTC
Gentoo package is several releases with many fixes behind.

Plus:
- I doubt the package works without dev-qt/qtcore:5 (missing dependency)
- DESCRIPTION outdated (no more Qt4, KDE is a community, not a desktop)
- A quick look CMakeLists.txt hints at more missing Qt dependencies such as for translations
- Check if major Qt upgrades don't necessitate a rebuild of kvantum (#kde reports that
Comment 1 Larry the Git Cow gentoo-dev 2019-10-28 16:33:29 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f485916b1e3701c5cb4ad9dd69132e27aa79f41c

commit f485916b1e3701c5cb4ad9dd69132e27aa79f41c
Author:     Ian Whyman <thev00d00@gentoo.org>
AuthorDate: 2019-10-28 16:32:23 +0000
Commit:     Ian Whyman <thev00d00@gentoo.org>
CommitDate: 2019-10-28 16:33:09 +0000

    x11-themes/kvantum: Version Bump
    
    Closes: https://bugs.gentoo.org/697854
    Package-Manager: Portage-2.3.77, Repoman-2.3.17
    Signed-off-by: Ian Whyman <thev00d00@gentoo.org>

 x11-themes/kvantum/Manifest                                           | 2 +-
 .../kvantum/{kvantum-0.11.0-r1.ebuild => kvantum-0.12.1.ebuild}       | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)
Comment 2 Andreas Sturmlechner gentoo-dev 2019-10-28 17:49:42 UTC
Dependencies were not fixed.
Comment 3 Ian Whyman (thev00d00) (RETIRED) gentoo-dev 2019-10-28 21:31:03 UTC
Hi Andreas,

Are you saying you have found a problem with the dependencies that prevents the package from working or just a theoretical issue?

If you do have such a problem that prevents you installing the package, please raise it as a separate bug, as this was a version bump request, albeit with some helpful comments.

Thanks!
Comment 4 Andreas Sturmlechner gentoo-dev 2019-10-28 21:42:23 UTC
(In reply to Ian Whyman (thev00d00) from comment #3)
> Are you saying you have found a problem with the dependencies that prevents
> the package from working or just a theoretical issue?

Are you saying you practice dependency discovery through trial and error? Because I'm afraid that is not how it works according to developer quiz. Proper dependencies are not a 'theoretical issue'.

I don't use kvantum myself, but I still took the time after reading reports in #kde how this package somehow was always broken [on other distros] after some updates, and I simply got curious what we had in Gentoo. When I am able to find missing deps with a cursory glance at the build system I would expect you to run at least a minor effort to do the same.
Comment 5 Andreas Sturmlechner gentoo-dev 2019-10-28 21:49:08 UTC
Sorry about the truncated last sentence in the first comment btw, it was meant to say that #kde reports could suggest this packages is using private headers of either Qt or KDE Frameworks that are prone to break the package on upgrades and cause runtime issues for users.

Re DESCRIPTION, please use the term 'Plasma' or 'KDE Plasma' when referring to the desktop environment, we try to be nice to upstream.
Comment 6 Andreas Sturmlechner gentoo-dev 2019-10-28 22:04:56 UTC
(In reply to Andreas Sturmlechner from comment #5)
> Sorry about the truncated last sentence in the first comment btw, it was
> meant to say that #kde reports could suggest this packages is using private
> headers of either Qt or KDE Frameworks that are prone to break the package
> on upgrades and cause runtime issues for users.
I found use of QtPlatformHeaders/QXcbWindowFunctions inside Kvantum/style/Kvantum.cpp which means the package must trigger rebuild on dev-qt/qtgui subslot bumps.
Comment 7 Ian Whyman (thev00d00) (RETIRED) gentoo-dev 2019-10-29 21:22:51 UTC
(In reply to Andreas Sturmlechner from comment #6)
> (In reply to Andreas Sturmlechner from comment #5)
> > Sorry about the truncated last sentence in the first comment btw, it was
> > meant to say that #kde reports could suggest this packages is using private
> > headers of either Qt or KDE Frameworks that are prone to break the package
> > on upgrades and cause runtime issues for users.
> I found use of QtPlatformHeaders/QXcbWindowFunctions inside
> Kvantum/style/Kvantum.cpp which means the package must trigger rebuild on
> dev-qt/qtgui subslot bumps.

Thanks for the info, when I next get Gentoo time I will take a look.