Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 697808 - games-fps/eduke32 USE=timidity should not depend on media-sound/timidity-freepats
Summary: games-fps/eduke32 USE=timidity should not depend on media-sound/timidity-free...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Conrad Kostecki
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2019-10-16 05:42 UTC by Adam Purkrt
Modified: 2019-10-16 21:54 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Purkrt 2019-10-16 05:42:36 UTC
On line 65 of eduke32-20190919.8133.ebuild there is

    timidity? ( media-sound/timidity-freepats )

This installs media-sound/timidity-freepats even if you already have media-sound/timidity-eawpatches installed. Imo the line should be removed - there is already a dependence on one of the patch sets at line 49 of timidity++ ebuild

PDEPEND="|| ( media-sound/timidity-eawpatches media-sound/timidity-freepats )"

Reproducible: Always

Steps to Reproduce:
1. have timidity++ installed with media-sound/timidity-eawpatches
2. install games-fps/eduke32
Actual Results:  
It pulls in media-sound/timidity-freepats.
Comment 1 Conrad Kostecki gentoo-dev 2019-10-16 08:13:24 UTC
Thanks. Will change the deps to timidity++ directly.
Comment 2 Larry the Git Cow gentoo-dev 2019-10-16 21:54:34 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3c1315cd32bf21526dec379e956b5e7df705a366

commit 3c1315cd32bf21526dec379e956b5e7df705a366
Author:     Conrad Kostecki <conrad@kostecki.com>
AuthorDate: 2019-10-16 08:00:44 +0000
Commit:     James Le Cuirot <chewi@gentoo.org>
CommitDate: 2019-10-16 21:53:06 +0000

    games-fps/eduke32: fix timidity deps
    
    Instead of depending on a specific timidity patchset,
    the deps should be changed to depend on timidity itself,
    as it already depends on all patchsets.
    
    Closes: https://bugs.gentoo.org/697808
    Package-Manager: Portage-2.3.76, Repoman-2.3.17
    Signed-off-by: Conrad Kostecki <conrad@kostecki.com>
    Closes: https://github.com/gentoo/gentoo/pull/13316
    Signed-off-by: James Le Cuirot <chewi@gentoo.org>

 games-fps/eduke32/eduke32-20190919.8133-r1.ebuild | 255 ++++++++++++++++++++++
 1 file changed, 255 insertions(+)