Created attachment 592678 [details] EAPI=7 for pam_require Took a stab at EAPI=7 for pam_require, attaching it
@juippis, would you find a minute to take a look?
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=7a490c4c90bafb163736fe322452804833b4152a commit 7a490c4c90bafb163736fe322452804833b4152a Author: Joonas Niilola <juippis@gentoo.org> AuthorDate: 2019-11-06 04:13:09 +0000 Commit: Joonas Niilola <juippis@gentoo.org> CommitDate: 2019-11-06 04:13:09 +0000 package.mask: remove a WIP mask Bug: https://bugs.gentoo.org/697710 Signed-off-by: Joonas Niilola <juippis@gentoo.org> profiles/package.mask | 1 - 1 file changed, 1 deletion(-)
Comment on attachment 592678 [details] EAPI=7 for pam_require Thanks for your contribution. We'd prefer if you became the maintainer for this package (it seems like an easy one to maintain). Your ebuild seems to work, but here are some stylistic changes "needed" to get it merged. ># Copyright 1999-2019 Gentoo Authors ># Distributed under the terms of the GNU General Public License v2 > >EAPI=7 > >inherit eutils pam eutils seems useless here. > >DESCRIPTION="Allows you to require a special group or user to access a service" >HOMEPAGE="http://www.splitbrain.org/projects/pam_require" use https:// whenever available. >SRC_URI="http://www.splitbrain.org/_media/projects/pamrequire/${P}.tgz" https:// here too. >LICENSE="GPL-2" This seems wrong, it's GPL-2+ >SLOT="0" >KEYWORDS="~amd64 ~ia64 ~ppc ~x86" >IUSE="" > >DEPEND="sys-libs/pam" > >S=${WORKDIR}/${P/_/-} > >src_install() { > dopammod "${S}/pam_require.so" you can just call dopammod pam_require.so here. > > dodoc AUTHORS ChangeLog NEWS README 'einstalldocs' should take care of these by default, so switch to that. >} Rest looks good. You can edit metadata.xml adding yourself + proxy-maint project there, or we can do it if you wish. https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers/User_Guide#Proxied_maintainer_in_metadata.xml
Created attachment 595116 [details] pam_require-0.7-r1.ebuild Fixed review comments
Created attachment 595118 [details] metadata.xml Added me and proxy-maintainer
(In reply to Joonas Niilola from comment #3) .... > > Rest looks good. You can edit metadata.xml adding yourself + proxy-maint > project there, or we can do it if you wish. > https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers/ > User_Guide#Proxied_maintainer_in_metadata.xml Did what you suggested. I will be a proxy maintaner for this package, thanks
(In reply to Joakim Tjernlund from comment #6) > (In reply to Joonas Niilola from comment #3) > .... > > > > Rest looks good. You can edit metadata.xml adding yourself + proxy-maint > > project there, or we can do it if you wish. > > https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers/ > > User_Guide#Proxied_maintainer_in_metadata.xml > > Did what you suggested. I will be a proxy maintaner for this package, thanks Oh, added an RDEPEND too
Thanks, it's good. Welcome aboard! This probably won't have to receive any updates, but please if it does, use Github and make a pull request there. Also please see https://www.gentoo.org/glep/glep-0076.html#certificate-of-origin that I included for you in this one. https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers/User_Guide#GitHub_Pull_Requests
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=163664374a66ab9e502b13d7baf6d665b9c598f1 commit 163664374a66ab9e502b13d7baf6d665b9c598f1 Author: Joakim Tjernlund <joakim.tjernlund@infinera.com> AuthorDate: 2019-11-06 14:27:34 +0000 Commit: Joonas Niilola <juippis@gentoo.org> CommitDate: 2019-11-06 14:35:32 +0000 sys-auth/pam_require: EAPI-7 revbump Closes: https://bugs.gentoo.org/697710 Signed-off-by: Joakim Tjernlund <joakim.tjernlund@infinera.com> Signed-off-by: Joonas Niilola <juippis@gentoo.org> sys-auth/pam_require/pam_require-0.7-r1.ebuild | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+) Additionally, it has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=71a20dc79042472854f60b156ae3fb294dc022d6 commit 71a20dc79042472854f60b156ae3fb294dc022d6 Author: Joonas Niilola <juippis@gentoo.org> AuthorDate: 2019-11-06 14:30:43 +0000 Commit: Joonas Niilola <juippis@gentoo.org> CommitDate: 2019-11-06 14:35:33 +0000 sys-auth/pam_require: remove old EAPI-0 ebuild Bug: https://bugs.gentoo.org/697710 Package-Manager: Portage-2.3.76, Repoman-2.3.17 Signed-off-by: Joonas Niilola <juippis@gentoo.org> sys-auth/pam_require/pam_require-0.7.ebuild | 29 ----------------------------- 1 file changed, 29 deletions(-)
