Bug 697480 – app-backup/snapper : add bash-completion support

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Xu Weiping 2019-10-11 07:00:53 UTC]

Created attachment 592470 [details]
snapper-0.8.3-r1.ebuild

I find the snapper debian package has bash-completion. So I move it to gentoo.
Bash-completion is helpful.
Origin source: https://packages.debian.org/sid/amd64/snapper/download

[Comment 1 Xu Weiping 2019-10-11 07:01:49 UTC]

Created attachment 592472 [details]
snapper.bash

[Comment 2 Xu Weiping 2019-10-11 07:05:10 UTC]

Comment on attachment 592470 [details]
snapper-0.8.3-r1.ebuild

># Copyright 1999-2019 Gentoo Authors
># Distributed under the terms of the GNU General Public License v2
>
>EAPI=7
>
>inherit systemd bash-completion-r1
>
>DESCRIPTION="Command-line program for btrfs and lvm snapshot management"
>HOMEPAGE="http://snapper.io/"
>SRC_URI="ftp://ftp.suse.com/pub/projects/snapper/${P}.tar.bz2"
>
>LICENSE="GPL-2"
>SLOT="0"
>KEYWORDS="~amd64 ~x86"
>IUSE="lvm pam xattr"
>
>RDEPEND="dev-libs/boost:=[threads]
>	dev-libs/libxml2
>	dev-libs/icu:=
>	sys-apps/acl
>	sys-apps/dbus
>	sys-apps/util-linux
>	>=sys-fs/btrfs-progs-3.17.1
>	sys-libs/zlib
>	virtual/libintl
>	lvm? ( sys-fs/lvm2 )
>	pam? ( sys-libs/pam )
>	xattr? ( sys-apps/attr )"
>
>DEPEND="${RDEPEND}
>	sys-devel/gettext
>	virtual/pkgconfig"
>
>PATCHES=(
>	"${FILESDIR}"/cron-confd.patch
>)
>
>src_prepare() {
>	default
>
>	sed -e "s,/usr/lib/systemd/system,$(systemd_get_systemunitdir),g" \
>		-i data/Makefile.* \
>		|| die "Failed to fix systemd services and timers installation path"
>}
>
>src_configure() {
>	# ext4 code does not work anymore
>	# snapper does not build without btrfs
>	local myeconfargs=(
>		--with-conf="/etc/conf.d"
>		--docdir="/usr/share/doc/${PF}"
>		--disable-zypp
>		--enable-rollback
>		--disable-ext4
>		--enable-btrfs
>		$(use_enable lvm)
>		$(use_enable pam)
>		$(use_enable xattr xattrs)
>	)
>
>	econf "${myeconfargs[@]}"
>}
>
>src_install() {
>	default
>	# Existing configuration file required to function
>	newconfd data/sysconfig.snapper snapper
>	find "${D}" -name '*.la' -delete || die
>    newbashcomp ${PN}.bash ${PN}
>}
>
>pkg_postinst() {
>	elog "In order to use Snapper, you need to set up"
>	elog "at least one config first. To do this, run:"
>	elog "snapper create-config <subvolume>"
>	elog "For more information, see man (8) snapper or"
>	elog "http://snapper.io/documentation.html"
>}

[Comment 3 Larry the Git Cow 2019-10-16 03:42:19 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=52932ec67c365fa358d893e2af8353aeed186982

commit 52932ec67c365fa358d893e2af8353aeed186982
Author:     Yixun Lan <[e-mail]>
AuthorDate: 2019-10-16 03:22:48 +0000
Commit:     Yixun Lan <[e-mail]>
CommitDate: 2019-10-16 03:22:48 +0000

    app-backup/snapper: version bump 0.8.4, add bash-completion support
    
    In this version, we also add bash-completion support
    But it's rather better to push bash-completion support to upstream,
    instead of maintaining it downstream.
    
    thanks 'Xu Weiping' for the contribution
    
    Closes: https://bugs.gentoo.org/697480
    Package-Manager: Portage-2.3.76, Repoman-2.3.17
    Signed-off-by: Yixun Lan <[e-mail]>

 app-backup/snapper/Manifest             |   1 +
 app-backup/snapper/files/snapper.bash   | 200 ++++++++++++++++++++++++++++++++
 app-backup/snapper/snapper-0.8.4.ebuild |  78 +++++++++++++
 3 files changed, 279 insertions(+)

[Comment 4 Yixun Lan 2019-10-16 03:59:57 UTC]

hi Weiping, btw, I've dropped the USE="bash-completion" flag explicitly, it's not necessary for trivial files, please consult [1], rule 4

[1] https://wiki.gentoo.org/wiki/Bash/Installing_completion_files