Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 696248 - app-dicts/dictd-devils, app-dicts/dictd-dicts, app-dicts/dictd-elements, app-dicts/dictd-foldoc, app-dicts/dictd-gazetteer, app-dicts/dictd-jargon, app-dicts/dictd-misc, app-dicts/dictd-web1913: removal
Summary: app-dicts/dictd-devils, app-dicts/dictd-dicts, app-dicts/dictd-elements, app-...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Deadline: 2019-11-03
Assignee: No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it
URL:
Whiteboard:
Keywords: PMASKED, PullRequest
Depends on:
Blocks:
 
Reported: 2019-10-04 19:42 UTC by Michał Górny
Modified: 2019-12-07 03:46 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
dictd-dicts-meta-0.ebuild, replaces dictd-dicts (dictd-dicts-meta-0.ebuild,547 bytes, application/octet-stream)
2019-10-17 10:17 UTC, Peter Gantner (a.k.a. nephros)
Details
dictd-devils-0-r1.ebuild, EAPI7, SRC_URI corrected (dictd-devils-0-r1.ebuild,476 bytes, text/plain)
2019-10-17 10:20 UTC, Peter Gantner (a.k.a. nephros)
Details
dictd-devils-0-r1.ebuild (dictd-devils-0-r1.ebuild,509 bytes, application/octet-stream)
2019-10-17 11:41 UTC, Peter Gantner (a.k.a. nephros)
Details
dictd-dicts-meta-0.ebuild (dictd-dicts-meta-0.ebuild,545 bytes, application/octet-stream)
2019-10-17 11:41 UTC, Peter Gantner (a.k.a. nephros)
Details
dictd-elements-2000.22.07-r1.ebuild (dictd-elements-2000.22.07-r1.ebuild,529 bytes, application/octet-stream)
2019-10-17 11:41 UTC, Peter Gantner (a.k.a. nephros)
Details
dictd-foldoc-2018.12.30.ebuild (dictd-foldoc-2018.12.30.ebuild,541 bytes, application/octet-stream)
2019-10-17 11:42 UTC, Peter Gantner (a.k.a. nephros)
Details
dictd-gazetteer-1.2-r1.ebuild (dictd-gazetteer-1.2-r1.ebuild,560 bytes, application/octet-stream)
2019-10-17 11:42 UTC, Peter Gantner (a.k.a. nephros)
Details
dictd-gcide-0.48.5.ebuild (dictd-gcide-0.48.5.ebuild,635 bytes, application/octet-stream)
2019-10-17 11:43 UTC, Peter Gantner (a.k.a. nephros)
Details
dictd-jargon-4.4.7.ebuild (dictd-jargon-4.4.7.ebuild,503 bytes, application/octet-stream)
2019-10-17 11:44 UTC, Peter Gantner (a.k.a. nephros)
Details
First two updated ebuilds (dictd-jargon and dictd-elements) (0001-app-dicts-dictd-elements-jargon-New-ebuilds-to-satis.patch,11.01 KB, patch)
2019-10-26 21:35 UTC, Samuel May
Details | Diff
First two updated ebuilds (dictd-jargon and dictd-elements) r1 (0001-app-dicts-dictd-elements-jargon-New-ebuilds-to-satis.patch,11.01 KB, patch)
2019-11-01 01:52 UTC, Samuel May
Details | Diff
Build dict-web1913 from scratch (0001-app-dicts-dictd-web1913-Build-from-scratch-while-sat.patch,10.10 KB, patch)
2019-11-01 06:59 UTC, Samuel May
Details | Diff
Build dict-web1913 from scratch r1 (0001-app-dicts-dictd-web1913-Build-from-scratch-while-sat.patch,10.10 KB, patch)
2019-11-01 18:53 UTC, Samuel May
Details | Diff
Sum of ebuild updates (0001-app-dicts-dictd-New-ebuilds-to-satisfy-bug-696248.patch,40.34 KB, patch)
2019-11-02 17:40 UTC, Samuel May
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2019-10-04 19:42:20 UTC
Unmaintained, EAPI 0.
Comment 1 Larry the Git Cow gentoo-dev 2019-10-04 19:43:44 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=2bb24337200c51d566f91e848517f7865bea858f

commit 2bb24337200c51d566f91e848517f7865bea858f
Author:     Michał Górny <mgorny@gentoo.org>
AuthorDate: 2019-10-04 19:42:48 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2019-10-04 19:43:39 +0000

    package.mask: Last rite app-dicts/dictd-* EAPI 0
    
    Bug: https://bugs.gentoo.org/696248
    Signed-off-by: Michał Górny <mgorny@gentoo.org>

 profiles/package.mask | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
Comment 2 Peter Gantner (a.k.a. nephros) 2019-10-17 10:17:17 UTC
Created attachment 592978 [details]
dictd-dicts-meta-0.ebuild, replaces dictd-dicts

In case anyone cares, here are some EAPI7 and SRC_URI corrected versions of these ebuilds
Comment 3 Peter Gantner (a.k.a. nephros) 2019-10-17 10:20:47 UTC
Created attachment 592980 [details]
dictd-devils-0-r1.ebuild, EAPI7, SRC_URI corrected
Comment 4 Peter Gantner (a.k.a. nephros) 2019-10-17 11:41:18 UTC
Created attachment 592982 [details]
dictd-devils-0-r1.ebuild
Comment 5 Peter Gantner (a.k.a. nephros) 2019-10-17 11:41:39 UTC
Created attachment 592984 [details]
dictd-dicts-meta-0.ebuild
Comment 6 Peter Gantner (a.k.a. nephros) 2019-10-17 11:41:59 UTC
Created attachment 592986 [details]
dictd-elements-2000.22.07-r1.ebuild
Comment 7 Peter Gantner (a.k.a. nephros) 2019-10-17 11:42:18 UTC
Created attachment 592988 [details]
dictd-foldoc-2018.12.30.ebuild
Comment 8 Peter Gantner (a.k.a. nephros) 2019-10-17 11:42:39 UTC
Created attachment 592990 [details]
dictd-gazetteer-1.2-r1.ebuild
Comment 9 Peter Gantner (a.k.a. nephros) 2019-10-17 11:43:40 UTC
Created attachment 592992 [details]
dictd-gcide-0.48.5.ebuild

GCIDE includes Webster 1913, so this replaces it
Comment 10 Peter Gantner (a.k.a. nephros) 2019-10-17 11:44:13 UTC
Created attachment 592994 [details]
dictd-jargon-4.4.7.ebuild
Comment 11 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2019-10-17 12:11:22 UTC
Attaching a dozen files on Bugzilla doesn't help.  Even if we could legally use them (read the big message over attachment form), fetching them all is more work than bumping the ebuilds by hand.
Comment 12 Peter Gantner (a.k.a. nephros) 2019-10-17 12:30:56 UTC
(In reply to Michał Górny from comment #11)
> Attaching a dozen files on Bugzilla doesn't help.  Even if we could legally
> use them (read the big message over attachment form), fetching them all is
> more work than bumping the ebuilds by hand.

Okay sorry, I was using (py)bugz so I neither see the disclaimer, and that's also the reason for the application/octet-stream.

In the mask comment you say:

> If you want
> them to stay, please sacrifice the 30 minutes of your life needed
> to port them to EAPI 7, recheck license, update URIs, etc.

which I read and though well okay I shall do that.
Comment 13 Samuel May 2019-10-26 21:35:50 UTC
Created attachment 594056 [details, diff]
First two updated ebuilds (dictd-jargon and dictd-elements)

While Peter Gantner's updates (should -- I haven't tested them) work if we wrap them up a bit more nicely, it feels a bit weird to be pulling prepared files from another distribution, when part of the point of Gentoo is to build things ourselves.  That said, either I have a selectively-bad FTP installation or the dict.org hosting is broken, so I've needed to chase originals down in weird places; you'll notice I had to go to the Wayback Machine to get the Elements source, which might arguably be worse than Ubuntu but at least gives a newer revision.  I'll be working through the others, but they were even less easily found than these two, and I've gotten sidetracked into quickly writing a translator for Webster's.

Additionally, while we're overhauling this, does anyone actually feel a need for dictd-dicts(-meta)?  I get its purpose in tightly-bound software suites, but here I'd think most people would only use a couple of the dictionaries and ignore the rest -- and it's not too difficult to simply add all of them to @world if someone does want them all anyway.
Comment 14 Samuel May 2019-11-01 01:52:43 UTC
Created attachment 594712 [details, diff]
First two updated ebuilds (dictd-jargon and dictd-elements) r1

My previous patch left a brace in the source URL for dictd-elements.  Here's a new one.
Comment 15 Samuel May 2019-11-01 06:59:59 UTC
Created attachment 594718 [details, diff]
Build dict-web1913 from scratch

This was a good exercise in a few new technologies that I've been needing to check out for future projects.  It's not (yet) as pretty as the original, but things seem to at least be building nicely for now.
Comment 16 Samuel May 2019-11-01 18:53:41 UTC
Created attachment 594776 [details, diff]
Build dict-web1913 from scratch r1

...And this time I forgot to mark the arches as ~testing.  Always the deceptively small things that sneak past proofreading.
Comment 17 Samuel May 2019-11-02 17:40:07 UTC
Created attachment 594906 [details, diff]
Sum of ebuild updates

As I changed a few things across every package for a consistent experience anyway, I figured I may as well squash everything I've done into a single patch.

Since I'm not going to have much time around work for the next couple days, I think this can be considered the final state of the new ebuilds, until after the removal deadline.  I'll email this out to proxy-maint as well, and offer to take responsibility for these packages.
Comment 18 Joonas Niilola gentoo-dev 2019-11-06 05:32:23 UTC
(In reply to Samuel May from comment #17)
> Created attachment 594906 [details, diff] [details, diff]
> Sum of ebuild updates
> 
> As I changed a few things across every package for a consistent experience
> anyway, I figured I may as well squash everything I've done into a single
> patch.
> 
> Since I'm not going to have much time around work for the next couple days,
> I think this can be considered the final state of the new ebuilds, until
> after the removal deadline.  I'll email this out to proxy-maint as well, and
> offer to take responsibility for these packages.

Hey, 

thanks for your contributions. I see you've done a lot already, but looking at your ebuilds, there's still much to do. Reviewing in Bugzilla is hard and annoying for both of us, so could we move the workflow to Github please, where pretty much all the proxy-maint / maintainer-needed packages are reviewed and then merged into ::gentoo. I see from your patch that you are familiar with Git, but if you need help getting them to Github, just ask. 
https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers/User_Guide#GitHub_Pull_Requests
If you avoid Gitub due to some principle, you can ping me at Gitlab for example to take a look, but Github has integrated CI checking for your contributions...
Comment 19 Samuel May 2019-11-09 01:13:52 UTC
(In reply to Joonas Niilola from comment #18)
> thanks for your contributions. I see you've done a lot already, but looking
> at your ebuilds, there's still much to do. Reviewing in Bugzilla is hard and
> annoying for both of us, so could we move the workflow to Github please,
> where pretty much all the proxy-maint / maintainer-needed packages are
> reviewed and then merged into ::gentoo.
Done!

> If you avoid Gitub due to some principle, you can ping me at Gitlab for
> example to take a look, but Github has integrated CI checking for your
> contributions...
I do have a bit of a traditionalism thing that gets easily triggered by arguments for universal access; in this case a few posts by Drew DeVault:
https://drewdevault.com/2019/05/24/What-is-a-fork.html
https://drewdevault.com/2018/07/23/Git-is-already-distributed.html

That said, avoiding a usable and established workflow in an existing project because of inconsequential quibbles is just being petty.  GitHub it is!
Comment 20 Arfrever Frehtes Taifersar Arahesis 2019-12-07 03:46:06 UTC
https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=aac58fdcc1e2fdeea7d1b04d3ba7e65d409b2514

commit aac58fdcc1e2fdeea7d1b04d3ba7e65d409b2514
Author:     Aaron Bauman <bman@gentoo.org>
AuthorDate: 2019-11-10 00:58:37 +0000
Commit:     Aaron Bauman <bman@gentoo.org>
CommitDate: 2019-11-10 00:59:25 +0000

    app-dicts/*: drop last-rited packages
    
    Signed-off-by: Aaron Bauman <bman@gentoo.org>