After latest changes to flag-o-matic.eclass (https://gitweb.gentoo.org/repo/gentoo.git/commit/eclass/flag-o-matic.eclass?id=cab160d3c614472e20f145e65a2d7f72bdf615b7) I am unable to emerge glibc-2.30-r1. Reproducible: Always Steps to Reproduce: 1. emerge glibc-2.30-r1 Actual Results: This fails with: ../misc/syslog.c:121:30: error: inlining failed in call to always_inline ‘syslog’: function not inlinable ... make[2]: *** [/var/tmp/portage/sys-libs/glibc-2.30-r1/work/build-x86-x86_64-pc-linux-gnu-nptl/sysd-rules:229: /var/tmp/portage/sys-libs/glibc-2.30-r1/work/build-x86-x86_64-pc-linux-gnu-nptl/misc/syslog.os] Error 1 make[2]: *** Waiting for unfinished jobs.... make[2]: Leaving directory '/var/tmp/portage/sys-libs/glibc-2.30-r1/work/glibc-2.30/misc' make[1]: *** [Makefile:260: misc/subdir_lib] Error 2 make[1]: Leaving directory '/var/tmp/portage/sys-libs/glibc-2.30-r1/work/glibc-2.30' make: *** [Makefile:9: all] Error 2 make: Leaving directory '/var/tmp/portage/sys-libs/glibc-2.30-r1/work/build-x86-x86_64-pc-linux-gnu-nptl' Expected Results: glibc compiles fine with the latest change to flag-o-matic reversed.
Created attachment 591272 [details] emerge --info
Can you also attach full build logs for completeness? I'll try to reproduce locally meanwhile.
Created attachment 591274 [details] build log
Yeah, we have 2 problems here: 1. type -P does not like extra arguments: $ type -P x86_64-pc-linux-gnu-gcc -m64; echo $? /usr/lib/ccache/bin/x86_64-pc-linux-gnu-gcc 1 $ type -P x86_64-pc-linux-gnu-gcc ; echo $? /usr/lib/ccache/bin/x86_64-pc-linux-gnu-gcc 0 2. The effect of this change is to drop CFLAGS passing completely without any warning.
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=60328373651331a8d1beab33f4a499e0b3ad61d7 commit 60328373651331a8d1beab33f4a499e0b3ad61d7 Author: Sergei Trofimovich <slyfox@gentoo.org> AuthorDate: 2019-09-30 08:52:04 +0000 Commit: Sergei Trofimovich <slyfox@gentoo.org> CommitDate: 2019-09-30 09:00:31 +0000 flag-o-matic.eclass: fix test-flag-PROG() for CC="gcc -m64" bug #695706 added compiler validation via 'type -p ${CC}', but that does not take into account possible options present in ${CC} itself: $ type -P x86_64-pc-linux-gnu-gcc -m64; echo $? /usr/lib/ccache/bin/x86_64-pc-linux-gnu-gcc 1 $ type -P x86_64-pc-linux-gnu-gcc ; echo $? /usr/lib/ccache/bin/x86_64-pc-linux-gnu-gcc 0 The change picks first argument (binary name) and validates only that. Reported-by: Pavol Cupka Closes: https://bugs.gentoo.org/695888 Bug: https://bugs.gentoo.org/show_bug.cgi?id=695706 Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org> eclass/flag-o-matic.eclass | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)
Thank you for the fast fix!
*** Bug 695930 has been marked as a duplicate of this bug. ***
