Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 695698 - virtual/cargo should go away
Summary: virtual/cargo should go away
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Rust Project
URL: https://github.com/gentoo/gentoo/pull...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-09-26 23:24 UTC by Georgy Yakovlev
Modified: 2020-02-18 03:37 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Georgy Yakovlev archtester gentoo-dev 2019-09-26 23:24:28 UTC
currently we have 2 virtuals: cargo and rust, both essentially do the same thing.

virtual/cargo is from the times we had cargo as separate package.
also it's version mimics rustc version and does not correspond to actual cargo version.

some packages require at least certain version of rustc to build and virtual/rust should be used to define the dep.


I think we should get rid of virtual/cargo.

here's list of consumers that will have to be migrated to virtual/rust dep

eclass/cargo.eclass
eclass/mozconfig-v6.60.eclass
mail-client/thunderbird/thunderbird-60.9.0.ebuild
mail-client/thunderbird/thunderbird-68.1.1.ebuild
mail-client/thunderbird/thunderbird-60.8.0.ebuild
www-client/firefox/firefox-69.0.1.ebuild
www-client/firefox/firefox-68.1.0.ebuild
dev-util/cbindgen/cbindgen-0.9.1.ebuild
dev-util/cbindgen/cbindgen-0.7.1.ebuild
dev-util/cbindgen/cbindgen-0.8.7.ebuild
dev-util/cbindgen/cbindgen-0.8.2.ebuild
dev-util/cbindgen/cbindgen-0.9.0.ebuild
sys-apps/habitat/habitat-0.54.0.ebuild
net-news/newsboat/newsboat-2.16.1.ebuild

Thoughts?
Comment 1 Georgy Yakovlev archtester gentoo-dev 2019-09-26 23:25:10 UTC
adding mozilla guys, as they have a lot of deps on it.
Comment 2 Larry the Git Cow gentoo-dev 2019-10-06 11:41:58 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5d2b662cdfd392ee5c7816bfe301f8cadd65a06d

commit 5d2b662cdfd392ee5c7816bfe301f8cadd65a06d
Author:     Thomas Deutschmann <whissi@gentoo.org>
AuthorDate: 2019-10-06 11:40:20 +0000
Commit:     Thomas Deutschmann <whissi@gentoo.org>
CommitDate: 2019-10-06 11:41:48 +0000

    dev-util/cbindgen: drop virtual/cargo
    
    Bug: https://bugs.gentoo.org/695698
    Package-Manager: Portage-2.3.76, Repoman-2.3.17
    Signed-off-by: Thomas Deutschmann <whissi@gentoo.org>

 dev-util/cbindgen/cbindgen-0.9.1.ebuild | 2 --
 1 file changed, 2 deletions(-)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=627259b601a8242c38a2e93143f12a67232bb587

commit 627259b601a8242c38a2e93143f12a67232bb587
Author:     Thomas Deutschmann <whissi@gentoo.org>
AuthorDate: 2019-10-06 11:36:59 +0000
Commit:     Thomas Deutschmann <whissi@gentoo.org>
CommitDate: 2019-10-06 11:41:46 +0000

    mail-client/thunderbird: drop virtual/cargo
    
    Bug: https://bugs.gentoo.org/695698
    Package-Manager: Portage-2.3.76, Repoman-2.3.17
    Signed-off-by: Thomas Deutschmann <whissi@gentoo.org>

 mail-client/thunderbird/thunderbird-60.9.0.ebuild | 2 --
 mail-client/thunderbird/thunderbird-68.1.1.ebuild | 1 -
 2 files changed, 3 deletions(-)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=823290e520d72dbd88c3a6f6e327c8bb49c090cb

commit 823290e520d72dbd88c3a6f6e327c8bb49c090cb
Author:     Thomas Deutschmann <whissi@gentoo.org>
AuthorDate: 2019-10-06 11:32:42 +0000
Commit:     Thomas Deutschmann <whissi@gentoo.org>
CommitDate: 2019-10-06 11:41:42 +0000

    www-client/firefox: drop virtual/cargo
    
    Bug: https://bugs.gentoo.org/695698
    Package-Manager: Portage-2.3.76, Repoman-2.3.17
    Signed-off-by: Thomas Deutschmann <whissi@gentoo.org>

 eclass/mozconfig-v6.60.eclass            | 2 --
 www-client/firefox/firefox-68.1.0.ebuild | 1 -
 www-client/firefox/firefox-69.0.2.ebuild | 1 -
 3 files changed, 4 deletions(-)
Comment 3 Thomas Deutschmann (RETIRED) gentoo-dev 2019-10-06 11:44:31 UTC
All Mozilla packages should no longer depend on virtual/cargo. Mozilla out.

Note: You have to update cargo eclass which is used by dev-util/cbindgen for example, which is still pulling in virtual/cargo.
Comment 4 Georgy Yakovlev archtester gentoo-dev 2019-10-06 21:22:15 UTC
Thanks!
Yes, that’s the plan, just needed all packages depending on it explicitly to be adjusted.
Comment 5 Larry the Git Cow gentoo-dev 2019-10-08 19:11:22 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6499af4bad0ae58f786d00e09f782cc78ca38aef

commit 6499af4bad0ae58f786d00e09f782cc78ca38aef
Author:     Georgy Yakovlev <gyakovlev@gentoo.org>
AuthorDate: 2019-10-08 19:10:32 +0000
Commit:     Georgy Yakovlev <gyakovlev@gentoo.org>
CommitDate: 2019-10-08 19:10:32 +0000

    sys-apps/habitat: remove virtual/cargo dep
    
    Bug: https://bugs.gentoo.org/695698
    Package-Manager: Portage-2.3.76, Repoman-2.3.17
    Signed-off-by: Georgy Yakovlev <gyakovlev@gentoo.org>

 sys-apps/habitat/habitat-0.54.0.ebuild | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)
Comment 6 Larry the Git Cow gentoo-dev 2019-10-09 23:24:09 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=977d011fc60f303d758bd1bf733be3ac2508df6a

commit 977d011fc60f303d758bd1bf733be3ac2508df6a
Author:     Georgy Yakovlev <gyakovlev@gentoo.org>
AuthorDate: 2019-10-09 23:23:35 +0000
Commit:     Georgy Yakovlev <gyakovlev@gentoo.org>
CommitDate: 2019-10-09 23:23:49 +0000

    net-news/newsboat: remove virtual/cargo dep
    
    Bug: https://bugs.gentoo.org/695698
    Package-Manager: Portage-2.3.76, Repoman-2.3.17
    Signed-off-by: Georgy Yakovlev <gyakovlev@gentoo.org>

 net-news/newsboat/newsboat-2.16.1.ebuild | 1 -
 1 file changed, 1 deletion(-)
Comment 7 Georgy Yakovlev archtester gentoo-dev 2019-10-25 23:42:24 UTC
sent removal for ML review
https://archives.gentoo.org/gentoo-dev/message/8ac8ba7030fd792aace427e64542863b
Comment 8 Larry the Git Cow gentoo-dev 2019-12-30 06:42:32 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=2d95422ba89cfe84cfa579b1b0d1e2fe947c7f3f

commit 2d95422ba89cfe84cfa579b1b0d1e2fe947c7f3f
Author:     Georgy Yakovlev <gyakovlev@gentoo.org>
AuthorDate: 2019-12-30 06:17:58 +0000
Commit:     Georgy Yakovlev <gyakovlev@gentoo.org>
CommitDate: 2019-12-30 06:42:16 +0000

    profiles/package.deprecated: deprecate virtual/cargo
    
    Bug: https://bugs.gentoo.org/695698
    Signed-off-by: Georgy Yakovlev <gyakovlev@gentoo.org>

 profiles/package.deprecated | 5 +++++
 1 file changed, 5 insertions(+)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a9396c31d51a4752a2bdc54fa73019825d2bdcc6

commit a9396c31d51a4752a2bdc54fa73019825d2bdcc6
Author:     Georgy Yakovlev <gyakovlev@gentoo.org>
AuthorDate: 2019-12-30 05:06:09 +0000
Commit:     Georgy Yakovlev <gyakovlev@gentoo.org>
CommitDate: 2019-12-30 06:34:52 +0000

    eclass/cargo.eclass: switch (b)depend to virtual/rust
    
    Bug: https://bugs.gentoo.org/695698
    Signed-off-by: Georgy Yakovlev <gyakovlev@gentoo.org>

 eclass/cargo.eclass | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
Comment 9 Larry the Git Cow gentoo-dev 2020-01-27 02:46:35 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0143c42f1fd4cab80fa97185466b75d867ce1fa5

commit 0143c42f1fd4cab80fa97185466b75d867ce1fa5
Author:     Georgy Yakovlev <gyakovlev@gentoo.org>
AuthorDate: 2020-01-27 02:41:57 +0000
Commit:     Georgy Yakovlev <gyakovlev@gentoo.org>
CommitDate: 2020-01-27 02:41:57 +0000

    profiles: Last rite virtual/cargo
    
    Bug: https://bugs.gentoo.org/695698
    Signed-off-by: Georgy Yakovlev <gyakovlev@gentoo.org>

 profiles/package.mask | 8 ++++++++
 1 file changed, 8 insertions(+)
Comment 10 Larry the Git Cow gentoo-dev 2020-02-18 03:37:04 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=32987270f97cc9d8fe06db4baf7e14f4ca97ec55

commit 32987270f97cc9d8fe06db4baf7e14f4ca97ec55
Author:     Georgy Yakovlev <gyakovlev@gentoo.org>
AuthorDate: 2020-02-18 03:33:06 +0000
Commit:     Georgy Yakovlev <gyakovlev@gentoo.org>
CommitDate: 2020-02-18 03:36:37 +0000

    virtual/cargo: remove last rited package
    
    Closes: https://bugs.gentoo.org/695698
    
    Signed-off-by: Georgy Yakovlev <gyakovlev@gentoo.org>

 virtual/cargo/cargo-1.37.0.ebuild | 17 -----------------
 virtual/cargo/cargo-1.38.0.ebuild | 17 -----------------
 virtual/cargo/cargo-1.39.0.ebuild | 17 -----------------
 virtual/cargo/cargo-1.40.0.ebuild | 15 ---------------
 virtual/cargo/metadata.xml        |  8 --------
 5 files changed, 74 deletions(-)

Additionally, it has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=bfac70fc9cc4dcd164b80d37e8180cdbc1d15b8a

commit bfac70fc9cc4dcd164b80d37e8180cdbc1d15b8a
Author:     Georgy Yakovlev <gyakovlev@gentoo.org>
AuthorDate: 2020-02-18 03:35:39 +0000
Commit:     Georgy Yakovlev <gyakovlev@gentoo.org>
CommitDate: 2020-02-18 03:36:38 +0000

    profiles/package.mask: drop virtual/cargo mask
    
    Bug: https://bugs.gentoo.org/695698
    
    Signed-off-by: Georgy Yakovlev <gyakovlev@gentoo.org>

 profiles/package.mask | 8 --------
 1 file changed, 8 deletions(-)