Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 695632 - net-misc/chrony - configure sets empty hwclockfile by default instead of /etc/adjtime
Summary: net-misc/chrony - configure sets empty hwclockfile by default instead of /etc...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Jeroen Roovers (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-09-25 16:38 UTC by Mike Gilbert
Modified: 2020-08-31 10:04 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Gilbert gentoo-dev 2019-09-25 16:38:52 UTC
The chrony configure script has an option to set the default value for hwclockfile.

> --with-hwclockfile=PATH Specify default path to hwclock(8) adjtime file

Setting this to /etc/adjtime would allow better integration with the hwclock command and systemd's timedatectl command, which use this file to track whether the hardware clock is kept in UTC or local time.

https://www.freedesktop.org/software/systemd/man/timedatectl.html#set-local-rtc%20%5BBOOL%5D
Comment 1 Jeroen Roovers (RETIRED) gentoo-dev 2019-09-26 07:53:02 UTC
Setting this by default implies that it needs to be unset or overridden *everywhere else*. I would rather see this appended to a "default" /etc/chrony/chrony.conf based on USE=systemd if that is what is needed for or convenient for systemd users.
Comment 2 Mike Gilbert gentoo-dev 2019-09-26 15:58:21 UTC
Would you be ok with adding hwclockfile to the default config file unconditionally? I really dislike adding systemd-specific behavior to a package that doesn't already have a systemd USE flag.
Comment 3 Jeroen Roovers (RETIRED) gentoo-dev 2020-08-31 10:04:37 UTC
(In reply to Jeroen Roovers from comment #1)
> Setting this by default implies that it needs to be unset or overridden
> *everywhere else*. I would rather see this appended to a "default"
> /etc/chrony/chrony.conf based on USE=systemd if that is what is needed for
> or convenient for systemd users.

I was wrong. Setting --with-hwclockfile=PATH simply sets the default path to something other that an empty string, and does not enable or enable any features by default.
Comment 4 Larry the Git Cow gentoo-dev 2020-08-31 10:04:58 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5ed24bf963f91c20a0433a16c6e7e3c03dd0dbff

commit 5ed24bf963f91c20a0433a16c6e7e3c03dd0dbff
Author:     Jeroen Roovers <jer@gentoo.org>
AuthorDate: 2020-08-31 10:04:20 +0000
Commit:     Jeroen Roovers <jer@gentoo.org>
CommitDate: 2020-08-31 10:04:56 +0000

    net-misc/chrony: Set default path for hwclockfile
    
    Package-Manager: Portage-3.0.4, Repoman-3.0.1
    Closes: https://bugs.gentoo.org/695632
    Signed-off-by: Jeroen Roovers <jer@gentoo.org>

 net-misc/chrony/chrony-3.5.1-r1.ebuild | 1 +
 net-misc/chrony/chrony-4.0_pre3.ebuild | 1 +
 net-misc/chrony/chrony-9999.ebuild     | 1 +
 3 files changed, 3 insertions(+)