Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 695610 - net-misc/chrony improperly quotes configure arguments
Summary: net-misc/chrony improperly quotes configure arguments
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Jeroen Roovers (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-09-25 06:42 UTC by Mike Gilbert
Modified: 2019-09-26 07:36 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
clean up configure arguments (0001-net-misc-chrony-clean-up-configure-arguments.patch,4.25 KB, patch)
2019-09-25 06:44 UTC, Mike Gilbert
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Gilbert gentoo-dev 2019-09-25 06:42:40 UTC
The chrony ebuild assigns a variable called CHRONY_CONFIGURE a string containing the arguments to be passed to the configure script.

This assignment inconsistently applies backslash escapes, and improperly fails to quote the EPREFIX variable. It also fails to apply EPREFIX to all necessary paths.
Comment 1 Mike Gilbert gentoo-dev 2019-09-25 06:44:19 UTC
Created attachment 591010 [details, diff]
clean up configure arguments

Here's a patch which may be applied using git-am.
Comment 2 Larry the Git Cow gentoo-dev 2019-09-26 07:36:18 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=53851d0721fd2ecce0bace26725d59397de34882

commit 53851d0721fd2ecce0bace26725d59397de34882
Author:     Mike Gilbert <floppym@gentoo.org>
AuthorDate: 2019-09-25 06:39:27 +0000
Commit:     Jeroen Roovers <jer@gentoo.org>
CommitDate: 2019-09-26 07:36:04 +0000

    net-misc/chrony: clean up configure arguments
    
    Closes: https://bugs.gentoo.org/695610
    Package-Manager: Portage-2.3.75_p7, Repoman-2.3.17_p49
    Signed-off-by: Mike Gilbert <floppym@gentoo.org>
    Signed-off-by: Jeroen Roovers <jer@gentoo.org>

 net-misc/chrony/chrony-3.5.ebuild  | 47 +++++++++++++++++++-------------------
 net-misc/chrony/chrony-9999.ebuild | 47 +++++++++++++++++++-------------------
 2 files changed, 46 insertions(+), 48 deletions(-)