Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 695262 - app-portage/ufed-0.94: fails to run with `"\x{2019}" does not map to iso-8859-1`
Summary: app-portage/ufed-0.94: fails to run with `"\x{2019}" does not map to iso-8859-1`
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: Normal normal (vote)
Assignee: Sven Eden
URL:
Whiteboard:
Keywords: PullRequest
: 695272 (view as bug list)
Depends on:
Blocks:
 
Reported: 2019-09-21 06:19 UTC by nE0sIghT
Modified: 2019-09-28 06:46 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description nE0sIghT 2019-09-21 06:19:15 UTC
> ufed
"\x{2019}" does not map to iso-8859-1 at /usr/sbin/ufed line 143.
"\x{2019}" does not map to iso-8859-1 at /usr/sbin/ufed line 143.
"\x{2019}" does not map to iso-8859-1 at /usr/sbin/ufed line 143.
"\x{2019}" does not map to iso-8859-1 at /usr/sbin/ufed line 143.
"\x{2019}" does not map to iso-8859-1 at /usr/sbin/ufed line 143.
"\x{2019}" does not map to iso-8859-1 at /usr/sbin/ufed line 143.

ERROR in /var/tmp/portage/app-portage/ufed-0.94/work/ufed-0.94/ufed-curses-checklist.c:148 (read_flags): 
 -> Description read failed on line 5656
"	This is a meta-flag for rarely needed modules that in themselves need not much build time. If you would like to have any of the following modules to have their own USE flag, please open a bug report and it will most probably get one. Alexa for Business : Manage Alexa devices, enroll users, and assign skills. AWS Migration Hub : A single location to track migration tasks across multiple AWS tools and partner solutions. Amazon Cloud Directory : Store hundreds of millions of application-specific objects with multiple relationships and schemas. Amazon Comprehend : Natural language processing (NLP) to extract insights about the content of documents without the need of any special preprocessing. Comprehend Medical : Specialized Amazon Comprehend variant to extract insights from clinical documents such as doctor\x{2019}s notes or clinical trial reports. Amazon Connect : A contact center as a service (CCaS) solution that offers easy, self- service configuration and enables dynamic, personal, and natural customer engagement at any scale. AWS Data Pipeline : A web service to automate the movement and transformation of data. AWS Data Sync : A data-transfer service that simplifies, automates, and accelerates moving and replicating data between on-premises storage systems and AWS storage services over the internet or AWS Direct Connect. AWS Direct Connect : Link your internal network to an AWS Direct Connect location over a standard 1 gigabit or 10 gigabit Ethernet fiber-optic cable. Application Discovery : Automatically identify applications running in on-premises data centers, their associated dependencies, and their performance profile. Database Migration (DMS): Migrate data from a database that is on-premises, on an Amazon Relational Database Service (Amazon RDS) DB instance, or in a database on an Amazon Elastic Compute Cloud (Amazon EC2) instance to a database on an AWS service. Amazon DocumentDB : Fully managed database service to set up, operate, and scale MongoDB- compatible databases. AWS Directory Service : A web"
Comment 1 Arfrever Frehtes Taifersar Arahesis 2019-09-21 09:45:47 UTC
*** Bug 695272 has been marked as a duplicate of this bug. ***
Comment 2 Charo del Genio 2019-09-21 10:39:18 UTC
I can confirm this. Also, the problem is actually twofold: one part is the "\x{2019}" characters, and the other is the length of the line. They both, individually, cause ufed to crash.
Comment 3 Todd Walter 2019-09-23 14:11:57 UTC
I second that.  Just hit this this morning.
Comment 4 Sven Eden 2019-09-23 18:20:37 UTC
I will check how I can remedy this.

When I re-worked the aws-sdk-cpp USE flags, I clearly missed that characters. But I wouldn't have guessed that the length of the line is a problem.
Comment 5 Sven Eden 2019-09-24 06:11:57 UTC
Hmmm... I have created a PR for the offending characters in the metadata.xml
See: https://github.com/gentoo/gentoo/pull/13025

As for the other error, ufed is limited to a description of 2048 lines, but that flag got 5331.

I'll see where I can impose that limit efficiently.
Comment 6 Sven Eden 2019-09-24 08:47:52 UTC
The metadata is already fixed in the tree.

I have a solution for the line length problem, but my time ran out this morning. I'll finish it tonight.
Comment 7 nE0sIghT 2019-09-24 08:51:58 UTC
UTF-8 issue was fixed in https://github.com/gentoo/gentoo/commit/8496a598cf48d8be8d2f5fe80f7360593a29a8fb

Description length is not fixed for now.
PR https://github.com/gentoo/gentoo/pull/13025 is unrelated in current state.
Comment 8 Sven Eden 2019-09-24 17:33:05 UTC
(In reply to nE0sIghT from comment #7)
> UTF-8 issue was fixed in
> https://github.com/gentoo/gentoo/commit/
> 8496a598cf48d8be8d2f5fe80f7360593a29a8fb
> 
> Description length is not fixed for now.
> PR https://github.com/gentoo/gentoo/pull/13025 is unrelated in current state.

It was when I opened it. The UTF-8 issue was fixed after I fetched the tree. No it is no longer related, right.

The description length problem is a problem with ufed, not the metadata.xml.
Comment 9 Larry the Git Cow gentoo-dev 2019-09-24 17:57:47 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/ufed.git/commit/?id=5df696152a15ab827381d524c28ce87ee0568a00

commit 5df696152a15ab827381d524c28ce87ee0568a00
Author:     Sven Eden <yamakuzure@gmx.net>
AuthorDate: 2019-09-24 17:45:47 +0000
Commit:     Sven Eden <yamakuzure@gmx.net>
CommitDate: 2019-09-24 17:57:12 +0000

    Do not hand over overly long lines (Fixes bug #695262)
    
    ufed-curses-checklist.c:ufed_getline() is limited to LINE_MAX, which is 2048
    bytes. Unfortunately local USE flags can blast this limit, as ufed.pl also
    transmit an alternative description with stripped keywords.
    
    This commit lets ufed.pl calculate whether a description has to be shorted, and
    does so if needed.
    
    Bug: https://bugs.gentoo.org/695262
    Signed-off-by: Sven Eden <yamakuzure@gmx.net>

 .gitignore |  2 ++
 ufed.pl.in | 13 +++++++++++--
 2 files changed, 13 insertions(+), 2 deletions(-)
Comment 10 Sven Eden 2019-09-24 18:00:31 UTC
(In reply to Larry the Git Cow from comment #9)
> https://gitweb.gentoo.org/proj/ufed.git/commit/?id=5df696152a15ab827381d524c28ce87ee0568a00

I have tested this and it works.
However, before I tag and release it, I would have some feedback that it also works for others as well.

So if anybody of you could test this please? Thanks in advance, and sorry for the inconvenience!
Comment 11 nE0sIghT 2019-09-24 18:03:34 UTC
It works for me, thanks!
Comment 12 Paul Tobias 2019-09-25 00:58:27 UTC
mkdir -p /etc/portage/patches/app-portage/ufed
cd /etc/portage/patches/app-portage/ufed
wget --content-disposition 'https://gitweb.gentoo.org/proj/ufed.git/patch/?id=5df696152a15ab827381d524c28ce87ee0568a00'
emerge -v app-portage/ufed

I see the patch is applied:
 * Applying d7566969c2009d876eefd9016514650faada3521..5df696152a15ab827381d524c28ce87ee0568a00.patch ...                                                                                                                                                                [ ok ]
 * User patches applied.


And it fixes the problem for me.
Comment 13 Larry the Git Cow gentoo-dev 2019-09-25 02:58:50 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=4a7621add86917245ae0e0e40ca7110894428a94

commit 4a7621add86917245ae0e0e40ca7110894428a94
Author:     Sven Eden <yamakuzure@gmx.net>
AuthorDate: 2019-09-24 18:15:54 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2019-09-25 02:58:30 +0000

    dev-libs/aws-sdk-cpp: Shorten the 'other' USE flag description
    
    Unfortunately that description is way too long. It has over 5k characters,
    which is too much, at least for app-portage/ufed and app-portage/euses.
    
    This commit throws away the lengthy description of each module and replaces
    them with a mere list of the modules. As these are supposed to be rarely used
    modules anyway, this shouldn't be a problem. If any of the modules is requested
    to get its own USE flag, we can re-add its proper description.
    
    Bug: https://bugs.gentoo.org/695262
    Bug: https://bugs.gentoo.org/695462
    Package-Manager: Portage-2.3.76, Repoman-2.3.17
    Signed-off-by: Sven Eden <yamakuzure@gmx.net>
    Closes: https://github.com/gentoo/gentoo/pull/13030
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 dev-libs/aws-sdk-cpp/metadata.xml | 76 ++++-----------------------------------
 1 file changed, 6 insertions(+), 70 deletions(-)
Comment 14 Sven Eden 2019-09-25 06:50:43 UTC
(In reply to Paul Tobias from comment #12)
> mkdir -p /etc/portage/patches/app-portage/ufed
> cd /etc/portage/patches/app-portage/ufed
> wget --content-disposition
> 'https://gitweb.gentoo.org/proj/ufed.git/patch/
> ?id=5df696152a15ab827381d524c28ce87ee0568a00'
> emerge -v app-portage/ufed
> 
> I see the patch is applied:
>  * Applying
> d7566969c2009d876eefd9016514650faada3521..
> 5df696152a15ab827381d524c28ce87ee0568a00.patch ...                          
> [ ok ]
>  * User patches applied.
> 
> 
> And it fixes the problem for me.

Thanks!

This will hinder those problems to come up in the future.
Also the offending USE flag in the AWS C++ SDK metadata.xml has bin shortened and pushed to the tree.
Comment 15 Larry the Git Cow gentoo-dev 2019-09-27 06:42:57 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/proj/ufed.git/commit/?id=6bc38442b022588b18577962c56d05cfb7fceede

commit 6bc38442b022588b18577962c56d05cfb7fceede
Author:     Sven Eden <yamakuzure@gmx.net>
AuthorDate: 2019-09-27 06:38:50 +0000
Commit:     Sven Eden <yamakuzure@gmx.net>
CommitDate: 2019-09-27 06:42:12 +0000

    Version 0.95 Release
    
    Closes: https://bugs.gentoo.org/695262
    Signed-off-by: Sven Eden <yamakuzure@gmx.net>

 configure.ac | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 16 Sven Eden 2019-09-27 07:45:34 UTC
That commit was an error, the PR does the close upon merge.
Comment 17 Sven Eden 2019-09-27 07:45:48 UTC
PR is ongoing
Comment 18 Larry the Git Cow gentoo-dev 2019-09-28 06:46:28 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f78f27d77dee16bd72df0c03b3a2904ea6180bff

commit f78f27d77dee16bd72df0c03b3a2904ea6180bff
Author:     Sven Eden <yamakuzure@gmx.net>
AuthorDate: 2019-09-27 07:16:27 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2019-09-28 06:46:15 +0000

    app-portage/ufed: Bump to 0.95 to fix #695262
    
    ufed-curses-checklist.c:ufed_getline() is limited to LINE_MAX, which is 2048
    bytes. Unfortunately local USE flags can blast this limit, as ufed.pl also
    transmit an alternative description with stripped keywords.
    
    This release lets ufed.pl calculate whether a description has to be shorted,
    and does so if needed.
    
    Closes: https://bugs.gentoo.org/695262
    Package-Manager: Portage-2.3.76, Repoman-2.3.17
    Signed-off-by: Sven Eden <yamakuzure@gmx.net>
    Closes: https://github.com/gentoo/gentoo/pull/13053
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 app-portage/ufed/Manifest         |  1 +
 app-portage/ufed/ufed-0.95.ebuild | 37 +++++++++++++++++++++++++++++++++++++
 2 files changed, 38 insertions(+)