media-video/vdr UnderscoreInUseFlag: USE flag 'permashift_v1' uses reserved underscore character
Created attachment 595100 [details, diff] new patchset v2
Created attachment 595102 [details] new ebuild revision
Created attachment 595104 [details, diff] diff vdr-2.2.0-r3 vdr-2.2.0-r4 ebuild
this issius is easy to fix Iam added a new gentoo vdr patchset in this patch, iam moved all variables from PERMASHIFT_V1 to PERMASHIFT-V1 the new -r4.ebuild has the depended changes in use flag from permashift_v1 to permashift-v1 to fix this finaly - add the new patchset to mirror://gentoo - add the ebuild to the tree - add desctiption for the new use flag in metadata.xml <flag name="permashift-v1">permanent timeshift by recording live TV on RAM, need plugin >=mediaplugins/vdr-permashift-1</flag> add the ebuild to archtester x86 amd64 for stabilisation (this could be so fast as possible, as are minimal changes in patchset) after stabilisation - remove media-video/vdr-2.0.6-r1 from the tree - remove media-video/vdr-2.2.0-r3 ebuild from the tree clean metadata.xml from permashift and permashift_v1 description close the bug
the patchset in https://bugs.gentoo.org/attachment.cgi?id=595100 is nonsense, it exchanges expressions #if !defined(USE_PERMASHIFT_V1) to #if !defined(USE_PERMASHIFT-V1) which result in the following compiler errors: In file included from menu.h:17, from config.c:16: dvbplayer.h:35:28: error: missing ')' after "defined" #if !defined(USE_PERMASHIFT-V1) ^ dvbplayer.h:35:29: error: missing binary operator before token "V1" #if !defined(USE_PERMASHIFT-V1) ^~ I implemented a different approach to solve the USE flag rename in https://github.com/gentoo/gentoo/pull/13588
martin, your pullrequest includes errors line 24 vdr-2.2.0-r4.ebuild EXT_P="extpng-${P}-gentoo-edition-v1" has to change to another then the exixting version in the tree EXT_P="extpng-${P}-gentoo-edition-v2" <<<< !!!!!!!!! it is not enough to change only the use flag from permashift_v1 to permashift-v1 did you check the atached diff vdr-2.2.0-r3 vdr-2.2.0-r4 ebuild
Created attachment 595660 [details] new pachset Version 3
Created attachment 595662 [details] vdr ebuild -r4
Created attachment 595664 [details, diff] diff -r3 -r4 ebuild
permashift , permashift_v1 permashift-v1 this is all crap, to fix this permanently, we could use still the use flag permashift. the attached patchset -v3 will fix all issus the attached ebuild -r4 will fix all problems described in the QA report - UnderscoreInUseFlag (fixed) - UnnecessarySlashStrip (fixed) the bug has to be fixed in several steps. 1. - add the extpng-vdr-2.2.0-gentoo-edition-v3.patch to mirror://gentoo - Add the vdr-2.2.0-r4.ebuild to the tree 2. add the bug to ARCH testers AMD64 X86 3. After stabilisation - cleenup vdr-2.0.6-r1.ebuild vdr-2.2.0-r3.ebuild from the tree - check metadata.xml for unused use flags !!!! NOTE: the commit of vdr-2.2.0-r4 will break media-plugins/vdr-permashift-1.0.1 as we have [permashift_v1] in the DEPEND !!! this has to be fixed in parallel
externel URL to download the patchset http://vdr.websitec.de/download/vdr/extpng-vdr-2.2.0-gentoo-edition-v3.patch.bz2 Please, don't use the url in SRC_URI, This is my privat webspace and adding to the ebuild will create a lot of content. After commiting the ebuild i will remove the patchset from my space.
Thanks for pointing out the UnnecessarySlashStrip issue. Definitely NO thanks for NOT testing patchset V2. Patchset V3 is not necessary, the necessary changes are made by a "sed" command, mainly because proxy maintainers cannot add file to mirror://gentoo https://github.com/gentoo/gentoo/pull/13588 has 4 commits now
(In reply to Martin Dummer from comment #12) > Thanks for pointing out the UnnecessarySlashStrip issue. > > Definitely NO thanks for NOT testing patchset V2. Outch, this hurts, but you are right with this. thanks for pointing out the part with the precrompressed man files never i noticed this > Patchset V3 is not necessary, the necessary changes are made by a "sed" > command, mainly because proxy maintainers cannot add file to mirror://gentoo The proxy dev is responsible for this > > https://github.com/gentoo/gentoo/pull/13588 has 4 commits now pull request for media-plugins/permashift has a little error DEPEND=">=media-video/vdr-2.0.6[permashift]" has to changed to DEPEND=">=media-video/vdr-2.2.0-r4[permashift]" because , vdr-2.0.6 has use flag, permashift and permashift_v1 if you use vdr-2.0.6 and use it with media-plugins/vdr-permashift-1.0.1-r1 it will use the wrong patchpart defintiv it will not work on running, maybe on compile prozess befor alternativ we could remove vdr-2.0.6 simultaneously on commit from vdr-2.2.0-r4, then we don't have problems and in this part, we could use (from multilib.eclass) QA_FLAGS_IGNORED="usr/$(get_libdir)/vdr/plugins/libvdr-.*" untested
martin, i noticed it in your pull request: please don't touch the media-video/vdr/files/vdr-2.2.0_gentoo.patch this is part of vdr-2.2.0-r3 STABEL don't touch any parts of the stable ebuild, includes ebuild _and_ patches this will break the stable ebuild! write a new patch with all your needs ie named as vdr-2.2.0-r4_gentoo.patch fix the path then in your vdr-2.2.0-r4 ebuild too .... also, after a sleeples night, removing from vdr-2.0.6-r1 will break the portage, as we have the use flag yaepg still in the media-plugins/vdr-pvr350 i am added a blocking bug for this this has to fixed before
(In reply to Joerg Bornkessel from comment #14) > please don't touch the > media-video/vdr/files/vdr-2.2.0_gentoo.patch > > this is part of vdr-2.2.0-r3 STABEL > > don't touch any parts of the stable ebuild, includes ebuild _and_ patches > this will break the stable ebuild! Basically yes, I also thought of this, but in this case not true. vdr-2.2.0_gentoo.patch works for both vdr-2.2.0-r3.ebuild and vdr-2.2.0-r4.ebuild and fixes the "do not install pre-compressed manpages" issue Please test before alleging it will be broken.
(In reply to Joerg Bornkessel from comment #14) > removing from vdr-2.0.6-r1 will break the portage, as we have the use flag > yaepg > still in the media-plugins/vdr-pvr350 > > i am added a blocking bug for this > this has to fixed before Okay, unstandable issue, I will add another commit in the PR for this.
Created attachment 595886 [details] use sed line to fix use flag issius, use new vdr-2.2.0-r4_gentoo.patch
Created attachment 595890 [details, diff] vdr-2.2.0-r4.patch, to fix install precrompressed file issius
@ martin please use the vdr-2.2.0-r4.ebuild and the vdr-2.2.0-r4_gentoo.patch to create a new pull request. Please, please do not touch the existing STABLE ebuild's or patches there is no reason for this. This will break all rules between ~Stable / Stable for this we have the possibility add another -rx version The only reason to fumble around this, are security problems QA problems are not security problems. This has to fix, but not from here to now. Btw. thanks for all your work, good job until now... ;) PS. please ping me on IRC #gentoo-vdr, i am hang around every full hour to check this.
Created attachment 596002 [details] finaly fix for the UnnecessarySlashStrip problem we use now ${ED} to fix this thanks to mgorny to point this out on request @martin plz do your pullrequst, if you will find time
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c74bc54cd9551339d1479356a74017ec6f641dd7 commit c74bc54cd9551339d1479356a74017ec6f641dd7 Author: Martin Dummer <martin.dummer@gmx.net> AuthorDate: 2019-11-17 01:33:47 +0000 Commit: David Seifert <soap@gentoo.org> CommitDate: 2019-11-17 01:33:47 +0000 media-plugins/vdr-permashift: fix multiple QA issues * QA issue on package media-video/vdr: USE flag 'permashift_v1' uses reserved underscore character rename USE flag 'permashift_v1' to 'permashift' in package that depends on vdr[permashift] Bug: https://bugs.gentoo.org/695066 Package-Manager: Portage-2.3.78, Repoman-2.3.17 Signed-off-by: Martin Dummer <martin.dummer@gmx.net> Signed-off-by: David Seifert <soap@gentoo.org> media-plugins/vdr-permashift/metadata.xml | 16 ++++++++++++---- .../vdr-permashift/vdr-permashift-1.0.1-r1.ebuild | 21 +++++++++++++++++++++ 2 files changed, 33 insertions(+), 4 deletions(-) https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=2f472c1f91d21444530ed18c29a26db3fccc40a8 commit 2f472c1f91d21444530ed18c29a26db3fccc40a8 Author: Martin Dummer <martin.dummer@gmx.net> AuthorDate: 2019-11-17 01:33:46 +0000 Commit: David Seifert <soap@gentoo.org> CommitDate: 2019-11-17 01:33:46 +0000 media-video/vdr: fix multiple QA issues * QA issue: USE flag 'permashift_v1' uses reserved underscore character, rename USE flag 'permashift_v1' to 'permashift' * QA issue: UnnecessarySlashStrip in DESTDIR="${D%/}" * QA issue: makefile installs pre-compressed manpages Bug: https://bugs.gentoo.org/695066 Closes: https://github.com/gentoo/gentoo/pull/13588 Package-Manager: Portage-2.3.78, Repoman-2.3.17 Signed-off-by: Martin Dummer <martin.dummer@gmx.net> Signed-off-by: David Seifert <soap@gentoo.org> media-video/vdr/files/vdr-2.2.0_gentoo.patch | 35 ++-- media-video/vdr/metadata.xml | 12 +- media-video/vdr/vdr-2.2.0-r3.ebuild | 4 +- media-video/vdr/vdr-2.2.0-r4.ebuild | 301 +++++++++++++++++++++++++++ 4 files changed, 334 insertions(+), 18 deletions(-)
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0ad257c1fa1579b49a5e299307267a9bcf69ec73 commit 0ad257c1fa1579b49a5e299307267a9bcf69ec73 Author: Martin Dummer <martin.dummer@gmx.net> AuthorDate: 2019-11-08 19:59:12 +0000 Commit: Joonas Niilola <juippis@gentoo.org> CommitDate: 2019-12-02 15:19:28 +0000 media-video/vdr: remove old ebuilds, fix QA issue QA issue: USE flag 'permashift_v1' uses reserved underscore character remove old ebuilds with USE flag 'permashift_v1': vdr-2.0.6-r1 vdr-2.2.0-r3 Closes: https://bugs.gentoo.org/695066 Closes: https://bugs.gentoo.org/700366 Package-Manager: Portage-2.3.78, Repoman-2.3.17 Signed-off-by: Martin Dummer <martin.dummer@gmx.net> Closes: https://github.com/gentoo/gentoo/pull/13773 Signed-off-by: Joonas Niilola <juippis@gentoo.org> media-video/vdr/Manifest | 2 - media-video/vdr/files/vdr-2.0.6_gentoo.patch | 68 ------ media-video/vdr/metadata.xml | 9 - media-video/vdr/vdr-2.0.6-r1.ebuild | 277 ------------------------ media-video/vdr/vdr-2.2.0-r3.ebuild | 303 --------------------------- 5 files changed, 659 deletions(-) Additionally, it has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=1b37d061a4645b2484359759048668dc96e8105e commit 1b37d061a4645b2484359759048668dc96e8105e Author: Martin Dummer <martin.dummer@gmx.net> AuthorDate: 2019-11-10 22:15:24 +0000 Commit: Joonas Niilola <juippis@gentoo.org> CommitDate: 2019-12-02 15:19:27 +0000 media-plugins/vdr-permashift: remove old ebuild QA issue: USE flag 'permashift_v1' uses reserved underscore character remove old ebuilds with USE flag 'permashift_v1': vdr-permashift-1.0.1 Bug: https://bugs.gentoo.org/695066 Package-Manager: Portage-2.3.78, Repoman-2.3.17 Signed-off-by: Martin Dummer <martin.dummer@gmx.net> Signed-off-by: Joonas Niilola <juippis@gentoo.org> .../vdr-permashift/vdr-permashift-1.0.1.ebuild | 18 ------------------ 1 file changed, 18 deletions(-)
